Received-SPF: pass (google.com: domain of linux-kernel+bounces-176617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 11 May 2024 12:49:00 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Yicong Yang <yangyicong@hisilicon.com>, Kaige Ye <ye@kaige.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf stat: Don't display metric header for non-leader
 uncore events
Message-ID: <Zj-TbLTORdPRlyHC@x1>
References: <20240510051309.2452468-1-irogers@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240510051309.2452468-1-irogers@google.com>

On Thu, May 09, 2024 at 10:13:09PM -0700, Ian Rogers wrote:
> Achieve this by skipping events that aren't metric leaders when
> printing column headers and aggregation isn't disabled.
> 
> The bug is long standing, the fixes tag is set to a refactor as that
> is as far back as is reasonable to backport.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Fixes: 088519f318be ("perf stat: Move the display functions to stat-display.c")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/stat-display.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index ea11e3437444..bb6bbb821b5a 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -1251,6 +1251,9 @@ static void print_metric_headers(struct perf_stat_config *config,
>  
>  	/* Print metrics headers only */
>  	evlist__for_each_entry(evlist, counter) {
> +		if (config->aggr_mode != AGGR_NONE && counter->metric_leader != counter)
> +			continue;
> +
>  		os.evsel = counter;
>  
>  		perf_stat__print_shadow_stats(config, counter, 0,
> -- 
> 2.45.0.118.g7fe29c98d7-goog