Received-SPF: pass (google.com: domain of linux-kernel+bounces-176618-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jiasheng Jiang <jiashengjiangcool@outlook.com>
To: jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com,
	tursulin@ursulin.net,
	airlied@gmail.com,
	daniel@ffwll.ch,
	chris@chris-wilson.co.uk
Cc: intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@outlook.com>
Subject: [PATCH] drm/i915: Correct error handler
Date: Sat, 11 May 2024 15:48:48 +0000
Message-ID:
 <BYAPR03MB41680146FAD88A8F26C3827BADE02@BYAPR03MB4168.namprd03.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BYAPR03MB4168:EE_|MW4PR03MB6540:EE_
X-MS-Office365-Filtering-Correlation-Id: 5e1a62d1-a73d-40e7-2f73-08dc71d1de08
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|3420499023|440099019|3430499023|3412199016|1710799017;
X-Microsoft-Antispam-Message-Info:
	sk0rCforVT/htuuf443BClFV4OIzQW1Al+5frb9PWdlOrQabj6YRPaNfJriLXC2tdzKcFQVcoj0jQFo1tgHWqaCkonLK54oA1EQpwSQuaTVdQi10282Byzb8r9RnYnemY3yIWIQIP1wSuPS6fOnCCJjuLjI3g8tSuFTfOGQs6OChC3m35mvavemWqo1bSISALxH7IK1Aa0MGwXmhlnltQEN7IVexJscQWjkbwxBEgmQB6i9NusiQxgQZh0ZOWfyhLZvSCZo1FuxsLtkS01Xz0qLRww+TxImAsRnvHM0pO+8n5jPtzSJ7y9aUy0zK03sIh1lbswnPai+aOezvwlju2+Y7l5g0C5sV5h6/ixINiE5WYBdBmQ+oKxcU9EOH+EQvkndVuVHqTqpJ4f8er9nwgQLtBhpX7ELy1J17+QTHh+ak4cfeI4dDrDr42VC5GmGJ+9Jh7odm0ZEI+vJmhZtaVceYd4z9XAEAcKGuY+nPy16imJmJldWUuEaw8HXGaF23xgT+fsr8bd+Mx3KjoHNjXjB8MXNHx37rfE0bPGSwCuNMOrzwxJZzSWBHlb01Rhc5rNnCTjFJj5gtur56fjwmVrUSIdE8QzPviqaXGtZYFm65buUFB5JUjRyq3b0U3ZWL
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?yEr6VPBax8czFmUWzFzi/XrIubkEJ5wfEeEtHu5+EgBgYqJg8HFS8MwrbwFA?=
 =?us-ascii?Q?TLI6hr0nFJoWwZjNAUn24etMW+KfhAiOE116KkW2CJJS0WuD2LuGPaoNBYN0?=
 =?us-ascii?Q?VYe/8pbAGYhGNr2KN1+y/H3LNWSmJtEHZ3+YftxBInLODO5ruC7YkHbJUxJm?=
 =?us-ascii?Q?jLT0LYFmSwL89fyeW5Zos+THRxaz+UfkEpWVCe13REjvpO2AnYCZQxx4NfNR?=
 =?us-ascii?Q?RkqHeWh+GR9bJpDXKmiEWAx/3iCOiZZSwoDrtRbXSgfUufNc5Gz7vnXVutMS?=
 =?us-ascii?Q?RYfIbQdexZ1FoX4Zh0BztGbluBRi4Uy272eInkjAO/1heaApsiZiFgaPDmth?=
 =?us-ascii?Q?3d4XfZFbTWetorNv4W9KoBebOdVkhnIrxqAzyeSV1wFgVwyy/vrAGrxoc1tl?=
 =?us-ascii?Q?UGGUaAqHMBLvFksMkvOmyR6Iuvu763FdH3u7aDfZRvhWvKHYA9FJKjAa4Kly?=
 =?us-ascii?Q?r5D3mFufl9FjtPv6Rd4XSCARRkY1fMSTYOIfJkYxvuk/NvdU3KdlAjX2G4sb?=
 =?us-ascii?Q?KGtckbsjasH3XGCYON9jYfy3aIMp1TmcvwykfPu5MgPQzD9LHbAixiNzhM5G?=
 =?us-ascii?Q?DITr37Z6l5++nRqpBXSctePJFeCeCReKgrgRRl+hYcsBKzk6m5Yx+bX1aeQS?=
 =?us-ascii?Q?sZE6SskGbQcsOy3JEk0FosVur2UVPORSxobovsfilQXoZ9dbvM//YiR86QFT?=
 =?us-ascii?Q?vlrgNAfiHGnBbc+F88tIIdNnBJsf1IERyuM51Lg5gbggiUokaxD7ZYP/D4hZ?=
 =?us-ascii?Q?7QoSCYZdXsfAmhrRZ6fLwYflwoHTqsWu0Hn3CsTJJGOnWVdjOj1SFb+XGyLQ?=
 =?us-ascii?Q?TeHgwcUxqJOH7NTw/DTqf9HEHrh0xzEDH491EAOBk6LjygdnMHvRS50klqI1?=
 =?us-ascii?Q?/L6mKfcwk64feE4kVHRduZlwLBduCGT9gIcCR582rTM2zljtnLZ+m/yjDzHD?=
 =?us-ascii?Q?jnY3M+7mvhwk61S/u/Ej9BjD1qzepHft6i+CN6/kauUamU9GoYOFS5wycRNP?=
 =?us-ascii?Q?+nEOpknFXIDKIwEoYUcSELItm8JCh0+mKsdAIASWDkQX2ETwBsHDn9OJmpvS?=
 =?us-ascii?Q?iRM8+aFVgng5v83t5l5wvItmXyZ/bu8EUFVmHbLWWDiY+MVYM8pLIaZpFoMM?=
 =?us-ascii?Q?gm25sxbcfB2QHzK9nb1nhBrJiP/5HS1/eBOdzeie1GBEVbjdFfpVqUUgbHVN?=
 =?us-ascii?Q?b2aKT8R+1wFaJV+GkYIrJF/dzMCrfmHPSww4ibTK7rU1mKPYa0AcyYA5IPFO?=
 =?us-ascii?Q?A/nLxcu3B04smv62yVvg?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e1a62d1-a73d-40e7-2f73-08dc71d1de08
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB4168.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2024 15:48:57.5259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6540

Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak.

Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@outlook.com>
---
 drivers/gpu/drm/i915/i915_scheduler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
index 762127dd56c5..70a854557e6e 100644
--- a/drivers/gpu/drm/i915/i915_scheduler.c
+++ b/drivers/gpu/drm/i915/i915_scheduler.c
@@ -506,6 +506,6 @@ int __init i915_scheduler_module_init(void)
 	return 0;
 
 err_priorities:
-	kmem_cache_destroy(slab_priorities);
+	kmem_cache_destroy(slab_dependencies);
 	return -ENOMEM;
 }
-- 
2.25.1