Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp1142065lqo; Sat, 11 May 2024 09:04:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUQR/UY0YiLxdHo5uQW+j+qV9RrxwnBXFhjUyDX4ILB5mAwglk0zi06lYi0jbzNvtdwIzpFv2M08pnlSL1GVQR7DDT3iLLDYBmeUnl7hg== X-Google-Smtp-Source: AGHT+IH+r8hgNhSyTg+CTSJfnYuj5TkGBUZJI5Fof6qsUEcKe8zc/dPYQbNISfSlCX3WLw1LpRS0 X-Received: by 2002:aa7:cf03:0:b0:573:5966:ca8e with SMTP id 4fb4d7f45d1cf-5735966cedcmr3370415a12.0.1715443464960; Sat, 11 May 2024 09:04:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715443464; cv=pass; d=google.com; s=arc-20160816; b=t2RAoFJI2o01Kw+SIYZSOvydXvSEaAz8ijdLOqxyQWqR4ZXtm8gLAsd+JcP5VHc5ea nohPnGqS5y/s42xZaZ0iQ0voFWrjv/P5ipI7CQSO9BluznHIpsx26GpgHBf/mU8FfOxY 6xiWZ8lcoqidRSPcGp2epb+qLgUCekwbhVTMB+0+pOGbQvOxz4Fb7/+ZUvCzAdK12S/7 /h431yWcaNrc4DXL4njaFjIbCN6FYiNrgKnIqdS+ZCEVLjaMnR47CZPeZIYx8/Oa+V0u YHd3hWPauLaSSD1X/fbOFJYalebwwi4pWUSukWXyY8wEdG9HVWg/b3miCVqxSTWeVcBM Tinw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=+R7whsquW3YrYwKDa0MOtUs4Xh33FQMrrNyEoKlmyBQ=; fh=Eb6QuOT9x5H3CoIbNGIVaqTAer2Vyfwf8II32ecFuRY=; b=AkqGn7QtybXLa44FExK6IKxJdmtWq1QI9MxPcSF0ZP0xQDA5Syu+gLx4FiyotdWM5t oDmm786TokuBte0sA7NKpKEzgjwlBdhocxKUv/d0imnqljcNPI5hHA5ju52ghwZ/qdKP noB+8InRTC+EeVXfbSMJjg+4uxTfIC/Q7pcfDlDJo68hSt1YL8nC4ouK1fVIoW5WNHhp yvXhPOxYnMtXFNlqk4KaTGJj8GHnSnco/JjfewhDW0txPoWDElwKrH1r4R76zjE5VFL+ Tz+M+UNCOdw+X3lKoyRehpScav3ffZCWYK/r+8CDxkrghgtdPN1g19ye5LCgIq4Zs2U/ qTww==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NXWCeRCx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-176634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176634-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733c36e455si3285696a12.557.2024.05.11.09.04.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 May 2024 09:04:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-176634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NXWCeRCx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-176634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176634-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AEA4F1F21A82 for ; Sat, 11 May 2024 16:04:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE36156B7F; Sat, 11 May 2024 16:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NXWCeRCx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A69638DD3; Sat, 11 May 2024 16:04:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715443455; cv=none; b=s7UPJvrGcKNZLv0sAHahhHs8LlTG+IbSZuDpauo7dGTSGoZ2Z5g2o/LfQKErzzbpxrVRAJaSBBB0W3Asv1WVStklDqsr36S751Sx0xU337H/iVJqWLeOf1VzruJXbWlpyYG0KWsz61kGjstHGA6tqGQXoG2F+MdHgd0DAnAcUNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715443455; c=relaxed/simple; bh=JQRE0XHFO9GOKibnqirneeKjUdSE9KSkg1Ih2ug6M40=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UB6dg+O2I4g0P0zDGPYb63r7Y8Xw1dDhqmzX2p0DfcMO5W4z15I2NkJVW5Nb2aypiSQzc30NZ21vAn152ERlI7gb86sOErrN6VL6hO13R67L83+8nWzxDuk9lQCZExv4Gb6eAR+9wzS6TvCG0aGrZrzHOeAUywHwB1rCRBOQZSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NXWCeRCx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B49CFC2BBFC; Sat, 11 May 2024 16:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715443454; bh=JQRE0XHFO9GOKibnqirneeKjUdSE9KSkg1Ih2ug6M40=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NXWCeRCxyWIn5lw0x2auuwwkaEMuiV2KmekZYv2TpkTyzF70Y9b+Xdl+efgn0jeMO xttPofnDX7t2qxCqvibqZ3AWbNKn7ZqdTXXpojYPtoXSZ1hStYG31pBNDPOqcpirI1 lm2+zwJNZUMYWQBGbMuKefOx4GcsKwuzKVVkR4zbEFD7S8iIlg8DuvqmoreonXGpny kmXo4N2VbCkqCkP95MIjpeBferik2irCU6536SsTHrkngR20fCiDwA+qLSQ1/2OPVV Dg06I2eIF61T/SXFwwdvpvgUdGZGVwbJkC9ZyHBU0l0GoxDPirFS0wPtYNjigDE8gr jGEajj6Pyn9YA== Date: Sat, 11 May 2024 17:04:02 +0100 From: Jonathan Cameron To: Angelo Dureghello Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: iio: dac: add ad35xxr single output variants Message-ID: <20240511170402.324d8e1f@jic23-huawei> In-Reply-To: <20240510141836.1624009-1-adureghello@baylibre.org> References: <20240510141836.1624009-1-adureghello@baylibre.org> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 May 2024 16:18:34 +0200 Angelo Dureghello wrote: > From: Angelo Dureghello > > Add support for ad3541r and ad3551r single output variants. I'd expect to see constraints on reg for the channel nodes. Am I missing some reason those don't make sense? > > Signed-off-by: Angelo Dureghello > --- > .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > index 8265d709094d..17442cdfbe27 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > @@ -19,7 +19,9 @@ description: | > properties: > compatible: > enum: > + - adi,ad3541r > - adi,ad3542r > + - adi,ad3551r > - adi,ad3552r > > reg: > @@ -128,7 +130,9 @@ allOf: > properties: > compatible: > contains: > - const: adi,ad3542r > + enum: > + - adi,ad3541r > + - adi,ad3542r > then: > patternProperties: > "^channel@([0-1])$": > @@ -158,7 +162,9 @@ allOf: > properties: > compatible: > contains: > - const: adi,ad3552r > + enum: > + - adi,ad3551r > + - adi,ad3552r > then: > patternProperties: > "^channel@([0-1])$":