Received-SPF: pass (google.com: domain of linux-kernel+bounces-176784-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9b652a48-4107-4b68-9aea-6cfdf1e0e4fa@amd.com>
Date: Sat, 11 May 2024 20:43:39 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 2/2] platform/x86: dell-laptop: Implement
 platform_profile
To: Lyndon Sanche <lsanche@lyndeno.ca>
Cc: pali@kernel.org, W_Armin@gmx.de, srinivas.pandruvada@linux.intel.com,
 ilpo.jarvinen@linux.intel.com, lkp@intel.com, hdegoede@redhat.com,
 Yijun.Shen@dell.com, Matthew Garrett <mjg59@srcf.ucam.org>,
 Heiner Kallweit <hkallweit1@gmail.com>, Randy Dunlap
 <rdunlap@infradead.org>, Jonathan Corbet <corbet@lwn.net>,
 Vegard Nossum <vegard.nossum@oracle.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Dell.Client.Kernel@dell.com
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240511023726.7408-4-lsanche@lyndeno.ca>
 <9ba4a500-9d88-4630-bd94-99f07dd51abe@amd.com>
 <B3AA4333-03DC-47D6-9519-7FA9496220E5@lyndeno.ca>
 <48JCDS.E4RT1F9DTKFU1@lyndeno.ca>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <48JCDS.E4RT1F9DTKFU1@lyndeno.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bmE2dXJUSGw1S0szeXV4OUd5OEhGRlRKTWFjVlJlWlNBd0pCeE54U2xsRFlp?=
 =?utf-8?B?c1QzWGhudDN4ZHlHWVl2NlIxV25xTjdycXk2OG0xL0lPZWFjNnh4L1kxRys1?=
 =?utf-8?B?Vi9nTExhQzVjOVJGY3pGdG1PSFhIbERKN3M3Yjk4c0h6N2dTck9MYkkrbGpB?=
 =?utf-8?B?YU0yVEpTeFhYcmpOVDVKTWtMKzQ2N3AwUmFPYjI0QXFFaWhRWGt3THR4QTBN?=
 =?utf-8?B?N0xGdFM4bGkwWlBpc1hTRXBCTXhZUzZJTFB0TVU1TExXT21XSW0ydkNadVdn?=
 =?utf-8?B?R2hYS01tRFNscEo2ZUthOFZ1YXYzYkNsTnR6Um5yemVUL05DeTRYYTZJc1Vk?=
 =?utf-8?B?Um91dWgrUDBoZjdVdUlhcks4WWc1dlI1d0tYTXFkeWZTWHNlYmdiamgvYUN3?=
 =?utf-8?B?UXA1YXVzRGhuOUpEZUM5WC9SeUZYaXBCRnF1Zlcxd2d5ei9jZTZ1Z0pOTGpY?=
 =?utf-8?B?WEVOaTQyL3l2Z1FOUlFYak5FOHpvcTZxYVFLUTJiTWE5OUFZNmZOVUhQbUpz?=
 =?utf-8?B?VTZpVVhSL2cvd2tpT2lJS3RmbGRyVjJKdDJta0dwSGY0NnBrOWNzT25YREpL?=
 =?utf-8?B?bENLQzhqRG4zdGdZek52VDc4VmJXbFJJVkdMQXJ0Q2c3b3JCN2tVQTRQU2gz?=
 =?utf-8?B?WVJoSzdzdklNMmtOek5ma0FwcmErYUpKU0V1UHJXSkdRYXdlb1prSFJJWWNp?=
 =?utf-8?B?MlJIcHZuTWZaZXFRSkZKUHhYQjltRFA0Y2lQNUJnUTkvT2diVjVQckx5bFhO?=
 =?utf-8?B?WjB2Tzdva05Sa3ZtVnEwL0FJdjFicWZYWnYyOXJ2eFB3WVFLN3UvVVhmYzQ5?=
 =?utf-8?B?bFRVaTlYd04zaWovQ1QvNE9CQ1k5NGZRRlRLQnNCU2FCNDY3ZmdKNjhadVp3?=
 =?utf-8?B?L2VjM0Z4aDJxYk9QbXNUdmw1THd0dnFUQWxudW9lMlZoak93NFBib2o2bW9E?=
 =?utf-8?B?SSt2b21TZzBlcWJmaDJIRHM3RnUySC9YVVM2SUYzVzlVZVVGdjNrT2xGOEJ4?=
 =?utf-8?B?RnNNNTROWWgxMzFtNEhwUkd1VW5rOUUzaXU5NmIyYStTTk94QlF1djRyaUtv?=
 =?utf-8?B?SCtnSWJXOXBIYytFV0VvQkZOcTV1VEhqMXBiZzB6cXRKdGNFeGozYnZlTmZr?=
 =?utf-8?B?VjYydkk5R3RGd2FFL2FUelRRVTd1VG4yRGZMK3BRYmhkQmNpQXhpbzNLV2ZW?=
 =?utf-8?B?dHR6ZE1xNVQvNGNsMStTQmx2cEJQSFZ2Q2JvcVVMLzFic0xoYXcvbFVORlZO?=
 =?utf-8?B?eW1oOVJETStFcnRXY1dobkJwTzREdjRPNzF3V0ZXREJSa2wvTjRRTDFLSUND?=
 =?utf-8?B?bExmSXROclErbXY1dUx4ZTJhak8vL3l3eGVLa3VyeXozNXdwL3BjSVBoYzhX?=
 =?utf-8?B?ZkszNnhWMnpkMDhaUHhZa2QvV3VTQ2hvamFtOFpqNHYzUG03WFFnZHFkbDdj?=
 =?utf-8?B?WlA3Z3RMNmdLUFhtQUppcEZLYllFSDB6UHcwamp6KzUxck5yTTRZTXBqZVVr?=
 =?utf-8?B?N1FDd25vQlNoNTByNURyRnd2eEJrS20ydHo0ZUNjWFBjcS9WYVo4NVJtTy90?=
 =?utf-8?B?ekhoaktsSUhtWU02eWpaaGlDWUYrc2xqbGtnb0NsWVJTL0FIekZtMXJFczI1?=
 =?utf-8?B?OEx5U0FHeER4YzNxOGlIZXlyN3JiemlRS3I1STJqK3V6RkFGd2laRldvaXFR?=
 =?utf-8?B?bXhLb1NJNUdxYWdKYklialA0WS9xVWowcDZKQjlTWHpkelhxOXpJYVozYS95?=
 =?utf-8?B?TUpldzdtRldISHlTVmtHbzlqdGxkb1hPdFNzRFVaVlhZU1BJajEybExoLytV?=
 =?utf-8?B?c0pWeE9EM1pkZXo2bjM5NENhM1VLenJKRXp6bDlLRWVTb0cvOWZZbzgyNEpH?=
 =?utf-8?B?K0gyTENjcWV6OGwrUE9Qa2JvSlFoa2YyRXNTK2REZnV1QmwvcWI3c25jV2E4?=
 =?utf-8?B?aFVOWTZHcG5kc2hSeUFjcnREa1Z5L28xVHp4NkhmbW9TMnk4SE93QXoxUWlO?=
 =?utf-8?B?dW1LT2ZIZjMwQ1h5QzdiNEFmWDFYSjJxUEtSUlRVWEw0N1gzVE9xRGdsb3ho?=
 =?utf-8?B?dUlBWmx0UVRqT1NSOVRYRmUzd3p1T25nU2pjL212NHE3aEJMYkhRV2o3WHlj?=
 =?utf-8?Q?wlash2I2Q/ecEWwYHIuFg+Xui?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f638fb0b-0281-455f-a54d-08dc7224f4dc
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 01:43:43.3429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +UaFffBU1jjNLwHh8yzRLrkptCEOPidR7OFo7+6gkC4BcsMrgC/vNX8ksMNjQAb8XI3Hw1/2oROvVmIblHX1OA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6623


On 5/11/2024 7:12 PM, Lyndon Sanche wrote:
> 
> 
> On Sat, May 11 2024 at 09:59:17 AM -06:00:00, Lyndon Sanche 
> <lsanche@lyndeno.ca> wrote:
>> On May 11, 2024 9:16:56 a.m. MDT, "Limonciello, Mario" 
>> <mario.limonciello@amd.com <mailto:mario.limonciello@amd.com>> wrote:
>>
>>     On 5/10/2024 9:36 PM, Lyndon Sanche wrote:
>>
>>         index 6ae09d7f76fb..387fa5618f7a 100644 ---
>>         a/drivers/platform/x86/dell/dell-smbios-base.c +++
>>         b/drivers/platform/x86/dell/dell-smbios-base.c @@ -71,6 +71,7
>>         @@ static struct smbios_call call_blacklist[] = { /* handled
>>         by kernel: dell-laptop */ {0x0000, CLASS_INFO, SELECT_RFKILL},
>>         {0x0000, CLASS_KBD_BACKLIGHT, SELECT_KBD_BACKLIGHT}, +
>>         {0x0000, CLASS_INFO, SELECT_THERMAL_MANAGEMENT}, }; 
>>
>>     So when Alex checked on v5 that this doesn't load on workstations,
>>     it has made me realize that doing this will block the interface
>>     totally even on workstations. So I think there are a few ways to
>>     go to handle this: 1) Rename dell-laptop to dell-client or dell-pc
>>     and let dell-laptop load on more form factors. This would require
>>     some internal handling in the module for which features make sense
>>     for different form factors. 2) Add a new module just for the
>>     thermal handling and put all this code into it instead. I don't
>>     have a strong opinion, but I do think one of them should be done
>>     to ensure there aren't problems on workstations losing access to
>>     thermal control. 
>>
>> A dell-client/laptop separation makes more sense IMO. I don't think 
>> keyboard control would belong in a the dell-client module either. 
>> Separating just thermal control would be easier, but not as clean I 
>> think. Thanks, Lyndon
> 
> Thinking about it more, we can leave dell-laptop as-is and create a 
> common dell-pc module that does not check for specific form-factors, 
> assuming that is possible. Thermal management can be the first function 
> to go in there.
> 
> We will still block the calls from userspace regardless of which modules 
> are loaded. If dell-pc fails because thermal management is not 
> supported, we aren't losing anything by blocking that call anyway.
> 
> Thoughts?

Sounds good by me.  So basically laptops will load both dell-pc and 
dell-laptop and workstations would load dell-pc.