Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp1333096lqo; Sat, 11 May 2024 19:52:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2BYCpTcN8zf7flb6F4eUhMjXPKevEg0Ij7L2apZYZ+a4ryUmhsKr6xEc+nGuF53joOLfGRZUOtj1hw1En6YEHgpEuU1IyJ0BmuzN6Sw== X-Google-Smtp-Source: AGHT+IFt/Lm3NdqYDoILhHGezQGtQ3LqjD/+FNxMBCDfGcB1d0r8MyjPc4jfcwd08EXIUNQmveUD X-Received: by 2002:a05:620a:284a:b0:792:bf13:9a02 with SMTP id af79cd13be357-792c7601018mr779650285a.66.1715482351926; Sat, 11 May 2024 19:52:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715482351; cv=pass; d=google.com; s=arc-20160816; b=IB79iAoXAIVu8Lt7icfyTJBbLtthfMx5xiRFoZh05DRvhFp8NsDcF8spKmi3cKdtBV RkmLeOZaVDgLpuoxuDIhpxzlq6hieLdufFkFBWF4qezXw5p8flHUHsf85Q+imevl+GIN V6AVdCrsMm0XygfFVuj9YvDnhTYg0LDtY/40vfVTINbS+es5Mjg/ovxpKeDbJnKnnaF0 GKiVyOt48IeNDHmFwrBgVnnvyZktqtjl9R6k0OIultOUklePTVQd1T84YWzJVAGDei96 GW9iP7McMjl9/wcVkHbNVvwJoLS/edZE6Xj3WhWYRtFNJDAGrz5xU4qi6TGVpiBqcfQR vfSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=6H5QqjfnbzXi38Mhan1b/OhNz0VkiYrd/rdH/mh5vbs=; fh=ABd84OJQRUrD+A12QMz3wVb/zHQYobBaZgm1K44zlcc=; b=q6EAcXtHRW3AHD1wOMxvIjWjsKEEjXtwa4/HO5HieJJ/U/Go7RZyBLGwVdQRmN7IWy aX/4+2VflrrwNRj7UUpukHKIyeu2WxwINGoubdKduO6gG3p0NhCX+ucWjgLWN7OyzbOF gNfR0yhm69mDbKIOrp1oBq04gLz9XoleXMALPogJ8zYmHKKOulgqc8+MsNRJMEk1qx+J F1lvg1jI/VLnPlwQdHPOqrtKJnikAX+vkwZuoSNc453d17jKCUeEmz+8LyiBEEkaMJIO 994vSeOxZxiwZjE2Be5axVFkSWvhBkT80s7sIk5ulWvmvLreHmpCqOGKOKDIMcgc8nAN lBVw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="wGSj/X4l"; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-176787-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176787-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-792bf365eebsi745807785a.651.2024.05.11.19.52.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 May 2024 19:52:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-176787-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="wGSj/X4l"; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-176787-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176787-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 978D81C20A6E for ; Sun, 12 May 2024 02:52:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BB000F4E2; Sun, 12 May 2024 02:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="wGSj/X4l" Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79698C8E9 for ; Sun, 12 May 2024 02:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.249 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715482335; cv=none; b=FMuZMpIREDcURz19QHpnIJB/po8JtyCJyVyj4+VsDaIyR/fxKQNDcgHQtkxPMwkhybhbCiDUqM7JgrKosROy3FxsqJhxAhR3a5fcImjW+bqiW3UgKkonn63CR+esc2oqMubkTsf1vSWNMz5a0dFIHV7Mw0brXGt7Fs8sZ3Wsq/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715482335; c=relaxed/simple; bh=ToAwIbvzHG0YYLRGugwY07ZmC28i54igLPITw5CgNEo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VYEwcaU5HtPnKm8yfVW6DIDeesQZ6LslvKTNzHuyif/oBe9V4L3Kqc73npXKsQWKUV6btCRLCv0AWjtwgnQmGwGtzVmFqCsfIBWHJ/zHdg6ZoNezKHz5/XDH4RpVo8jGprpMzf1T/UkliH017XCkguW9L9udwNGX++69Npp+o+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=wGSj/X4l; arc=none smtp.client-ip=198.47.23.249 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 44C2p9n9130107; Sat, 11 May 2024 21:51:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1715482269; bh=6H5QqjfnbzXi38Mhan1b/OhNz0VkiYrd/rdH/mh5vbs=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=wGSj/X4lJc82ItidZ2aZM0UTuoU4USS2IFBu0WJkiA92ri2otkyAcJw4LCYUUBPSA yCsX/zTrmlMiMHSwKbnkaS3b+6NvhPIrC9RxARqXx3dI5M3RtplTTqCRILd3P+RgnM dUGGGpQs7noFtwjnAlY8JTvMXnZ3rp4f2/KKesmo= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 44C2p9MP062482 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 11 May 2024 21:51:09 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sat, 11 May 2024 21:51:08 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sat, 11 May 2024 21:51:08 -0500 Received: from LT5CG31242FY.dhcp.ti.com ([10.250.160.109]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 44C2ojfR039978; Sat, 11 May 2024 21:51:02 -0500 From: Shenghao Ding To: CC: , , , , <13916275206@139.com>, , , , , , , , , , , , Shenghao Ding Subject: [PATCH v5 3/3] ASoC: tas2781: Fix wrong loading calibrated data sequence Date: Sun, 12 May 2024 10:50:39 +0800 Message-ID: <20240512025040.1276-3-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20240512025040.1276-1-shenghao-ding@ti.com> References: <20240512025040.1276-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Use the API with correct sequence instead of the wrong one. Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver") Signed-off-by: Shenghao Ding --- v5: - correct changelog has no much relationship with the patch v4: - Use the the culprit of the bug itself as the fixes tag v3: - No changes. v2: - In the Subject, fixed --> Fix - dsp --> DSP - Add Fixes tag - Changed the copyright year to 2024 in the related files v1: - Download calibrated data after loading the new DSP config params - Call tasdevice_prmg_load instead of tasdevice_prmg_calibdata_load, it is unnecessary to load calibrated data after loading DSP program. Load it after loading DSP config params each time. --- sound/soc/codecs/tas2781-i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index b5abff230e43..9350972dfefe 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -2,7 +2,7 @@ // // ALSA SoC Texas Instruments TAS2563/TAS2781 Audio Smart Amplifier // -// Copyright (C) 2022 - 2023 Texas Instruments Incorporated +// Copyright (C) 2022 - 2024 Texas Instruments Incorporated // https://www.ti.com // // The TAS2563/TAS2781 driver implements a flexible and configurable @@ -414,7 +414,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw, __func__, tas_priv->cal_binaryname[i]); } - tasdevice_prmg_calibdata_load(tas_priv, 0); + tasdevice_prmg_load(tas_priv, 0); tas_priv->cur_prog = 0; out: if (tas_priv->fw_state == TASDEVICE_DSP_FW_FAIL) { -- 2.34.1