Received-SPF: pass (google.com: domain of linux-kernel+bounces-176865-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 12 May 2024 13:04:50 +0100
From: Conor Dooley <conor@kernel.org>
To: Felix Kaechele <felix@kaechele.ca>
Cc: Job Noorman <job@noorman.info>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-input@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: input: touchscreen: himax,hx83112b:
 add HX83100A
Message-ID: <20240512-trailing-wad-0b9553d03d30@spud>
References: <20240511121245.109644-1-felix@kaechele.ca>
 <20240511121245.109644-2-felix@kaechele.ca>
 <20240511-passage-obstruct-70e4c3b37dbd@spud>
 <dab1dddd-57ae-445e-bce7-879e8d73d809@kaechele.ca>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="1Zr+TJl8NhKVw3HF"
Content-Disposition: inline
In-Reply-To: <dab1dddd-57ae-445e-bce7-879e8d73d809@kaechele.ca>


--1Zr+TJl8NhKVw3HF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 11, 2024 at 10:10:08AM -0400, Felix Kaechele wrote:
> On 2024-05-11 08:38, Conor Dooley wrote:
> > On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
> > > Add a compatible string for the Himax HX83100A touch controller.
> > >=20
> > > Signed-off-by: Felix Kaechele <felix@kaechele.ca>
> >=20
> > Commit message should mention what makes this device incompatible with
> > the existing device.
>=20
> Thanks!
>=20
> I have added this note in the commit message which will be part of a v3,
> coming after I hopefully receive a few more comments on the other parts of
> this change:
>=20
> The HX83100A presents touch events on its internal bus rather than offeri=
ng
> a dedicated event register like the other chips in this family do.

Ye, that sounds good. W/ that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.


--1Zr+TJl8NhKVw3HF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZkCwYgAKCRB4tDGHoIJi
0ukQAP4tdPpHCiS+aYv9tr4OD64LFywGL9bFq4elfXmGBza0bgD/fr8b5baNVflq
Fj62Y4D36caKcEeKcT6HFxA4nTFrRQ8=
=WlBl
-----END PGP SIGNATURE-----

--1Zr+TJl8NhKVw3HF--