Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp1492587lqo; Sun, 12 May 2024 05:13:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXu6hP6y5lpNDQsBjmHkHzKLDVfLuHr5bE9YuXVOIjijykV5w1SazmqIztdadScXxkKS+y2RqKnenJQ0HlPsm51om7wmGl2zgErJlgA3A== X-Google-Smtp-Source: AGHT+IGHW253Rl0RZROYaErtcN68KCjQ1y+Dz7MGj4Ou87b4QM8jKlcnlAsdA3f7sBStKSbgKfej X-Received: by 2002:a05:6830:1659:b0:6ef:df90:a248 with SMTP id 46e09a7af769-6f0e90f5a35mr9116965a34.7.1715516005295; Sun, 12 May 2024 05:13:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715516005; cv=pass; d=google.com; s=arc-20160816; b=tefG0lcOKw54EE+TEoipXHPZmg/3gaL1ONgIG0lNqxGn5I6GDq3BqIUMyhIn+EQEqx 6YfHXhdQbZtxJFzlBsn01nqPN3FmIi/siarX7h2hUuySGst78Xae2cXbjPyW1Lcx+NEx M3QoFGtoXnZxZdSXHmIaWbVZm+KR8x3c9EodA5dz7Eu4IZxxF8qvFR2D8L2NDwgwKAGL gOz9uUY6xDXIRe/ZlR2rbU9bIdROcZj48E3UKOh45HMZOU9Z+WONvdR4iO/MfhwK5AAb VXiFrli25O1J02Aq75e5865mghEGeVXq81/83HjF3bAqy41YXyTU9RzrB4q5kASQ2XlF 00Gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=S9hHFlwFS9g2ZhvaOsM2/p7z3uZHG+906TqvT3kr8AE=; fh=ULxNTxaaQIEX8Y9ih2rqqI9Lxn2bbvdaV8tkS1+QGD8=; b=A9lGvE/xNVCcGZKAdxzcKqfTxKtS8KrPEuuzQ5ig8tr/dXMoL3mNOc8WBIHBP2EDzX EufNk+1PdhZEpcY6Oxk4FfChRBIAx7cdQ6rv06n3Bus1Txjz0qQoLnn8OmYn8LU9Akeo OpyBXMFmbY3akAJaKfSxiTpfLx6J4RD4k02d6bpb80cNfMog7lYIte2hIcFTsSsnUhwD aKqYnzk4XsQZkHOyDw2WBhDZWzyLRknZmMukQukEA5dUQSl8rTfSUTM4jL/wKKKvbeLZ qgsZSrEtlcW8Myu58g7e5QS7clPQ/efPrptb/EfxYdkelnfdSv7mDmitEwP9RpBxlt42 10dA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fUEj2HC5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-176872-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176872-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-792dcd1d43asi60886585a.784.2024.05.12.05.13.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 May 2024 05:13:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-176872-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fUEj2HC5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-176872-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-176872-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 00C041C20AED for ; Sun, 12 May 2024 12:13:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA70020DC3; Sun, 12 May 2024 12:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fUEj2HC5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE2E0210FB; Sun, 12 May 2024 12:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715515997; cv=none; b=dSM+E21SI1GIh6Y3ifIT0oc58cV299eSLW2JfWBOiv7xnJ8KPxMXWghwps2chxzFcxpWfGOCJTFy1dX3ujiEjxt9u4b3yXlsZwbvM5Ki5opx+CUExrIFitYBlaLRTtKHH1HWk213qz/dHcQMSAT9G/LlaMAbcbhbVKGwohA0mZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715515997; c=relaxed/simple; bh=9ecrq6ewkCPgWwI2dBv/kDtPnydKl5OIf4t6YTMMTPM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YVff1PS2uNZamgz+EvhwOzt3hiY+SuIPYsvN8VXWKseleD+hSBuo0437+DTEd5+IySO1N6ClKNH51R8wovNw7J7iJffbxt6v+gw6uATaKQ8oJdofU66O5Y5AoKtdJ/vprTxEuoI8NWRHj7R9NZczLXk0QDdEC2MO+xqHl7esRbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fUEj2HC5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C22CC116B1; Sun, 12 May 2024 12:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715515997; bh=9ecrq6ewkCPgWwI2dBv/kDtPnydKl5OIf4t6YTMMTPM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fUEj2HC5irRdGCzhWGUvrZg3OEGI1RPbWs71u6DaREfu4RQV5BA8Mya5rwOg+spVy eGOccclJR+/DKa7PMLyh4qo8wqNI9M9JCegaBowmpsNjolGElBd5k3xvyXQ4ps7jHl 4s8SRh88R8xU9ruKsEjrOd3vcBWdcJfLkByoTFehaXp2KGZMu+N60ARUdKrv9tNZ0L emTgh5t7fA+qrIrqY3zYmzAqSAqWKzQA5zO4FQmF0OoDdH8Pfn8gVN/E0gOQeOl/34 qh+sE7eSeQmDfbjoDvUv/MYQg/EwlDGGxfo8aIACAi0WFp5xUHu59MbVxbLOib5OdM eAeqjiPcroipw== Date: Sun, 12 May 2024 13:13:04 +0100 From: Jonathan Cameron To: Vasileios Amoiridis Cc: lars@metafoo.de, andriy.shevchenko@linux.intel.com, ang.iglesiasg@gmail.com, mazziesaccount@gmail.com, ak@it-klinger.de, petre.rodan@subdimension.ro, phil@raspberrypi.com, 579lpy@gmail.com, linus.walleij@linaro.org, semen.protsenko@linaro.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 4/9] iio: pressure: bmp280: Use unsigned data types for raw sensor data Message-ID: <20240512131304.687de3b1@jic23-huawei> In-Reply-To: <20240508165207.145554-5-vassilisamir@gmail.com> References: <20240508165207.145554-1-vassilisamir@gmail.com> <20240508165207.145554-5-vassilisamir@gmail.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 8 May 2024 18:52:02 +0200 Vasileios Amoiridis wrote: > The raw sensor data that have not been compensated yet cannot be > signed values, so use unsigned ones. Also, compensated pressure > values cannot be negative so use unsigned also there. > > Also, drop redundant cast of data->t_fine variable from s32 to s32. > > Signed-off-by: Vasileios Amoiridis Looks good to me. Applied.