Received-SPF: pass (google.com: domain of linux-kernel+bounces-176881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
HMM_SOURCE_IP:192.168.137.232:14399.1573931882
HMM_ATTACHE_NUM:0000
HMM_SOURCE_TYPE:SMTP
Received: from clientip-36.111.64.84 (unknown [192.168.137.232])
	by chinatelecom.cn (HERMES) with SMTP id F35339BCE7;
	Sun, 12 May 2024 20:36:06 +0800 (CST)
X-189-SAVE-TO-SEND: chentt10@chinatelecom.cn
Received: from  ([36.111.64.84])
	by gateway-ssl-dep-7f596d7dc-5nwtg with ESMTP id d7e17b3c31254085a3111d9a6febed44 for akpm@linux-foundation.org;
	Sun, 12 May 2024 20:36:12 CST
X-Transaction-ID: d7e17b3c31254085a3111d9a6febed44
X-Real-From: chentt10@chinatelecom.cn
X-Receive-IP: 36.111.64.84
X-MEDUSA-Status: 0
Sender: chentt10@chinatelecom.cn
From: Chen Taotao <chentt10@chinatelecom.cn>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] mm/rmap: optimize folio_move_anon_rmap()
Date: Sun, 12 May 2024 20:35:55 +0800
Message-Id: <20240512123555.8358-1-chentt10@chinatelecom.cn>
X-Mailer: git-send-email 2.27.0
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When a folio belongs exclusively to one process after a COW event,
folio_move_anon_rmap() always moves the folio into the anon_vma
belongs only to this process.

However, if the folio already belongs to the anon_vma of the this
process, we don't need to move it again. In this case, we first
check if the folio already belongs to the anna_vma of the this
process, and only move it if it does not.

The above changes may improve the performance of vm faults in some
scenarios, because the performance loss caused by WRITE_ONCE() is
much more than the performance loss caused by add a judgment.

Signed-off-by: Chen Taotao <chentt10@chinatelecom.cn>
---
 mm/rmap.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/mm/rmap.c b/mm/rmap.c
index 3746a5531018..5720cb78162d 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1216,12 +1216,15 @@ void folio_move_anon_rmap(struct folio *folio, struct vm_area_struct *vma)
 	VM_BUG_ON_VMA(!anon_vma, vma);
 
 	anon_vma += PAGE_MAPPING_ANON;
+
 	/*
-	 * Ensure that anon_vma and the PAGE_MAPPING_ANON bit are written
-	 * simultaneously, so a concurrent reader (eg folio_referenced()'s
-	 * folio_test_anon()) will not see one without the other.
+	 * If anon_vma != folio->mapping ensure that anon_vma and the
+	 * PAGE_MAPPING_ANON bit are writtensimultaneously, so a concurrent
+	 * reader (eg folio_referenced()'s folio_test_anon()) will not see
+	 * one without the other.
 	 */
-	WRITE_ONCE(folio->mapping, anon_vma);
+	if (anon_vma != folio->mapping)
+		WRITE_ONCE(folio->mapping, anon_vma);
 }
 
 /**
-- 
2.27.0