Received-SPF: pass (google.com: domain of linux-kernel+bounces-176900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sun, 12 May 2024 10:21:49 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
	suravee.suthikulpanit@amd.com, joro@8bytes.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
	yi.l.liu@intel.com, eric.auger@redhat.com, vasant.hegde@amd.com,
	jon.grimm@amd.com, santosh.shukla@amd.com, Dhaval.Giani@amd.com,
	shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH RFCv1 01/14] iommufd: Move iommufd_object to public
 iommufd header
Message-ID: <ZkDCbWv1DFH25mnh@nvidia.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <09e84c7c9099aba07b24b113c70d57d4574aee08.1712978212.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <09e84c7c9099aba07b24b113c70d57d4574aee08.1712978212.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?iRMvUmu9vhvEKvA8YoViY8EYS9mUQEVGMUKLuc/g3PxWsIXDYcv9cP7/75gH?=
 =?us-ascii?Q?QCkC2Ltt5GgtBuNiWqZbJwdsAZ3PY7zl1HYI8ulRCDLY63yXIsYfZ8clCYB7?=
 =?us-ascii?Q?xyP5RmS5Bn/0XyA5/bsBtRogr2fQlYxla4xTBlBapOcOrUNMtri4VbmzxIt4?=
 =?us-ascii?Q?A0EQr7fzG0P/19yXUb+Sn3EFralAC4xlp2mjK7JdLMXqJQwlxvtPwIZ9VCzO?=
 =?us-ascii?Q?skEp/e09q2olVddwrD9dx0phGYl7/Yt79VC8ayE44P2/mU91YjfjzxHPvcMu?=
 =?us-ascii?Q?9Xjx2PSM0rV1/Eh7rCnphZ7x9ZcYKV4guaXNFe9UHuvXg5t0XlbYRPT7IzqS?=
 =?us-ascii?Q?iNiNtoPP/6uCtJeLLfajHyIuOrl9oBnxhQq0bJXQfUaOJ8Ij5vPY16Twl3M+?=
 =?us-ascii?Q?fvkCtQXeA8oSb7GQSOr2c1vhK4KdhZ/XIUtSHEBp0puIhGGh5Guv0nm0R050?=
 =?us-ascii?Q?JzVli1PgpFmlZHzytxWKNaUwQIMhgpZBZ6qOiVjtRW2K74qcbjtzQoYT0n1r?=
 =?us-ascii?Q?Pz3LDoREme3ITnJ72QPDoKxG02/pDElv0+2x46JCFo4MdJJGgokMASH6UhnP?=
 =?us-ascii?Q?8NWssZ9PENuI/95UKY3fOOlbh30FCEhGQdTN/OVKQplpmF3PukXRMQn1nfFg?=
 =?us-ascii?Q?mxe3EUckN+BYXk5D6qAd1ObAe+WBJ+ZVvye0GEAZvm7bKvyXPKgwg5kCDJ33?=
 =?us-ascii?Q?968AWyVE12JpHOKx1t0J0HlfcUgR1LFYoNoS47JCPHx2mL0tnzcUxkI7rTj7?=
 =?us-ascii?Q?sinAqe0fRe7084E22IGXMXDASK3wQnVLVSg66hGN1HE51j2ufQp+WgfIM2H8?=
 =?us-ascii?Q?1GdhbgR8bNCwy/mRI40+oiDPFDE2D6UfW3ExJ4pUHG8DqkxcSxHyAXmhdgDR?=
 =?us-ascii?Q?QUZ4k6wTCf8xfU5xMxJxLcYudW1opMCjRvg5uQpbaiL8/ScfnyVekiYcTD5v?=
 =?us-ascii?Q?0yPgaJxruWqUUmUuKEpaulGbcYzN6ybABzZp6uXjKnC1UwzWYZ9oYPnXRSs5?=
 =?us-ascii?Q?CnMkwekD0qmTx/PRv6lADDg9E7oy4DQp52lh/sqMJDLdHGl7S1ujOpk5bu1c?=
 =?us-ascii?Q?PdYgsobLMiHdO/daDYMF4Q6+Fi3bt/ejbKizoaGFARon/XUY7acjjGnbiVpr?=
 =?us-ascii?Q?H2f6+fTGxxPR/YnW0INNO0USPPpD452sQgdc+fisKlhkRG/tXPEvlYiVFhwi?=
 =?us-ascii?Q?BwaBPY3VcH/CIa3kAYmG2m/qgrbenTs0cBTXH80OXzWp9yamQAj8lULCzaJF?=
 =?us-ascii?Q?5zXZXbofF4ZdEJxMnflk0kzJscm4wFLuMd3l13cF50DRsVS6jyfvMKl3mg+O?=
 =?us-ascii?Q?rqWWj1ADT2Ocu0gZ6Ru+f/xaavuBcHimjm0mUdusE1Lim2i4surnr40l6t1U?=
 =?us-ascii?Q?uuaJbCoJqbnpnn+3KedsVd3w2V2GofHymlIp86xswy5Ixu8PpPREyk/+0flN?=
 =?us-ascii?Q?kiDZuMAaqkRWoG1MXUXI/h5mE8089hqzdjPBa0PlhsDjfnAE2gDllLPySJC4?=
 =?us-ascii?Q?i3pgL45Ij+s7EEPCmuaLk1oF+rMaLbsWMizy30C6iLMaujm4p5i2auO58KhO?=
 =?us-ascii?Q?gT/tklnzxEV0P6j0lxPzo1iGPipRdRf0U9RIvUiC?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3089295e-4299-44fd-bf4b-08dc728fbc26
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 14:28:04.3359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fJM4WRLuLv1YQVA/9/YnxjxG7CsoneIwYtIcirMmtjXkY+f/3VFVaRyvUxZinajH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8570

On Fri, Apr 12, 2024 at 08:46:58PM -0700, Nicolin Chen wrote:
> diff --git a/include/linux/iommufd.h b/include/linux/iommufd.h
> index ffc3a949f837..a0cb08a4b653 100644
> --- a/include/linux/iommufd.h
> +++ b/include/linux/iommufd.h
> @@ -9,6 +9,7 @@
>  #include <linux/types.h>
>  #include <linux/errno.h>
>  #include <linux/err.h>
> +#include <linux/refcount.h>
>  
>  struct device;
>  struct iommufd_device;
> @@ -18,6 +19,28 @@ struct iommufd_access;
>  struct file;
>  struct iommu_group;
>  
> +enum iommufd_object_type {
> +	IOMMUFD_OBJ_NONE,
> +	IOMMUFD_OBJ_ANY = IOMMUFD_OBJ_NONE,
> +	IOMMUFD_OBJ_DEVICE,
> +	IOMMUFD_OBJ_HWPT_PAGING,
> +	IOMMUFD_OBJ_HWPT_NESTED,
> +	IOMMUFD_OBJ_IOAS,
> +	IOMMUFD_OBJ_ACCESS,
> +#ifdef CONFIG_IOMMUFD_TEST
> +	IOMMUFD_OBJ_SELFTEST,
> +#endif
> +	IOMMUFD_OBJ_MAX,
> +};

Can we just forward declare the enum? It would be nice to keep it in
the private header

Otherwise makes sense

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason