Received-SPF: pass (google.com: domain of linux-kernel+bounces-176904-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 12 May 2024 11:51:31 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
	suravee.suthikulpanit@amd.com, joro@8bytes.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
	yi.l.liu@intel.com, eric.auger@redhat.com, vasant.hegde@amd.com,
	jon.grimm@amd.com, santosh.shukla@amd.com, Dhaval.Giani@amd.com,
	shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH RFCv1 07/14] iommufd: Add viommu set/unset_dev_id ops
Message-ID: <ZkDXcyxxriFk63Ba@nvidia.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <6e57d7b5aa1705bdd547b1cd2aca93d3bf70dfa4.1712978212.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6e57d7b5aa1705bdd547b1cd2aca93d3bf70dfa4.1712978212.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RtonTzpwzDJ24qy1cJ7iuMT5QRcJhhlAfqrJuZaeD2N8mP28INlCnrgAu+GF?=
 =?us-ascii?Q?2TywhUwsNMTLppO7tflc8OFdHUOmJrvYSjnbfNxRUDsGpCHtoKroMn6qp7F4?=
 =?us-ascii?Q?6Ko73ROWPGkOD2BLLfOkGZpZwQiUdJeviyZ4SKuCMhSJ1R5gutAMhkhbuWaJ?=
 =?us-ascii?Q?HhL0wL9AtN3k10j5sbAuJCNnxBhq2e4RXUK6e025yP/Bqxi6LrjzkQ9wBngD?=
 =?us-ascii?Q?RZcs6heJU3wrQGUd+JByvlVggZiECwI/0CmhkaAcge8oT251WpjrollPcx3y?=
 =?us-ascii?Q?9wQS4elCdjGGjVwKnghLSzsI87xtbadv0EN+3t+7qmmlWoPT11ciYaZ85cNq?=
 =?us-ascii?Q?e7Jmfi39kKCn7xs9XaauDdga8sBJkHsVdcw+6MQKVV2CzPHOSxhJLO3SGXW+?=
 =?us-ascii?Q?DTOiRnznZYnX4uBA7FbXCHX9ZIz83cOnkgBFTLSfk/9anXvp9A/RasIQ8KtY?=
 =?us-ascii?Q?DZ6FckoVVCgtBvWobhRoHvUjXucQlPtC6bxmgZoqe2KLyrZrQTkX4riQEw1p?=
 =?us-ascii?Q?sbNRu4Uuy3xRZLZfAzKpr8p07JDO3lLabLUKLvSrBvRdy+cTNmqQm5EvNWds?=
 =?us-ascii?Q?HX9JdZwwikylilCkViaAtsrJvTTo6D5QXZt/XzzMuZEim971jcTfjyxZ7lWG?=
 =?us-ascii?Q?KNBEyQqH197yo/gP8VBKplob0x0yERSqCdr5Lv/tgY+K2j6JQgfq0NM76qg8?=
 =?us-ascii?Q?OGIYc8ahYagy95FEVP84oVbr8GxYV0h4R5farvanrIciHHAV8EThW+aqgu2U?=
 =?us-ascii?Q?BxOObAdWue/sDWbzs3Rc3zFa2YzF36HiVJZZXM47ZqL3YI/0QaJp21DT7mXU?=
 =?us-ascii?Q?RE47tp5GTVTlhkJ0YyhldcjLeXr74tep3xMEeFGoAY6BXhuIB5Ud9aiAD5iV?=
 =?us-ascii?Q?nN2mYgMtQZKSSlQmcwsT+rEot/Xm80589doRdJWVpQ3itOKi5jq0K3PKNpZx?=
 =?us-ascii?Q?zUNB1dTdj5nyODGu3wtlKaBgngI6+AHRC/E5ri16ydG3KlV2FXh5gLJc9vLu?=
 =?us-ascii?Q?oxANgC18q/0Uyi6mdnKbOvor/iGrjMttV8F6eJnswWI6pdcJoZRnHwNNSsBx?=
 =?us-ascii?Q?1IFrnJXljbaVfoNOJMQ+GaK1tF9d2kZdN7B7h+IR2a5Kf83/egGsaNpagSjx?=
 =?us-ascii?Q?q0ojBvUREZJcU6t6R41aIy//JyBh+NGVBqJ2nA+LF7iuTNcVXE9s48zSpOfG?=
 =?us-ascii?Q?Zz1vOhkK3rsuFDI7KwbXmMk1uMKd2eJ9TqwTj4WYaiNhF6hUtoN9fLTQdcjH?=
 =?us-ascii?Q?gHKgCNS4gr7ex2UY9aAVUfn9f5qAVLnll49JkKibbqY9k1nXx+e9OZgmroFb?=
 =?us-ascii?Q?aY9CwQv55vOvUAjyya4aU80hACgxa4ZOqqyNJcGR2/D21hOVocltCZypKlYH?=
 =?us-ascii?Q?9VyIXHnG1N8o9hhAqkbjxt2R1maZRtODoacrV3Dfw388zHkq17e9f8fyb3RL?=
 =?us-ascii?Q?ECV896a3pDUq2mrfRppSkmMLanJOpKibtm719Uwl3fny4Puy09X3NL05nMIo?=
 =?us-ascii?Q?wYtzmSn0WhjYyK3OjQKbmNGnMcq+0j84Ov1ptFNMauOHZiKZxZpWNed2Vz0g?=
 =?us-ascii?Q?udiFaI9py1sgrmaAfA8AVyFDCTwRAMHzq4rlgugh?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b4a1418-3920-4d9a-efba-08dc72930741
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 14:51:38.8778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5uPqpa3jKkr34pAp/sQOnz4IvSJnlsjJVGnmi8/zQicoOomP9XTasyOjQ/JRyfuf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7615

On Fri, Apr 12, 2024 at 08:47:04PM -0700, Nicolin Chen wrote:
> @@ -94,9 +94,13 @@ struct iommufd_viommu {
>   * struct iommufd_viommu_ops - viommu specific operations
>   * @free: Free all driver-specific parts of an iommufd_viommu. The memory
>   *        of the entire viommu will be free-ed by iommufd core
> + * @set/unset_dev_id: set/unset a user space virtual id for a device
>   */
>  struct iommufd_viommu_ops {
>  	void (*free)(struct iommufd_viommu *viommu);
> +	int (*set_dev_id)(struct iommufd_viommu *viommu,
> +			  struct device *dev, u64 dev_id);
> +	void (*unset_dev_id)(struct iommufd_viommu *viommu, struct
> device *dev);

Actually, looking at this more closely, why doesn't the core pass in
dev_id to unset_dev_id? Not doing so seems like it will crease a bunch
of unnecessary work for the driver.

Jason