Received-SPF: pass (google.com: domain of linux-kernel+bounces-176907-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 12 May 2024 12:02:21 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
	suravee.suthikulpanit@amd.com, joro@8bytes.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
	yi.l.liu@intel.com, eric.auger@redhat.com, vasant.hegde@amd.com,
	jon.grimm@amd.com, santosh.shukla@amd.com, Dhaval.Giani@amd.com,
	shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH RFCv1 12/14] iommufd: Add IOMMUFD_OBJ_VQUEUE and
 IOMMUFD_CMD_VQUEUE_ALLOC
Message-ID: <ZkDZ/YO0jqZOlRtA@nvidia.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <b0ee53af3f59602834e67ddf86c748ca304da175.1712978213.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b0ee53af3f59602834e67ddf86c748ca304da175.1712978213.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Imi0O1olVrMI26HWuQJEBrFVK2ulXwkgLTki8AvFjd10KWQu5c8pfmS04hcy?=
 =?us-ascii?Q?uHpOYXwjz3JNDbth9Ibe10wi8mkQ4CH4IYGce20Yp6IHBJ+ZcaN0XsNNZXQe?=
 =?us-ascii?Q?juoB4dIGNOGJSLOXlWCHFLVMzCg8iG8QL5+nWb+QEptFN045vtBR/C4T/N5D?=
 =?us-ascii?Q?4TofcPI4CygZixttASdr5Ku52RWKj2zyA6pmhciAPEZhNCVtQEIunGtH1ALH?=
 =?us-ascii?Q?osytr6Dd9y5B75nikWMskrJGHDYry+ywlXNCB1l2izgSoGITWmVeC6LyOLi2?=
 =?us-ascii?Q?sYy6tYVnyyZUAJgEl+v3u6mkfONDPG1UF50ePW5z18OPuvoCQr2g1qX7XTb3?=
 =?us-ascii?Q?m7gFos/MakkeIItYO2eICHwXsYRp2FN0NZliXcIjz/1m9bX+K8MIheq24s+x?=
 =?us-ascii?Q?qpUiATphWDyWl+YUjQJc3UFo9iWQZLwHyU9oS9CI9gNVsTzwU/7E8oLWpFkl?=
 =?us-ascii?Q?UlW79+FI2vD1XCVr6Ceq1lVV7hIzrCMsffeFMFhcnbOPNeKOsRd/WcHTdBEW?=
 =?us-ascii?Q?u8bzEhNk9DwFwhHvZCJJlmVD4FxNEbUTr1l5ojI2lvoY/OQyO9Yh8WRleWg5?=
 =?us-ascii?Q?XjzqJHSjK2b4yB5VSo/+3atrqKXBxZuTHWrHkjuY2FRwmUYmxIPrePTVS37J?=
 =?us-ascii?Q?CBBNmrWmiwYJDmOEb7hrZjqy/hxVaP2++dmCGciQeQ9PragbbblduqriHxGH?=
 =?us-ascii?Q?TVGqlp7OQXGDJMrWb63ELkCN8wvqGDC9mcbOHxb+uEufhlstEGX8I5/HVbCF?=
 =?us-ascii?Q?9ziy/A+ZqNNvglMaBQvktFa1pLgcd9dckIQ3r2jvg5agg1Sgb4I5iWG4IM6h?=
 =?us-ascii?Q?yd/aYzJrherXeT+VaOPuHqyJVCM/uroom32ii7pfvkSvx+4q10gC3bZX0zKP?=
 =?us-ascii?Q?+TJWXp3g6wuRXVFrUpYfjX+qoajzUTzWex26jsvY18jAlRnqDiO+hx6I+8AY?=
 =?us-ascii?Q?U5PJEurvidwpflY024AdXVbbNI7eFxh7YOJ9mOkEHkqSDX60ct1947bh8Q1G?=
 =?us-ascii?Q?VPPBLmhWKrwjFFJ5QXzdk0AtqBMZiapYSOjVnndyIgeOQ1T1iHQ9ZxdRyoY7?=
 =?us-ascii?Q?jISBPMzeJustQoHvxYEzaimMzXbSBewYhWB8biodr15RZMsLb9EhN7yYZbfL?=
 =?us-ascii?Q?3/SnxQPR3LKP1gz6S3cyhKU9b9r6sobsyWqgVX+Px/QdJIzz/hwMmeYDytTk?=
 =?us-ascii?Q?x3C0mV/TXQI9zcNkUfMJ/EnkLkc+n1+Gb2dVR4TFkLIYXcFL55qYiXCAClSs?=
 =?us-ascii?Q?OYp/CYOjArg7mxlSRt/PXuUSbq2kqlRryE/xl8idkcAtjGCf4pQYMnV94ahc?=
 =?us-ascii?Q?donFfnud/+MwgPC0Hw8GgykWFZa35uwnWqWYr5iRMDJv8fXH1jVEvCy6G2hw?=
 =?us-ascii?Q?Zo6gakh4PzHqX3xsYs2Qc6onHXEwE00HoO4go7TnFUvjOqgBmmhplokS0PC6?=
 =?us-ascii?Q?3JqxWe4Uo1SoWcDVk6dePWeFQVbOI6VGvPBvxICyJ7CbbpYh2c/bQ1hICSzr?=
 =?us-ascii?Q?cRJfW2O3t9msivfFgV7KojrXARfPf7KNDPa6A/PxC8wb679pPoIiVa+Zy97v?=
 =?us-ascii?Q?ZUqz0p4FytuaokZKDXvZb2/yk6+M04Q3S133dbyK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79599a86-8677-4f3c-e38d-08dc72948b54
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 15:02:29.9240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HztEr6sBrF7GQWGj4uSMRVp44x/lcdu2zsBJ1gFgF9jnJVcJr/NUZHOZAa4iE5yX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7643

On Fri, Apr 12, 2024 at 08:47:09PM -0700, Nicolin Chen wrote:

> +/**
> + * struct iommu_vqueue_alloc - ioctl(IOMMU_VQUEUE_ALLOC)
> + * @size: sizeof(struct iommu_vqueue_alloc)
> + * @flags: Must be 0
> + * @viommu_id: viommu ID to associate the virtual queue with
> + * @out_vqueue_id: The ID of the new virtual queue
> + * @data_type: One of enum iommu_vqueue_data_type
> + * @data_len: Length of the type specific data
> + * @data_uptr: User pointer to the type specific data
> + *
> + * Allocate an virtual queue object for driver-specific HW-accelerated queue
> + */
> +
> +struct iommu_vqueue_alloc {
> +	__u32 size;
> +	__u32 flags;
> +	__u32 viommu_id;
> +	__u32 out_vqueue_id;
> +	__u32 data_type;
> +	__u32 data_len;
> +	__aligned_u64 data_uptr;

Some of the iommus will want an IPA here not a user pointer. I think
it is fine API wise, we'd just add a flag to indicate data_uptr is an
IPA.

Jason