Received-SPF: pass (google.com: domain of linux-kernel+bounces-176911-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 12 May 2024 12:19:12 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
	suravee.suthikulpanit@amd.com, joro@8bytes.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
	yi.l.liu@intel.com, eric.auger@redhat.com, vasant.hegde@amd.com,
	jon.grimm@amd.com, santosh.shukla@amd.com, Dhaval.Giani@amd.com,
	shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH RFCv1 13/14] iommufd: Add mmap infrastructure
Message-ID: <ZkDd8A2qAYnuxGJQ@nvidia.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <6fef9ff9944381d51dd18f83ec03785a26754dcf.1712978213.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6fef9ff9944381d51dd18f83ec03785a26754dcf.1712978213.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3CdML4He5OmEdOQ4Q7tNVzx5xH5gUPeMa1jImmje5IzzW5ONUjgLef24fqHJ?=
 =?us-ascii?Q?T3Xe73OPVzBWfHEhizddmhKR2Y3S6/2hdVMmk6BHl7b1eyDK9V0mhPUjDGU4?=
 =?us-ascii?Q?uHs7Q/5dYlu1OkpUpqCyMgSht0E9DX3pTvJ4ss2OoSUeIXKCVP7Y9ZaDAxMm?=
 =?us-ascii?Q?A3M6Tu9nKbu3VKOlTlVmJRH0CQicdyANmPnQGFPGo/+A8jeGkuRomgtkhLQC?=
 =?us-ascii?Q?mCYwsTFrxDjEADM/l9msyfP1H1NzOTGNbCWhxj340AXQqlKD88SN8/DSIBRR?=
 =?us-ascii?Q?7oJenHn5+dX5nYXrZo8yi641iNSB1Qd9KxRzEIeWmijjXEmMYl24HsKyxNH+?=
 =?us-ascii?Q?Fcas24Pyup6Iot81KYA4QmAjwDQTdQ85YvzT0M+FMzSg/j2Nx7gKAn1xV0VA?=
 =?us-ascii?Q?F6FKnGQm9cAp0jz3MJwv2/J0FNSgdGPnWA8bOaUFaSNUVHOOtRENkdcnakAe?=
 =?us-ascii?Q?sHY6alRxunuHKpO5PP5KvEpUMihP+jBhZILgTljPS92IJrffonp4ITXwtAMv?=
 =?us-ascii?Q?HRCNCLqLCOAvrJ53Y+grkWT5WsvfZpVvC91AKPmuwR1A5yo9JaP5eqMZqQOa?=
 =?us-ascii?Q?IJ+Bj1kdyz4BcKeS26QvQRUR6mV1ZNcE9KIF4GgCt+KIMMmHbM9qNiDzpf0s?=
 =?us-ascii?Q?6Ix3ihdyPKS7mmR4ayqKHKbx02J4ELh2ZTg9mSn/FGEJONIgtMhLyVbS0Y58?=
 =?us-ascii?Q?YQeNq9W5RqMqVpocWxy2spBYJIKkyCRutwh20pCF31luvHPEg2AKM2CL+Aqs?=
 =?us-ascii?Q?afpY1KHB8OYiw3hwph+Sd7Lka+RA19OL9VUMUIcmSx3caBu3p5pc2aGecPGv?=
 =?us-ascii?Q?c8zp0fLzeCaPZih1olG9lZz9eAMUss0Q3udgLnc2P+S/a2gGoySvzCvGtjT5?=
 =?us-ascii?Q?U3TNuGR413/iOujaUERcKB2uua1pRy6TM/lFRvsGzZfNU+t9fBwK0ImwTIiB?=
 =?us-ascii?Q?WfYBuChMlyx0iYwjW/V2Yh4f4YZOmLk4lfLPnwuG+8hLIoLoXSXkUXFxZA66?=
 =?us-ascii?Q?k0Mdee4INBCibMHtMgO0uw4fzLArPsoxSZycgctVdO4KaY+XlkfTv6aoJ9op?=
 =?us-ascii?Q?UFBZDGwnb9Lq1k4td3kRWDEVcMpmL13KZh2lrb1r3InDzPIRzF+4xYJ4Cyjm?=
 =?us-ascii?Q?zGXormgr+mQ5OB6j46CL3SXfxyQqzoFLEU6kCtbDy2z0kWPq6r1Tw3DOySaN?=
 =?us-ascii?Q?ZwS3HWDbMjOaHcsQSg0vgkTGRvVYZgK0y8w04Q/5e6ihNb02Dx6ZnGYvzecb?=
 =?us-ascii?Q?fKsMLFItSjS25Vz24XFqLz1jLMXTW6XOgpSkeRqBPPWk/eIogQ6/eaPlkzgf?=
 =?us-ascii?Q?2WsK27+nIPZe8TTXvtjKS2AJ0ghTZmwqLnCWx+TtNw/XCn/IyH6JRUPGf0XZ?=
 =?us-ascii?Q?izwsyNMHCtVt/tDCpVjC0l5ySpIiMVzUY89D9FLXw/rBarVTkTatA+2DXtLl?=
 =?us-ascii?Q?r6S/tVkdGMezU97B2RMypgZAgV31Y/zGgPWzF3LN9N5DF8i8k+qr8LOm3dnG?=
 =?us-ascii?Q?Tu4euTJjdfux4vlYpzBOWDqzdYr2BQbTlF603JoZpR2D2z2lDs1P5TaACMx/?=
 =?us-ascii?Q?vhabVDyqSQIhRDLe6+6n78QVoBvLSqYh6IKLi0Ce?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 556cd57c-84a7-4b52-f843-08dc7296e66d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 15:19:21.7273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gGNT5hEN6iciEIoPyEkumw4bb+W9//7zxx4NeDIjjtHA4IDJbPMpcNo7HA5syyeP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7818

On Fri, Apr 12, 2024 at 08:47:10PM -0700, Nicolin Chen wrote:
> Add for sharing the kernel page with user space. This allows to pass
> through HW resource (VCMDQ MMIO pages for example) to user space VMM
> and guest OS. Use vma->vm_pgoff as the carrier of a viommu_id.
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/iommufd/main.c | 40 ++++++++++++++++++++++++++++++++++++
>  include/linux/iommufd.h      |  4 ++++
>  2 files changed, 44 insertions(+)
> 
> diff --git a/drivers/iommu/iommufd/main.c b/drivers/iommu/iommufd/main.c
> index 96ef81530809..5b401c80cca8 100644
> --- a/drivers/iommu/iommufd/main.c
> +++ b/drivers/iommu/iommufd/main.c
> @@ -16,6 +16,7 @@
>  #include <linux/mutex.h>
>  #include <linux/bug.h>
>  #include <uapi/linux/iommufd.h>
> +#include <linux/iommu.h>
>  #include <linux/iommufd.h>
>  
>  #include "io_pagetable.h"
> @@ -427,11 +428,50 @@ static long iommufd_fops_ioctl(struct file *filp, unsigned int cmd,
>  	return ret;
>  }
>  
> +static int iommufd_fops_mmap(struct file *filp, struct vm_area_struct *vma)
> +{
> +	struct iommufd_ctx *ictx = filp->private_data;
> +	size_t size = vma->vm_end - vma->vm_start;
> +	u32 viommu_id = (u32)vma->vm_pgoff;

Don't do mmaps this way, it doesn't scale well for future things.

The pgoff/length should *always* come from the kernel as some
'mmap_offset' output. I usually call this the mmap cookie.

In this case have the mmap cookie for the tegra doorbell return in the
viommu's driver data struct, then userspace just passes the opaque
cookie to mmap to get the correct tegra doorbell.

The core code has some simple xarray/maple tree to allocate cookies
and dispatch them to the correct mmap callback. Usually I'd say to
provide a mmap callback pointer when allocating the cookie.

Also look at the RDMA Code around mmap there is a bunch of VMA
validations needed. Ie we must insist on VM_SHARED and check
permissions, etc.

Jason