Received-SPF: pass (google.com: domain of linux-kernel+bounces-176923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 12 May 2024 12:34:07 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v7 2/6] iommu/arm-smmu-v3: Issue a batch of commands to
 the same cmdq
Message-ID: <ZkDhb5ZmymmT2+64@nvidia.com>
References: <cover.1715147377.git.nicolinc@nvidia.com>
 <a282dd487b8ea18dbb6d37907c1fb8eafda77d73.1715147377.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a282dd487b8ea18dbb6d37907c1fb8eafda77d73.1715147377.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?uhgn7va1ARL9ZPyKBiDwiEUCD/nAdqt0tRPgqn/1frgmPKpjF7ioTTfj/Pqh?=
 =?us-ascii?Q?TSEINv1ee/sV31uXkYTJVlDDxiqjKLz6JirF7WLr/KF5Ep5FnTXXHkayz0kT?=
 =?us-ascii?Q?Ln/f6qPzkThhiQ6BRnzRerdFLBDXfrbUtUBBsL2wwVnyCtgBj6jrUvLs82ph?=
 =?us-ascii?Q?7Mlcg9Jlw/LnKNL09t3FmOxXLMQp0iXExwj+q3ac3HmYk7sQ3PAs6M0JVgXr?=
 =?us-ascii?Q?MdWPx6F0UDFdjgsuW5MOU4650QURtCOeqv56XRsXCOC41AgGsfeDtBUvY9qE?=
 =?us-ascii?Q?rKiwKreZ2NK7cBO4E/QbtjcF1G1jtMrygNXUHnD7NldJXfR4qKwzuJMGCHaZ?=
 =?us-ascii?Q?qWcPcMFV6StQoOKYEw/IUpFM1sGITkkA6k3oAAE56QAqK/K5nez7Nih94LVr?=
 =?us-ascii?Q?S3w8L2gmSjPdPKO0J3tpJhrkp1SzUqhB7Gm3sIifm9rZ1+P4Sp31s31BpUd7?=
 =?us-ascii?Q?GEZog9nYFSy5pecFAMyhyUN2rAs8D1t4bsg41Vebao+MDnQBuJrIILEdSyb0?=
 =?us-ascii?Q?TOgbE1sRCI71iXHUNla9coI2jCzwM6fSFkPGDmcb/BFKLCQ+dHmt/7Fwt+1S?=
 =?us-ascii?Q?ti16p7hxrHT/HPFjPb1heCQgnvIDv1fcQDRaRAOeRg+qch8VHLMUUVVBMrtS?=
 =?us-ascii?Q?r16b0Mnic8jDlM/zsX1Qe/WFdz/WDtH4KapKppFp3P9xG0ItH6jju9Bhfb4K?=
 =?us-ascii?Q?7VSgfECkLrarrExPZx6Q4/ZbdF6R697qmAu7LVQ9aU4bQj2JSwFp+XURCisZ?=
 =?us-ascii?Q?bYCRwp/KXFiuMRfWi7heBGxeQP44GT2wkFe58yNIyL3BIzknw1SJHikpvyF1?=
 =?us-ascii?Q?tI0IwmgmA3m4EX8scowHVj3xA3m2R6EbTvi8sec9HHWsaLKcr1UbekiS94Nc?=
 =?us-ascii?Q?c7MgIijsFhzvtfBj7VYqpXVqr//oSnfvgR+acgN2AaF7m9S9W2R31tP3FEaM?=
 =?us-ascii?Q?XFPmvy9C0jHDBR8M9hP/VcmIs/Tvi8HQJplpFdmScTSJ0d7L4vc1LxnQx73a?=
 =?us-ascii?Q?kvqT87UiQ6NQVFQsQEvTMrENP6Vwmc0BszskveSmm14Bg3esdo/RkLOPR47x?=
 =?us-ascii?Q?s0QH1gRbM3lt4IL1/pqyBaSwmL3NplnQbPAog87cSSip09ln5TuGVwFNnDGk?=
 =?us-ascii?Q?Q1hV40EnlSzgNoqOYRZ0c3CX0to6/3Z+iT13CKvPku1AEfzuG/+8jFtlOmCA?=
 =?us-ascii?Q?MpHzzy8duSHeJtPWfAsIwsmq/dFjjNByVWPA6yqQIyo3DGf6B92bAy1mZONw?=
 =?us-ascii?Q?JD/ZkeWh82LVRjFQB+1wb2pVbvLzeqZm0RRB0kgUakw/AZIVm3r7DdyEzyvn?=
 =?us-ascii?Q?JpMW5W76v/c+a7eaaqEfndAdb/ON+DgUY4IKqpyvbJzT+RAKQoG1gGgnZpOY?=
 =?us-ascii?Q?e0+Q0oHzawb+HquExfNaWZpDgUKY0oiZvXQO3VxnO9zOkbIzDEH4GGGTlSnN?=
 =?us-ascii?Q?4Q5P5F88q/gePHdpJtROkNe31pC8IiYkeFYLD4Xn6sJl9acPcyto5a1jDreq?=
 =?us-ascii?Q?7E0RICoFW1G0uDtA/f/snQ+mG6ViZ1eZObHUXY2VRC+ETAjdeXXRbg0XhDJ7?=
 =?us-ascii?Q?munGvLN5bw+sfBb0WGgljdZSoXLa4ZDPFLPy7EQh?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d271be8a-35ac-4049-5965-08dc7298fa67
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 15:34:14.2693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZSaky9tQzK4n6NeFAYrPgE6AsVy2ZWsw2+MZW+CcXBDE3ue/Cm0t2rKrlJzBLq1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4397

On Tue, May 07, 2024 at 10:56:50PM -0700, Nicolin Chen wrote:
> The driver calls in different places the arm_smmu_get_cmdq() helper, and
> it's fine to do so since the helper always returns the single SMMU CMDQ.
> However, with NVIDIA CMDQV extension or SMMU ECMDQ, there can be multiple
> cmdqs in the system to select one from. And either case requires a batch
> of commands to be issued to the same cmdq. Thus, a cmdq has to be decided
> in the higher-level callers.
> 
> Add a cmdq pointer in arm_smmu_cmdq_batch structure, and decide the cmdq
> when initializing the batch. Pass it down to the bottom function. Update
> __arm_smmu_cmdq_issue_cmd() accordingly for single command issuers.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 44 +++++++++++++--------
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h |  1 +
>  2 files changed, 29 insertions(+), 16 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason