Received-SPF: pass (google.com: domain of linux-kernel+bounces-176948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <34c7ffeb-1fe9-4e89-a7b6-c6a8be17df90@web.de>
Date: Sun, 12 May 2024 19:12:20 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Hao Ge <gehao@kylinos.cn>, linux-trace-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Hao Ge <hao.ge@linux.dev>
References: <20240511024255.34767-1-hao.ge@linux.dev>
Subject: Re: [PATCH] eventfs: Directly return NULL to avoid null point
 dereferenced
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240511024255.34767-1-hao.ge@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:/rt3hg9wDxo=;lMiyN6KiDxzUuuT69+fJAMVnf69
 6NhqHDh+ChhgyGsipE/IzRwQyZ+no7qNzgzTF6rAMUQDE1q5DOvftZ1896ln/hbTx/MBqqF2i
 TD1BQFGcx32XSDDd4INrLdHoEQzfZ5YCN2xRwYD+KldKLps4aRlFUv6ojCLy94GwvhxDr/oXI
 MZIQGHsfw7dv/Z/z77OmRPUwyz49QpgQTq0I272LQxieeDZokRw0wQPhZSmGErJjHkYegvqAs
 Pmh+GyNyUjavy/z/f5moUFys71gvJaOGgpwftsKDoKIXjzIW3G2JBDHyWcPFBz3OOfNK9KNdL
 AXM3VOFYRDWBxyRGLFvpska64oTu7PN51ux55vh7Tz/tvhCnebeMYk3YtkvjAH5hP5AyGQAxr
 sRxVJoEQokD/uJr8Sbi79TAgOiNtQXzMUq8FKXV1VMcKJUu8u83AEtJf9GWXNesvjPJ4FFYqH
 7CKy+RECraT/CXjZ1uQrLBDPMcRKuZj5M8Uk2TypRUsUo31pZ+o2V81BY20wiMNXD6aRDeNGX
 KCK6KsF6/KKbMRAbK7hTP4PkkKaGZvRuDSDurHV+f8Kg75W6f4a1w6m8+ByIFpfglmkehYkoE
 r+wzhUH0I0FLfAycC7q0D1kbfpwP2h2xsvNQ4CAvpsv5/LqXX3Go0ZCVbt2yH/n4iuBtZtRec
 OHIwlfwyd2IwdvV1Ayn/ujtHKy+mVcD9MQklDYFhTRhj1Aw9oO+HHJcaLPqXF2eEfj/WKnCE1
 V3NbU4pxV0wq3ibiso0Wp1Vn5LgjMQco52gHnJq79ToKgOMiAmSrXUSFWysqJ1VpsR3NBlIB/
 07uokY59xhAoCArWMFb2HN7l7RCUNhO0u9rVON7mM1YDk=

> When the condition ei->is_free holds,we return NULL directly to
> avoid update_events_attr to use NULL point about ei.

* Please avoid typos in the summary phrase and the commit message.

* Would you like to use an imperative wording for an improved change descr=
iption?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/=
Documentation/process/submitting-patches.rst?h=3Dv6.9-rc7#n94


=E2=80=A6
> +++ b/fs/tracefs/event_inode.c
> @@ -346,8 +346,7 @@ static struct eventfs_inode *eventfs_find_events(str=
uct dentry *dentry)
>  		 * doesn't matter.
>  		 */
>  		if (ei->is_freed) {
> -			ei =3D NULL;
> -			break;
> +			return NULL;
>  		}
=E2=80=A6

How do you think about to omit curly brackets here?

Regards,
Markus