Received-SPF: pass (google.com: domain of linux-kernel+bounces-176965-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <d38043cd-7fc2-4255-a795-23e64ee4a8c2@amd.com>
Date: Sun, 12 May 2024 12:58:28 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile
To: Armin Wolf <W_Armin@gmx.de>, "Shen, Yijun" <Yijun.Shen@dell.com>,
 Lyndon Sanche <lsanche@lyndeno.ca>
Cc: "pali@kernel.org" <pali@kernel.org>,
 "srinivas.pandruvada@linux.intel.com" <srinivas.pandruvada@linux.intel.com>,
 "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
 "lkp@intel.com" <lkp@intel.com>, Hans de Goede <hdegoede@redhat.com>,
 Matthew Garrett <mjg59@srcf.ucam.org>, Jonathan Corbet <corbet@lwn.net>,
 Heiner Kallweit <hkallweit1@gmail.com>,
 Vegard Nossum <vegard.nossum@oracle.com>,
 "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Dell Client Kernel <Dell.Client.Kernel@dell.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240501215829.4991-2-lsanche@lyndeno.ca>
 <BY5PR19MB392256C65661E76FC292C0889AE52@BY5PR19MB3922.namprd19.prod.outlook.com>
 <63894ef1-c482-4646-8351-4d6cfc6c528f@amd.com>
 <BY5PR19MB392299916A85FF06387DC9C19AE02@BY5PR19MB3922.namprd19.prod.outlook.com>
 <a1306ffa-c0ea-4ce6-8692-76bf37850e8a@amd.com>
 <BY5PR19MB3922A117E489A55C3C7FAC789AE02@BY5PR19MB3922.namprd19.prod.outlook.com>
 <4d8de625-9018-4926-9519-37f5a90a96e5@gmx.de>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <4d8de625-9018-4926-9519-37f5a90a96e5@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L1BCSzQyTDBPZFoxZDYzNlRhejJXSmg4Mm9qVDUwTTBuOFpidEFQQWRQb29m?=
 =?utf-8?B?b2w0Y0U0VktBZnN1QVJSMTQ1bHFhTnBvQTZva3JZKzVOYlIzcW96N096bUN1?=
 =?utf-8?B?d2YybWtkeVlxK1pjNHNqUHpTOUU0RHI0bVNpMzZucG1MelpHc3hCUHhpSmpy?=
 =?utf-8?B?bHc4cVBJZXR1Y3IwWHpHc2VIUWJhMyttZ1hOZUFXTmxVRXRWaFltY292N0ZY?=
 =?utf-8?B?NmZWSXVCdlZvSndTZVhWREppcmd1NVpGZGh4c2hzOHpMQk9DdkM3RFJCSzRJ?=
 =?utf-8?B?amRtMEFMRGFsVllVSVI1M1dHcGEvbHhaRHl6Ty9RdEFya2xrWFhPSzZEQWtn?=
 =?utf-8?B?cTBUSUdXNjY0blhlbFN3TFNnd201VVZpTEZJL2FPVDJpa2hrZTYvNDd0Mm0x?=
 =?utf-8?B?aTZnR0l1TUd3WlBuWGhaVFIwK25vRlIyNDNqUFhuK05LR0Y3MHJQSklBY3Zy?=
 =?utf-8?B?K3NlamJJeFlFSEZJWkRBUXFTbTNwR3RpWHA5SGtVWm9ZZzFIalYvVy9Pbnpk?=
 =?utf-8?B?WU9WN1dCNHlUdmNHcFdqeGhvcjRLQ0V6YTFLeGgvY3llZU5QZERHR20yM0lL?=
 =?utf-8?B?eVRlQURpRUpwMzJpUFFGeXhYL2Z6S0wveVl1ZENvKzZmQmZzd2ZGMTc1ek90?=
 =?utf-8?B?MnJuRTNWVWtIQlZnemhlS25OdDZnaTArOW50YXFFNHc0Q3pzUWxOcDJkcU1I?=
 =?utf-8?B?TUtzMllST1kxdVJnam9HVFhaYWwxbU8yQ1lhZTloaHpEc0JadXpoWjR1T084?=
 =?utf-8?B?bFJXZVgzMFN2REtkRHU2eGRvMnBBMHJleUpSMXF5QU9IQ29nbTZmZ0ZPQkM3?=
 =?utf-8?B?SzdNbmhLeWEyRlAwZDhHd2VGb0EvWmd6QTU4OEVCYmhwTTJwRXpSOURWY3RR?=
 =?utf-8?B?YTVwbU1lM1RzdW85VThPQ2hld3p4QzRJbHdjWGtqVnFhNXFJQU5kUm5uN0xU?=
 =?utf-8?B?MDlvZ2JGQ1lyUkhCT3ZrVGk4MTlNTmJiZEtSNDRReGFXa3dXZ1YvRVVoRUQ0?=
 =?utf-8?B?NkhNY2NzK1NVL1pXRHQrRTh3eXZlWWRIbGRLMHdzM1o0V2tpWXZvRE1WY1Zn?=
 =?utf-8?B?dHFUNkxtMDVvb0w4dzE4bWFsQ3U5eEw0R1cvSlpVRDZCcElnTkZ2bG9jUWlT?=
 =?utf-8?B?K3ptWWpiWWRSamZ0d094Y1F4RzNSalhUendsYUhDUWhpejUrM3M4SGxnV0Fm?=
 =?utf-8?B?ZE91Y1E0NUFFbmY5dFRXcXNVU3V2NU9ac3VuR1B4VDkzMkdtd0ZFdTQ4S0Zu?=
 =?utf-8?B?MHNtWlpiN09qdElvVE9jNW5jZGFrZmhpS1FyclI3RzhkMU52LzNGanVza3Rm?=
 =?utf-8?B?dDhiMTFSLzdScVZuQ2RVT1ozUEJ2enc4cytnaWt6NHpLQm40TUM1T3lvZ2FT?=
 =?utf-8?B?ODg2UTIwYlFoV09qaUdLTmpybXlOdE15RTJLYWtudldOMXlXZ0V2WDRveWhW?=
 =?utf-8?B?RTJmOWI1cGZTMXAvd0pVOEt2Tmp4b1YwZTB4NGEzTFhQNlptbEp2QnF0YlJ6?=
 =?utf-8?B?MnI0QXNnOWptWnZmNTFsNjVyRStqK1JlRHB6K2xzbHUyUElzbkdqZTVNNGpF?=
 =?utf-8?B?V2srU1NpL25xelNQK3BVd01sYVNjSldMUXVwVUdRb1VrNmV2eW5QeXE0Wkk0?=
 =?utf-8?B?V1U5c1hmRDJiVXJkMzN6UW5BYUlyS2NROHBTdzBndTdPdHRMMDdycDU5b0hZ?=
 =?utf-8?B?dVlrb3FvdCt0VDBOWkY2alpiaHNpeVloY1Bxc0svUThsSVJQNkhXbEFzWVJl?=
 =?utf-8?B?OHN5YWszV2MvQzV5ZWluNXhYZmdHVTd2S1FJNnZNUWVrZ2NvU1J1QXpqaDdT?=
 =?utf-8?B?T1pYTnhhazMveWdhNGRuVmc0MERiTmtvbXJmTjJEY1ZuMjh2RnBYdTZVamVG?=
 =?utf-8?B?Y256RTFpNzFCSmU3VWw1UFFDU3ZJb2Y5blpoNHJENjBNcjVRd0dvdVFVamla?=
 =?utf-8?B?UTR4Z25JRnJHQW05Vmd0ZlJjN3NVTU5pNG5sOWJsaVZHd05Pcjd6OUY5Y3dM?=
 =?utf-8?B?Zi9VUGFQS3Y4TFdDa20va2ViSm5Na2FlK3JkalBVeURZM2tUR0g5NngzRExQ?=
 =?utf-8?B?SkttUEZXRzRHb1czUnVwdUlaL29CSExZbHEzNGpURFhFcFpmaWg5TGhlRFQr?=
 =?utf-8?Q?jgCseg2gWizkUYDlaeIKZFRo9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34493899-cb82-48d7-5a4d-08dc72ad2272
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 17:58:31.3651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3guPlT4WYk7jxdJQChQccaOosqNUufHClAJIP91OV5s8iT+6Pq1bxFVdDBN5jSCEAU1bSMhQvdmCPqdz7wX7QQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7715


On 5/12/2024 12:53 PM, Armin Wolf wrote:
> Am 11.05.24 um 17:56 schrieb Shen, Yijun:
> 
>> Internal Use - Confidential
>>> -----Original Message-----
>>> From: Limonciello, Mario <mario.limonciello@amd.com>
>>> Sent: Saturday, May 11, 2024 11:13 PM
>>> To: Shen, Yijun <Yijun_Shen@Dell.com>; Lyndon Sanche
>>> <lsanche@lyndeno.ca>
>>> Cc: pali@kernel.org; W_Armin@gmx.de;
>>> srinivas.pandruvada@linux.intel.com; ilpo.jarvinen@linux.intel.com;
>>> lkp@intel.com; Hans de Goede <hdegoede@redhat.com>; Matthew Garrett
>>> <mjg59@srcf.ucam.org>; Jonathan Corbet <corbet@lwn.net>; Heiner Kallweit
>>> <hkallweit1@gmail.com>; Vegard Nossum <vegard.nossum@oracle.com>;
>>> platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; 
>>> Dell Client
>>> Kernel <Dell.Client.Kernel@dell.com>
>>> Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement 
>>> platform_profile
>>>
>>>
>>> [EXTERNAL EMAIL]
>>>
>>>
>>>
>>> On 5/11/2024 10:05 AM, Shen, Yijun wrote:
>>>> Internal Use - Confidential
>>>>> -----Original Message-----
>>>>> From: Mario Limonciello <mario.limonciello@amd.com>
>>>>> Sent: Wednesday, May 8, 2024 11:53 PM
>>>>> To: Shen, Yijun <Yijun_Shen@Dell.com>; Lyndon Sanche
>>>>> <lsanche@lyndeno.ca>
>>>>> Cc: pali@kernel.org; W_Armin@gmx.de;
>>>>> srinivas.pandruvada@linux.intel.com; ilpo.jarvinen@linux.intel.com;
>>>>> lkp@intel.com; Hans de Goede <hdegoede@redhat.com>; Matthew
>>> Garrett
>>>>> <mjg59@srcf.ucam.org>; Jonathan Corbet <corbet@lwn.net>; Heiner
>>>>> Kallweit <hkallweit1@gmail.com>; Vegard Nossum
>>>>> <vegard.nossum@oracle.com>; platform-driver-x86@vger.kernel.org;
>>>>> linux-kernel@vger.kernel.org; Dell Client Kernel
>>>>> <Dell.Client.Kernel@dell.com>
>>>>> Subject: Re: RE: [PATCH v5] platform/x86: dell-laptop: Implement
>>>>> platform_profile
>>>>>
>>>>>
>>>>> [EXTERNAL EMAIL]
>>>>>
>>>>> On 5/8/2024 09:24, Shen, Yijun wrote:
>>>>>> Hi Lyndon,
>>>>>>
>>>>>>     Thanks for working on this patch.
>>>>>>
>>>>>>     Dell side has an initial testing with this patch on some laptops,
>>>>>> it looks
>>>>> good. While changing the platform profile:
>>>>>> 1. The corresponding USTT option in BIOS will be changed.
>>>>>> 2. thermald will not be impacted. The related PSVT and ITMT will be
>>> loaded.
>>>>>>     Some Dell DTs does not have the USTT, Dell'll have a check if
>>>>>> nothing is
>>>>> broken.
>>>>>
>>>>> Hi Alex!
>>>>>
>>>>> Have you had a check both on both your AMD laptops and workstations
>>>>> too, or just the Intel ones?  I think it would be good to make sure
>>>>> it's getting the correct experience in both cases.
>>>>>
>>>> Hi Mario,
>>>>
>>>>    I've a check for this, for both laptop and workstation, the 
>>>> dell_laptop
>>> module will not be loaded. So, AMD platform will not be impacted by this
>>> patch series.
>>>> Follow is one example output with workstation.
>>>>    #lsmod | grep dell
>>>>      dell_wmi               28672  0
>>>>      dell_smbios            32768  1 dell_wmi
>>>>      dcdbas                 20480  1 dell_smbios
>>>>      dell_wmi_descriptor    20480  2 dell_wmi,dell_smbios
>>>>      sparse_keymap          12288  1 dell_wmi
>>>>      ledtrig_audio          12288  3 
>>>> snd_ctl_led,snd_hda_codec_generic,dell_wmi
>>>>      video                  73728  2 dell_wmi,nvidia_modeset
>>>>      wmi                    40960  5
>>> video,dell_wmi,wmi_bmof,dell_smbios,dell_wmi_descriptor
>>> Ah; right that makes sense.  In that case, is dell-laptop even the 
>>> right place for
>>> this patch series?  I would think the same policies for the platform 
>>> profile
>>> should be able to apply to desktop/workstation.
>>>
>>> The v6 of this series would block smbios-thermal-ctl from working on a
>>> workstation too.
>>>
>>>>>>      Additional, with this patch, follow behavior is found:
>>>>>>     1. For example, the platform profile is quiet.
>>>>>>     2. Reboot the system and change the USTT to performance.
>>>>>>     3. Boot to desktop, the platform profile is "quiet", the USTT
>>>>>> will be
>>>>> changed back to "quiet".
>>>>>>     This looks like not a proper user experience. The platform
>>>>>> profile should
>>>>> honor the BIOS setting, aka, the platform profile should be switched
>>>>> to "performance".
>>>>> I agree, this sounds like the initial profile needs to be read from
>>>>> the BIOS settings too.
>>>>>
>>>>> Furthermore I wanted to ask is there also a WMI setting that
>>>>> corresponds to this that dell-wmi-sysman offers?
>>>>    Yes, Mario, you're right. This thermal setting could also be 
>>>> toggled by dell-
>>> wmi-sysman.
>>>> But, for the Dell consumer AMD laptops, like Alienware, the BIOS is 
>>>> another
>>> variant which is different with the workstation one.
>>>> With this variant BIOS, there is no USTT and also no dell_wmi/dell-wmi-
>>> sysman.
>>>>> I'm wondering if both should be probed in case the SMBIOS one goes
>>> away one day.
>>>>    Yep, I think this is a good suggestion.
>>>>
>>> Great! Although something I wonder is if the policy when changed with 
>>> dell-
>>> wmi-sysman is immediate or requires a reboot.  A lot of the settings 
>>> in there
>>> aren't effective until after a reboot.
>>>
>>> If this is one of them then it might not be a good idea to make it 
>>> work for
>>> both.
>> Hi Mario,
>>
>>   Just have a check, the check steps are:
>> 1. stop the thermald
>> 2. run the stress test
>> 3. Toggle the thermal setting between UltraPerformance and Quiet via 
>> dell-wmi-sysman
>> 4. Check the CPU FAN speed
>>   The system reboot is not needed, the CPU fan speed changes immediately.
>>   A screen recorder here: 
>> https://dell.box.com/s/p2bhd2b6cv8z5buk9eao3bosgrrp1lf9
>>
>> Thanks
>>
> Hi,
> 
> i believe it should be the responsibility of the manufacturer (in this 
> case Dell) that
> the thermal state remains consistent across both interfaces.
> 
> I think that the official Windows utility only checks the thermal state 
> reported by
> the USTT interface, so we should match this behavior.
> 
> Thanks,
> Armin Wolf
> 

Why?  Windows also does ACPI-WMI differently than Linux.  It's not as 
easy to check both from a Windows utility due to that.