Received-SPF: pass (google.com: domain of linux-kernel+bounces-176967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <565b4f5b-524b-4093-9c24-9e34cd0643f2@gmx.de>
Date: Sun, 12 May 2024 20:00:29 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking
 supported commands
To: Lyndon Sanche <lsanche@lyndeno.ca>
Cc: mario.limonciello@amd.com, pali@kernel.org,
 srinivas.pandruvada@linux.intel.com, ilpo.jarvinen@linux.intel.com,
 lkp@intel.com, hdegoede@redhat.com, Yijun.Shen@dell.com,
 Matthew Garrett <mjg59@srcf.ucam.org>, Heiner Kallweit
 <hkallweit1@gmail.com>, Randy Dunlap <rdunlap@infradead.org>,
 Vegard Nossum <vegard.nossum@oracle.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Dell.Client.Kernel@dell.com
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240511023726.7408-3-lsanche@lyndeno.ca>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240511023726.7408-3-lsanche@lyndeno.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:wvSpFdmVY/I=;uHacvFpzaERGLYrJEsniU9GhTCr
 GhoWKYRIlGGGiR2gc8pwdwyqiamXIOpJXVuwjwk7MP2KB9Y2hVJvtz642UXm6lujAYre1QmMj
 bVZhVZeHipXWGpmwf8eI5zG58xZg2xkGZR/kkSZfXHQD6KhXcCA84A1PKPFib7FpeQX5inlOu
 zzZNtEaTAG07Yq4PDcQjgzp1KXIrHMOgnvnt5eh3VOj4ndPIFJCMNYYxoK2Q4eKLr4Iuz++YQ
 aF309Q/F1KSX1q95Hlj2d9P7ahWlADsaqNgQ5Wc18Pxa3ICRxn1cYsKj7cbYiUTMRH7ReC4Oa
 kvG4Hvf7WxfqG2lZGh3bZeAiALfIca+oMBRto4Q/SN2WW8Y+hcB32PL43xss9V6IZBAMqjHlo
 nEsnqj18wBhi6gnp7Buos12odCwFIserFc2o2Ld3c7BeSNOZyIu5Tf+Wkc59Rbtgzp6vNBQzJ
 2CojmCrFRf79dAeyUntqpY2xbvgig5dDMgMKyko8ILekNvDRstZeyDzpEXj+17gbxvng5YMi3
 iJtbjitjvhFjIRrOpM/TFgjKIjTTH/Gi0IbsuxhhIrcTvfQtZRIZxyKD6jKqEDf+j5pwKlTGF
 LxWXJb+J9cyePj++gw4sowglrs0N8ak3v80FczyT/YbaudQ8ykQV5L5ySRXwWmL7lLjTZo3Ix
 oE1aHRdUm9K4I3+XPXcFkP2/qh0aA6sfrurjX4zGIpOyXmIhHM3o4wz8EFzmp1wwKDWSs9L0M
 a4TuJ16x3HmJrdjpm1IB2A4qEf8bq4nK6exgSKW6aGyfy6+zScOanRdGJgE6Pt/jU09cdYYAy
 nKDRjqBmRPcMGvQlgf5LP9XqnSB1hcvEIPjVrSD6KIm6E=

Am 11.05.24 um 04:36 schrieb Lyndon Sanche:

> Add symbol to check if a specific class of smbios command is supported.
>
> Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
> ---
>   drivers/platform/x86/dell/dell-smbios-base.c | 6 ++++++
>   drivers/platform/x86/dell/dell-smbios.h      | 1 +
>   2 files changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/dell-smbios-base.c b/drivers/plat=
form/x86/dell/dell-smbios-base.c
> index e61bfaf8b5c4..6ae09d7f76fb 100644
> --- a/drivers/platform/x86/dell/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell/dell-smbios-base.c
> @@ -350,6 +350,12 @@ void dell_laptop_call_notifier(unsigned long action=
, void *data)
>   }
>   EXPORT_SYMBOL_GPL(dell_laptop_call_notifier);
>
> +bool dell_laptop_check_supported_cmds(u16 class)
> +{

Hi,

the function dell_smbios_call_filter() says that classes above 30 are alwa=
ys unsupported,
so please check this here too.

Also please rename the function to something like dell_smbios_class_is_sup=
ported().

Other than that:
Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> +	return da_supported_commands & (1 << class);
> +}
> +EXPORT_SYMBOL_GPL(dell_laptop_check_supported_cmds);
> +
>   static void __init parse_da_table(const struct dmi_header *dm)
>   {
>   	/* Final token is a terminator, so we don't want to copy it */
> diff --git a/drivers/platform/x86/dell/dell-smbios.h b/drivers/platform/=
x86/dell/dell-smbios.h
> index eb341bf000c6..63116671eada 100644
> --- a/drivers/platform/x86/dell/dell-smbios.h
> +++ b/drivers/platform/x86/dell/dell-smbios.h
> @@ -73,6 +73,7 @@ enum dell_laptop_notifier_actions {
>   int dell_laptop_register_notifier(struct notifier_block *nb);
>   int dell_laptop_unregister_notifier(struct notifier_block *nb);
>   void dell_laptop_call_notifier(unsigned long action, void *data);
> +bool dell_laptop_check_supported_cmds(u16 class);
>
>   /* for the supported backends */
>   #ifdef CONFIG_DELL_SMBIOS_WMI