Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759303AbYA3VaP (ORCPT ); Wed, 30 Jan 2008 16:30:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751719AbYA3V35 (ORCPT ); Wed, 30 Jan 2008 16:29:57 -0500 Received: from smtp4.pp.htv.fi ([213.243.153.38]:58367 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbYA3V34 (ORCPT ); Wed, 30 Jan 2008 16:29:56 -0500 Date: Wed, 30 Jan 2008 23:30:30 +0200 From: Adrian Bunk To: Sam Ravnborg Cc: James Bottomley , davem@davemloft.net, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] scsi/qlogicpti.c section fixes Message-ID: <20080130213030.GR29368@does.not.exist> References: <20080130200336.GN29368@does.not.exist> <1201726817.3292.84.camel@localhost.localdomain> <20080130212011.GA26621@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080130212011.GA26621@uranus.ravnborg.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 30 On Wed, Jan 30, 2008 at 10:20:11PM +0100, Sam Ravnborg wrote: > On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote: >... > To my understanding Adrian just fixed a potential oops. > You have a driver that surely are thought to be hotplugable - > otherwise qpti_sbus_probe() would not have been annotated __devinit. > And had it ever been hotplugged then you had called a function in > a __init section that was long gone. >... s/had it ever been hotplugged/had it been hotplugged with a kernel compiled with gcc 3.2 or 3.3/ > Sam cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/