Received-SPF: pass (google.com: domain of linux-kernel+bounces-177004-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 12 May 2024 22:39:07 +0200 (CEST)
From: Richard Weinberger <richard@nod.at>
To: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Cc: David Woodhouse <dwmw2@infradead.org>, 
	linux-mtd <linux-mtd@lists.infradead.org>, 
	linux-kernel <linux-kernel@vger.kernel.org>, 
	lvc-project@linuxtesting.org
Message-ID: <1371873614.97879.1715546347299.JavaMail.zimbra@nod.at>
In-Reply-To: <20240329121629.316171-1-artem.chernyshev@red-soft.ru>
References: <20240329121629.316171-1-artem.chernyshev@red-soft.ru>
Subject: Re: [PATCH] fs/jffs2: Fix NULL deref in jffs2_scan_dirty_space
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: fs/jffs2: Fix NULL deref in jffs2_scan_dirty_space
Thread-Index: y5ad11duY8iSWWYoNLafHLQXdw07tQ==

----- Urspr=C3=BCngliche Mail -----
> Von: "Artem Chernyshev" <artem.chernyshev@red-soft.ru>
> An: "David Woodhouse" <dwmw2@infradead.org>, "richard" <richard@nod.at>
> CC: "Artem Chernyshev" <artem.chernyshev@red-soft.ru>, "linux-mtd" <linux=
-mtd@lists.infradead.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, lvc-project@linuxtesting.org
> Gesendet: Freitag, 29. M=C3=A4rz 2024 13:16:29
> Betreff: [PATCH] fs/jffs2: Fix NULL deref in jffs2_scan_dirty_space

> As was mentioned in 2ebf09c2, it is possible to get oops,
> when marking space dirty in scan, but no previous node exists
>=20
> It still can be in jffs2_link_node_ref() via deref jeb->last_node.
> Since all jffs2_scan_dirty_space() callers check value of a
> function, we can return error code safely.
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
> ---
> fs/jffs2/nodelist.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/fs/jffs2/nodelist.c b/fs/jffs2/nodelist.c
> index b86c78d178c6..6bebf1d64000 100644
> --- a/fs/jffs2/nodelist.c
> +++ b/fs/jffs2/nodelist.c
> @@ -669,8 +669,11 @@ int jffs2_scan_dirty_space(struct jffs2_sb_info *c, =
struct
> jffs2_eraseblock *jeb
> =09=09=09size, jeb->free_size, jeb->wasted_size);
> =09=09BUG();
> =09}
> +=09if (!jeb->last_node) {
> +=09=09return -EINVAL;
> +=09}

Did you test this change? I'm not so sure whether returning -EINVAL is
correct.

Thanks,
//richard