Received-SPF: pass (google.com: domain of linux-kernel+bounces-177036-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <24fa8cdd-4c7b-4ec2-bffd-ff80e190f5fa@amd.com>
Date: Sun, 12 May 2024 17:14:40 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile
To: Armin Wolf <W_Armin@gmx.de>, "Shen, Yijun" <Yijun.Shen@dell.com>,
 Lyndon Sanche <lsanche@lyndeno.ca>
Cc: "pali@kernel.org" <pali@kernel.org>,
 "srinivas.pandruvada@linux.intel.com" <srinivas.pandruvada@linux.intel.com>,
 "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
 "lkp@intel.com" <lkp@intel.com>, Hans de Goede <hdegoede@redhat.com>,
 Matthew Garrett <mjg59@srcf.ucam.org>, Jonathan Corbet <corbet@lwn.net>,
 Heiner Kallweit <hkallweit1@gmail.com>,
 Vegard Nossum <vegard.nossum@oracle.com>,
 "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Dell Client Kernel <Dell.Client.Kernel@dell.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240501215829.4991-2-lsanche@lyndeno.ca>
 <BY5PR19MB392256C65661E76FC292C0889AE52@BY5PR19MB3922.namprd19.prod.outlook.com>
 <63894ef1-c482-4646-8351-4d6cfc6c528f@amd.com>
 <BY5PR19MB392299916A85FF06387DC9C19AE02@BY5PR19MB3922.namprd19.prod.outlook.com>
 <a1306ffa-c0ea-4ce6-8692-76bf37850e8a@amd.com>
 <BY5PR19MB3922A117E489A55C3C7FAC789AE02@BY5PR19MB3922.namprd19.prod.outlook.com>
 <4d8de625-9018-4926-9519-37f5a90a96e5@gmx.de>
 <d38043cd-7fc2-4255-a795-23e64ee4a8c2@amd.com>
 <e583ccb0-b0be-4fb6-8e70-e4cd6921d77d@gmx.de>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <e583ccb0-b0be-4fb6-8e70-e4cd6921d77d@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RXFYSVJZN1RGcCsxTzF1Qy9ralhtb0RtVzJhYjNuK3c2K0p0bGhadkhCUlg1?=
 =?utf-8?B?QjBTNUJkWW5MWW5XV2VTTkN1ME9odS9xdHJ1TWhXYmtWdERnTzRwVTBRTkpX?=
 =?utf-8?B?OE56WlRkbzBVR1FXVmFTOCtaU1ZMdXFlSGJDNkRyWndDa01YTFpySk00alJp?=
 =?utf-8?B?Z2o1ekZ2ay9WSnpydlFkUzcxa2ZaZ2lEQ2c0N2dpZ2VRZjdWb2p6V1lGT0Rm?=
 =?utf-8?B?aG5pSjBqWkZFTVN1QkRhbHFHdnkwZituMG9neG1jYlltbTJFSXNJa3BrdFRC?=
 =?utf-8?B?TmZESmp4bmJkcUl5QzQzd2lsOHBCM1c1R1B2T1BKZm9aNlpGai9oUEwveUxk?=
 =?utf-8?B?dzdtUlQ3N1ZLcDNXMEtHOVV5RkFaaDc5bEQ4aG9XSmFxT0h0NzhsQkRiZVB2?=
 =?utf-8?B?d0lxN0pmdEw0Q3U1TnBBVUFadVduWE1VK0FCUE9xOVRucTlWbVJsQWpnQysr?=
 =?utf-8?B?K1hEWHpHQkNMc2l2NVp5Ylp6bmNVY3lSWUllUklZZ0x6anEyOUd6VDdPMlgz?=
 =?utf-8?B?RFdvYVU4TFQyV3I5ZFd0emxNV1BWV2NuMkdlaWFOV09rZUVQZVJrOW9xbnRH?=
 =?utf-8?B?QkUwZVJqRzlBcFcwRVZBMkJHOXVGUzNsM2ozclFFZnU1K3JWT1kyU0pkVDZx?=
 =?utf-8?B?RVp4RVUzdjBIaGlpMEFmNVdZeUZoUGtHTGJvcUsrWHl2TUhVQ3R2a3Bia09l?=
 =?utf-8?B?czJwYmUrTFp2dmZtdS9IaTFBU1EvZmx3TUVPbm8zOVlGV0JONXQ5TFhnOERn?=
 =?utf-8?B?SHZGempXVDJzdGpmcWtsVFE2bkhQWXRjdnFNalNsU0ZmWVJLQ1N2eTF2aUlT?=
 =?utf-8?B?VnYxVGNlVk83cGVZaXYxcys2a2JzaWhCQkhIRUJuRGMvYUV2TkdMeFNQYjFT?=
 =?utf-8?B?RXN5MXFPMUt3Y29pM3poRmZZVGNSQVNJWWs3bHR5RGErZjhvMUMxSnNLT1Jh?=
 =?utf-8?B?RHdpRDJwakdNT1V1Q3F1aGd2dExuQmN1RndqTEUyVDY1WDhNSk92MjQ3bGpk?=
 =?utf-8?B?RGdXYU9hL0ZLb2FrNzBNOGJlSHhBZjBpU0JJOUZhY3hXaUZ2RnQ1K04vcjJM?=
 =?utf-8?B?ZW5SQ3JrU09SbUI2MWd6bnNtNm5UNjdLQjlNYm1kSnY1Y254d1RaVlAzc1lO?=
 =?utf-8?B?MnBzV1J1dUNBb0YvTTlXbnJseWxqWCtEWnZLRE00dnJwVVNCM2JGazFXSWlr?=
 =?utf-8?B?TWQxWmdxYUp1ZTFFQWI4SGZ5VXBOQlA5TkdkanBxK1VLRWV6RVRPcm5UUjM5?=
 =?utf-8?B?eWRpS2hlV1krMmFTVmVlTSt3dkxiRDVIQ2ZVcnIvOGlUSFlnVlg1ZnptcGpH?=
 =?utf-8?B?M3dvMjJJOFZHYjAra0UwKysyaWowVEVneHRCOUhvTWhUWEVJRUtIQVk0TVlw?=
 =?utf-8?B?NGJkRHRwdnFha2FZWktmTVU1RnVLaGtrY2wzdzlmalVqQXNxUHY2RWRWZ3l2?=
 =?utf-8?B?UlIwc0xEai9Vd2k2ZktzSFFzcENaYXo3ak9jdXNtdVg5WCt4ZVlRSGxqVG12?=
 =?utf-8?B?dFFjN2hFZkNIZWNHMmdsajM2QXBVVnhPN3llendsYzZqdzRpZzROZy9SZG5E?=
 =?utf-8?B?bHd3SGhGWVkvdzNXQWw2dXA3czVBQmNwMm5mb0hxZG95cFNsU0dMOGcvTXRP?=
 =?utf-8?B?T3hhbFFXbks1RERzd1RBNE5JdmhMU3BYa2xWQ0hZN1hBMFpXbnBIQVFxKzBh?=
 =?utf-8?B?ZGhtMHRCdnhUT0hUVDI0aVUxUGpDVkQvdU1tVUtleUVWM3hhd1YrNFF0Zkt3?=
 =?utf-8?B?M1BvNVpySE1NN2xUK2NXRmsxVXQ2Uy9tODZYb05weE5ydmxRKzFZdHR5bHJt?=
 =?utf-8?B?MnZHeUxsMTliY1pzVENZUnBFYm5DNVdDZEJCejU2Sm9JZUhjWVI2VVZCdGxU?=
 =?utf-8?B?SjZOMWRVczBQcnpjY0RiR3hNc0xodktMeTFMN3BTUHZwMHNiUUttRjFwR1d0?=
 =?utf-8?B?eHZ1NFdhMmd1REd6RkZ2cnpiMm5VelROTVZJMHFObjBENktmY0crOEdtdXN0?=
 =?utf-8?B?dm8rNjF4K0dvcnpXQy9wa3B6d1BMMjlxQjRIREhaVUsyNExtUHN6ak5rRHZN?=
 =?utf-8?B?Vjc3SDcxYXBrY3B0eFdDcnhIaGFVS2QyU0RXV1B3OWVRUTFtYXlMUWt0cG0w?=
 =?utf-8?Q?bsRX0yduXy3DBMTWWRJfaFuxw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e1083d9-b5a3-46f7-2c02-08dc72d0ed33
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 22:14:43.9569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HkW0enjMDpkv1rWqgfTTwrKaRlmAhTsagK/hDpA7DxdlGm1wUBPILhvQNwYzOoJ+dhCh+7YocVhnOE9MB2VxeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9406

On 5/12/2024 1:47 PM, Armin Wolf wrote:
>> Why?  Windows also does ACPI-WMI differently than Linux.  It's not as
>> easy to check both from a Windows utility due to that.
> 
> Actually, it is quite easy to check both interfaces from a Windows 
> utility. Both ACPI-WMI objects can be accessed by
> Windows applications, the utility just has to interact with an 
> additional WMI object, but they decided to not do it.
> 

Ah I didn't realize that they're actually instanciable from the WMI 
repository in an application, but that makes perfect sense with how easy 
it is to do from PowerShell.

> Also the original smbios-thermal-ctl utility was created by Dell itself 
> (i think?), so they likely would have implemented this
> if it really was necessary.
> 

It was created at a time that the ACPI WMI BIOS attributes interface 
didn't exist.  I've understood that the general direction is to use the 
WMI BIOS attributes interface in the future.

That's why I was suggesting using both, if such a transition happens 
then this driver would be ready for it.

> As Dell likely only tests their machines with Windows (if at all), i 
> propose that we try to match the Windows behavior.

I don't have a strong horse in this game, but I see what you mean in 
terms of general compatibility.