Received-SPF: pass (google.com: domain of linux-kernel+bounces-177045-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 13 May 2024 02:03:59 +0300
Message-Id: <D181I8W0OB91.2VHONX3BPMPP3@kernel.org>
Cc: <linux-integrity@vger.kernel.org>, <keyrings@vger.kernel.org>,
 <linux-security-module@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
 <trivial@kernel.org>
Subject: Re: [PATCH] integrity: Update comment for load_moklist_certs()
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Yusong Gao" <a869920004@gmail.com>, <zohar@linux.ibm.com>,
 <roberto.sassu@huawei.com>, <dmitry.kasatkin@gmail.com>,
 <eric.snowberg@oracle.com>, <paul@paul-moore.com>, <jmorris@namei.org>,
 <serge@hallyn.com>
References: <20240511032224.818418-1-a869920004@gmail.com>
In-Reply-To: <20240511032224.818418-1-a869920004@gmail.com>

On Sat May 11, 2024 at 6:22 AM EEST, Yusong Gao wrote:
> After commit 45fcd5e521cd ("integrity: add new keyring handler for
> mok keys"), the comment about load_moklist_certs() is out-of-date.
> Change keyring name from platform to machine.
>
> Signed-off-by: Yusong Gao <a869920004@gmail.com>
> ---
>  security/integrity/platform_certs/load_uefi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/int=
egrity/platform_certs/load_uefi.c
> index d1fdd113450a..e954776d3cfb 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -97,7 +97,7 @@ static __init void *get_cert_list(efi_char16_t *name, e=
fi_guid_t *guid,
>   * load_moklist_certs() - Load MokList certs
>   *
>   * Load the certs contained in the UEFI MokListRT database into the
> - * platform trusted keyring.
> + * machine keyring.
>   *
>   * This routine checks the EFI MOK config table first. If and only if
>   * that fails, this routine uses the MokListRT ordinary UEFI variable.

Alone pretty useless change to be honest. Can be fixed up when something
relevant is changed.

BR, Jarkko