Received-SPF: pass (google.com: domain of linux-kernel+bounces-177122-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <284a27be-bd63-d86c-885f-756bd2d37adc@amd.com>
Date: Mon, 13 May 2024 08:43:32 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
From: Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [RFC 4/4] perf sched schedstat: Add support for report subcommand
To: Chen Yu <yu.c.chen@intel.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
 namhyung@kernel.org, irogers@google.com, swapnil.sapkal@amd.com,
 mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org,
 rostedt@goodmis.org, vincent.guittot@linaro.org, bristot@redhat.com,
 adrian.hunter@intel.com, james.clark@arm.com, kan.liang@linux.intel.com,
 gautham.shenoy@amd.com, kprateek.nayak@amd.com, juri.lelli@redhat.com,
 yangjihong@bytedance.com, linux-kernel@vger.kernel.org,
 linux-perf-users@vger.kernel.org, santosh.shukla@amd.com,
 ananth.narayan@amd.com, sandipan.das@amd.com,
 Ravi Bangoria <ravi.bangoria@amd.com>
References: <20240508060427.417-1-ravi.bangoria@amd.com>
 <20240508060427.417-5-ravi.bangoria@amd.com> <Zj8iMV9vhyGC3tT9@chenyu5-mobl2>
Content-Language: en-US
In-Reply-To: <Zj8iMV9vhyGC3tT9@chenyu5-mobl2>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OEM4NE9xU3EzUjIvaXpUbHRRMXl0Zk9aaldoY0pWQjlaNDZYenNLTkUyMGVq?=
 =?utf-8?B?Z0I1eDQ5NDkzVTU1R3BuUGdhZnZYSVN6OFp5L3dWRWN4N3djRHJlWWgyZVBt?=
 =?utf-8?B?S082N2hEaTVWeEROWms0cVdJTXhEdks0S1VIcmpYQWsrd2xZdDJ1d1c1R0hK?=
 =?utf-8?B?TkdZL01VWDVDMXlkQWdIbmRXZTU4bTY4c0FpRzJudS9Fd0o1NEFOYmN3emZ6?=
 =?utf-8?B?cUU5UHNrZHE2WmlRNmhBN3VGTDVXaGl1UTRIZHArZ1BvOWVTN0l1SnVrVEIr?=
 =?utf-8?B?NWJSL1ZBT092clUvQkhiUHdodVByVkhqNEQ1NnhUMDBWWE0vOFh3elNUZGUr?=
 =?utf-8?B?SEpxMlJHSGZ0SmlncTR6dXI2NS9BMitEQWdrdEMzUWJGNFlWMTlDV2t4REQx?=
 =?utf-8?B?OTZOT1FQT0s3cVVldHNmQ0UrREJnZFNvQWRtYTNXZXlPZm9PY3FIazE3ZnJP?=
 =?utf-8?B?akVkb3BPR2JHMkd4N0hJM3orOGxMeFhjY3d0aGZkSkhrS3FuZnlWc3A1SzF5?=
 =?utf-8?B?Q3RBdU82Z3QzYUZaQ0JmZW1OODFvbTlSZnova3crcUE2WlBSa3MvdUNOUGR1?=
 =?utf-8?B?T29LUUo0VGVJZFhvd1E0Z3JYbHBEMnI4SHJMNmFHZTlkeFNqV0Y5cDl1dTV0?=
 =?utf-8?B?NkM4QXRsVUx0S3VYR1lXV2czSE9kMHlsN3JTSGdEL25KbkRwdDdoOFpKL2Y4?=
 =?utf-8?B?VGxhbzhxVVlZWm5mMlJkVUdpOTYyUFl1cjJEa3d6NkdnMEJHazlsWGN0Ti92?=
 =?utf-8?B?MWU1Z0hzZjM5dW8wdUFFZGdBc092NmRka3R1UytXdEtITlJXV29tS29iZElk?=
 =?utf-8?B?cEFSajluYlNWWEt2TkI4VnJlN0YzYmt0VlB5TC92S2hxalJKVWl4RHF3UHVX?=
 =?utf-8?B?TzJQRzNrVS9IRlNZYUZaZnhxZllOSWRjQ1QycmZvK1FxejQ0SVdEN01yemhp?=
 =?utf-8?B?b2Q0eTlyN1BMYVdKcjVjNHBRTWpNZjNkb0gyUnZmdDRMRW1LbC9YaTZQeDdI?=
 =?utf-8?B?b0ZHV29xN2VyOG5FMit2SHJyY24zZk9TVUI2cjRnOE9oVWZrRXJOYmx4Z21r?=
 =?utf-8?B?TVRkWVpaU3Vmdnd1R2tOcUdybjN5czFHMXl2aDB1RHNqLzFGKzVvanh3YU83?=
 =?utf-8?B?Vm5TQkxkVnNHYkdpd2QwN1NGcGRxbWVvd3pnNlVjQ2NHNWY2R3VoZG40NUJE?=
 =?utf-8?B?a3JBODE2QWZHcXkzRFdKSzdOamliWG1BWGRTdndjSTdObzV2UTMwcVZUbzVl?=
 =?utf-8?B?OTVJaDVXOTJKV0R3bURCTVVrc2gwYVdiZC9FRnJMZWtIbjVDL2FuRFdvVjdY?=
 =?utf-8?B?enYvWmJ0Uk1BaFhDR1JaN1ZRenZFb2E2SzUrVUpPdjhDK1RCWWw2dW9KZm9x?=
 =?utf-8?B?L0RqQ2pZUGY4dWkvYk1JeW5ONkRpZUN6Q0w1VnQ1ZDFRMmxMSndpeVVnQytD?=
 =?utf-8?B?ZDR2YmJUY0ZZQ0JLRHJMN2o3Y3pvUkc0Z0RyRTFvNC9uR3RsSGxlT1ZUSVo2?=
 =?utf-8?B?OVFualZOTTZXV29NblFtNk5GQlVNWUJXaTJrV0F4eStrRU5MelN3bzBtcDBB?=
 =?utf-8?B?Z0g3czRqQjIrWTRpT3pqemJvRFVVS2ZKL1FWQm5lVmxOWC9CMVF2M3BhSDFG?=
 =?utf-8?B?QlNiK2FMbmtJa2oxRXNkdXd0Z0pWRGJoY09Bdjh3aU9hUmR6NlVodHJBZExy?=
 =?utf-8?B?MmZkTXltcTZzS1BGVmRRT1o5bHZWNDJ5SUVjUDRjK1dPVE1UdEhlSnRzZTZi?=
 =?utf-8?B?VEx1VjNIRmhiQjgvTGhGa252bXo3U3dYaWNSdTJ4ZkxUTExFb2l2VVA1QUtS?=
 =?utf-8?B?c1Avak9MUGY1WnhzWnQ4Q3RMU1VHSFJJYmc4K2Zxd2VpcndqSW8zRm8veWY5?=
 =?utf-8?B?NUlYNUZDaktCaThsSWpab2RUcEpnMU9rT0tHejJkak5WNHBUbWhvTGhYSmNG?=
 =?utf-8?B?L3phbkZFZ2tXbGVsOExHNG80aHFDSHczTnZSTitCVUNmNXVWcEZRay9aR2tG?=
 =?utf-8?B?WDdaYk41anVTSGpkSDAwVGtsbTlQTFJpNkxDNG90TWtKUUFXZFZub1dLTHA0?=
 =?utf-8?B?T2ZIbXlPZ3RoMzBoRFdXU0g1THRzaHJhSTVacUd6Q2I4SzBscTRnSTNOVENU?=
 =?utf-8?Q?U7owg2fNP8djX1cHXIUYuzkQo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48eb129a-b38c-465d-b547-08dc72fab43e
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 03:13:47.2613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QZ4guOqWpMZFq4YyY1iqML7Xsmot2M/zmpFT2zXXbdlE9QzBPGUkmORFeb5qcHY8nAlZga73Y+35SkscyktBOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8293

On 11-May-24 1:15 PM, Chen Yu wrote:
> On 2024-05-08 at 11:34:27 +0530, Ravi Bangoria wrote:
>> From: Swapnil Sapkal <swapnil.sapkal@amd.com>
>>
>> `perf sched schedstat record` captures two sets of samples. For workload
>> profile, first set right before workload starts and second set after
>> workload finishes. For the systemwide profile, first set at the beginning
>> of profile and second set on receiving SIGINT signal.
>>
>> Add `perf sched schedstat report` subcommand that will read both the set
>> of samples, get the diff and render a final report. Final report prints
>> scheduler stat at cpu granularity as well as sched domain granularity.
>>
>> Usage example:
>>
>>   # perf sched schedstat record
>>   # perf sched schedstat report
>>
>> Co-developed-by: Ravi Bangoria <ravi.bangoria@amd.com>
>> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>>
> 
> I've tested it on a 240 CPUs Xeon system and it looks very useful. Thanks!

Glad you found it useful!

> 1. Just to confirm, if we want to add new fields for debugging purpose,
>    schedstat-domain-v1x.h and schedstat-cpu-v1x.h are the only files to
>    be touched, right?

Correct.

> 2. Although we can filter the output, is it applicable to only track some
>    CPUs? Like perf sched schedstat -C 4 record

Yes, adding filtering capabilities should be possible at both record and report
time.

Thanks,
Ravi