Received-SPF: pass (google.com: domain of linux-kernel+bounces-177162-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240511224035.27775-1-kris.van.hees@oracle.com> <20240511224035.27775-7-kris.van.hees@oracle.com>
In-Reply-To: <20240511224035.27775-7-kris.van.hees@oracle.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Mon, 13 May 2024 14:22:11 +0900
Message-ID: <CAK7LNATFx=iJHH=LDPOJBdYo47r5OOMKhnnzTTROedVBWZ5hzA@mail.gmail.com>
Subject: Re: [PATCH v2 6/6] module: add install target for modules.builtin.ranges
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, 
	linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, 
	Nick Alcock <nick.alcock@oracle.com>, Steven Rostedt <rostedt@goodmis.org>, 
	Luis Chamberlain <mcgrof@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, 
	Nick Desaulniers <ndesaulniers@google.com>, Jiri Olsa <olsajiri@gmail.com>, 
	Elena Zannoni <elena.zannoni@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, May 12, 2024 at 7:59=E2=80=AFAM Kris Van Hees <kris.van.hees@oracle=
com> wrote:
>
> When CONFIG_BUILTIN_MODULE_RANGES is enabled, the modules.builtin.ranges
> file should be installed in the module install location.
>
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
> ---
> Changes since v1:
>  - Renamed CONFIG_BUILTIN_RANGES to CONFIG_BUILTIN_MODULE_RANGES
> ---
>  scripts/Makefile.modinst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index b45586aa1de49..e185dacae892a 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -36,6 +36,11 @@ install-y +=3D $(addprefix $(MODLIB)/, modules.builtin=
 modules.builtin.modinfo mod
>  $(addprefix $(MODLIB)/, modules.builtin modules.builtin.modinfo modules.=
builtin.objs): $(MODLIB)/%: % FORCE
>         $(call cmd,install)
>
> +install-$(CONFIG_BUILTIN_MODULE_RANGES) +=3D $(MODLIB)/modules.builtin.r=
anges
> +
> +$(MODLIB)/modules.builtin.ranges: modules.builtin.ranges FORCE
> +       $(call cmd,install)
> +

Why add this to $(addprefix ...) part?


>  endif
>
>  modules :=3D $(call read-file, $(MODORDER))
> --
> 2.43.0
>
>


--
Best Regards
Masahiro Yamada