Received-SPF: pass (google.com: domain of linux-kernel+bounces-177184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d2f49dc7-7218-448c-aea3-d695445c80c7@intel.com>
Date: Mon, 13 May 2024 09:04:57 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations
 problem
To: Andrew Lunn <andrew@lunn.ch>
CC: "Ruinskiy, Dima" <dima.ruinskiy@intel.com>, Ricky Wu
	<en-wei.wu@canonical.com>, <netdev@vger.kernel.org>, <rickywu0421@gmail.com>,
	<linux-kernel@vger.kernel.org>, <edumazet@google.com>,
	<intel-wired-lan@lists.osuosl.org>, <kuba@kernel.org>,
	<anthony.l.nguyen@intel.com>, <pabeni@redhat.com>, <davem@davemloft.net>,
	"Lifshits, Vitaly" <vitaly.lifshits@intel.com>, naamax.meir
	<naamax.meir@linux.intel.com>, "Avivi, Amir" <amir.avivi@intel.com>, "Keller,
 Jacob E" <jacob.e.keller@intel.com>, "Lifshits, Vitaly"
	<vitaly.lifshits@intel.com>
References: <20240503101836.32755-1-en-wei.wu@canonical.com>
 <83a2c15e-12ef-4a33-a1f1-8801acb78724@lunn.ch>
 <514e990b-50c6-419b-96f2-09c3d04a2fda@intel.com>
 <334396b5-0acc-43f7-b046-30bcdab1b6fb@intel.com>
 <cc58ecfc-53f1-4154-bc38-e73964a59e16@lunn.ch>
 <b288926e-f9d6-48d5-9851-078a6c9912bf@intel.com>
 <5669c185-db96-4ac2-81d5-2198060ae77d@lunn.ch>
Content-Language: en-US
From: Sasha Neftin <sasha.neftin@intel.com>
In-Reply-To: <5669c185-db96-4ac2-81d5-2198060ae77d@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akh3ZjFGU0ZQZEFtU3lHVEpxVU9NZCt1L1U3amkveWp0YlVFMXBpTWxwMHpE?=
 =?utf-8?B?R1FZeU90Z0lXVEZLMjZienByT0ROTWhsa084cWNxd1BnSWR5QVhtcVJwOHNo?=
 =?utf-8?B?MzFiYkRncitZS05meC9GK0FrMHVPZ3JDeUtjdkI4bzBITEFHQy9nOU9oVktT?=
 =?utf-8?B?RTdjUGt0cUpxQmV1Y3pOYVl4Q2lMK3hDbTVodVJMbm14dEl0cDkwYnE0Skdx?=
 =?utf-8?B?SzZYUlhVcG1aV0pXZUhNN2YrVjRBSVBPeVB2MHYwZmR6QUhMTDVYSHBYZy9G?=
 =?utf-8?B?UEtiMDg1QmRYQkZud09MdmxEVGFyUDVnRG1lWGo3dzJzMVFnMGFYZ01Db2pG?=
 =?utf-8?B?ZXNZNjlHMWNJNUx2Nnhqbm9zMTdZbFhueU90ZDUwQ1dVZVFqdE9lMnNGWDdY?=
 =?utf-8?B?MG1JaGdlaHVLSzAvU25Nd2dzaWxGT1E2dkhzZDR2bHJ5VjBaZHZsV0JaVG9O?=
 =?utf-8?B?WDh6d0F6d0g4ZW1BWVh0Qlh6dmYxdmhhSnBOVnVMd0xJQXZ6R3Y4anpTUTlq?=
 =?utf-8?B?NEswSTdSODF1VWlZSDJYQ3NUb2hkVGRlRkhoNzZUNm1LRnU4UTZ6ZDBST0Vw?=
 =?utf-8?B?bXJRZExIZlhlS0hRRnhTNHdGVmJDTFhjcm9TaFFHOTczanNPZUdtOW90Z21L?=
 =?utf-8?B?dVc5bTV4a1YyTU8rTVFydHhzRUpYTVJOcGVVMlJScndyOUZDNHVVQkVSQ1Nv?=
 =?utf-8?B?c0ZjZ1ZNK0VPYkZYUDJEaG5wZzhjZk9NU3NpcHhQeXhaaHNCMVJIcW5oUytt?=
 =?utf-8?B?dUZHWExQckI3QXNxeXk1VW1qY0dnUTFlQmZXWUEvQ2RQRXdrTWpTNVpEUG5q?=
 =?utf-8?B?bGlqRjRVb2tnMHhTSnRTcERYY3pMdVIzaGwwdXhnMEQvYWdRYUxrTTBZemdL?=
 =?utf-8?B?d2ltVmY1cG9iZU81WGdiNWhLS3JVWitMaWhpeS82VGRIQVB1MFZzM1VVWlhV?=
 =?utf-8?B?VXRxRjBxVU9DTTdXV0tqWGFKMGdRd1JXcVRyc2Z4TEZpRTloKzdSVnZWTHVD?=
 =?utf-8?B?Y0k5b0QrVTBGaWxGcndEcndQdFVEK1dJQmJvZXVadnZqbGsvVk52STIvTHJl?=
 =?utf-8?B?c080Mlh3N0c5ckpyc2Y0MTV0eVBXTTdTc29nbVJHdjJESFpSYUgvU1Noa1ZJ?=
 =?utf-8?B?Qi9Vam1UbUgzK1Bzb3JqejY4b3k1dHExWGg3VGNaWFBzQ3hMa3BzblRqZUNM?=
 =?utf-8?B?SEplUEhXaDJtTVVkY3VGd1dRbXRSb2Z1Y2dGVUJXenhoS29HRVBiV0dweE5z?=
 =?utf-8?B?NDVFVStOcHkyZ3FFb1hHakNZYVZhdDdjeXJwbHczMG9lSVVWbWxISXZNYWc1?=
 =?utf-8?B?YWVVTUlPUVhsOTVWNy9XbTNTanhHNU1URkhDOVpjaSs2V3d2WHJOdTBtKytF?=
 =?utf-8?B?L05oeTF5bStMa2hBbG5INTFNNTN6MEs0aVlOYnhsOTBpV0U5YXZ4RG4ybG11?=
 =?utf-8?B?ajhEZDhWTE83K1ZQbFU0VldRUnI5cTkwcXVWTHJIdDhweUtnTkNCV3FXa1My?=
 =?utf-8?B?VlluUUZOY1dHZDRUcHcrTGM3MXJxVjNQUFowUjVLNVIzRWczOE9TMHhyaG82?=
 =?utf-8?B?QVlRUk10Z3E2dkQ4NE84WkMzSk01amxwYjRlVUNMb2dNcU80QlRNU0R0MUl3?=
 =?utf-8?B?THlaYWtsV0tVZS9EVlFLOFRraVhoM3pMWDZQVTJzTmpPaGExZW02UVlUdE5y?=
 =?utf-8?B?dndzcXBzb1ZTd2l4Ym9WbHEyakZiaGkwOWlNY0lhSGxudDA2V3pUekVRWHFJ?=
 =?utf-8?B?emo3MUt4YmRFQVhoRjVHd3gvbWdTemg5QVZleXBRRFlWTEZza3U4dDRiSmc5?=
 =?utf-8?B?dGgyMmJEdXZOZElBdkl0U3NNMFRFbHNEelJaQ3FuWFZqVHovV1JuVStDOWJo?=
 =?utf-8?B?Y3hnK1ZFQjAzVDlHeStLNmVHV0daa0laSndNa1RGTFgySVVSdG5IaU1sZHY3?=
 =?utf-8?B?SlNjT0lyT0dUT0xCOW84ekZUR2RBOERyWkNzQVlzZnFxTVdqWlZCcUxZdUdj?=
 =?utf-8?B?Y3RoeVB6QU1LZzR1ekZYQXNMaFc1YTNxYUttb3IrSVRqVk1mZmd0TFh3ZEpE?=
 =?utf-8?B?R0JCbDJObmxwdlVXeGs3WTVaOXRkU1NKZmRBTmhhOEdGK0x0bWNxMXllSTlL?=
 =?utf-8?Q?2Jb1ltPAG4QdKRePZ0/IEjoEL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5eea5e2b-42ed-4ce0-39c9-08dc7312a275
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6738.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 06:05:05.4861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Lb6PuIPA0WS/5pdQIPb1eLhYwnl5xioj33aEYDofTnsDEDQlolgynBR9y4t7hb1yGIlMy4n+FBQd1w71Bf+3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5259
X-OriginatorOrg: intel.com

On 10/05/2024 15:32, Andrew Lunn wrote:
>>> It would be interesting to see what the link partner sees. What does
>>> it think the I219-LM is advertising? Is it advertising 1000BaseT_Half?
>>
>> i219 parts come with LSI PHY. 1000BASE-T half-duplex is not supported.
>> 1000BASET half-duplex not advertised in IEEE 1000BASE-T Control Register 9.
> 
> That is the theory. But in practice? What does the link partner really
> see? I've come across systems which get advertisement wrong. However,
> in that case, i suspect it is the software above the PHY, not the PHY
> itself which was wrong.
> 
> 	Andrew

Not only in the theory. On the link partner IEEE 1000BASE-T Status 
Register - Address 10, Link Partner 1000BASE-T Half-Duplex Capability is 
0. (1000BAS-T HD not advertised). I believe here is some false positive 
indication during the auto-negotiation process.(this is not related to 
the link fluctuation)

Sasha