Received-SPF: pass (google.com: domain of linux-kernel+bounces-177220-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8da8c8cf-6815-4d8c-b21c-6efe3a7a4dc3@amd.com>
Date: Mon, 13 May 2024 13:45:18 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/1] iommu/amd: Fix sysfs leak in iommu init
Content-Language: en-US
To: "Kun(llfl)" <llfl@linux.alibaba.com>, Joerg Roedel <joro@8bytes.org>,
 Will Deacon <will@kernel.org>, Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <c8e0d11c6ab1ee48299c288009cf9c5dae07b42d.1715215003.git.llfl@linux.alibaba.com>
From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <c8e0d11c6ab1ee48299c288009cf9c5dae07b42d.1715215003.git.llfl@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OFAyTkJHMk9wUWd2b3gvS0RXNFc4bTUyOUVQTkZwUHNuVDZzS3dmUFQvQWY0?=
 =?utf-8?B?dmVrd3ZGSGVHamUxdW5BYXkwR1R6N0w0VXNKNFhkd0I0WDFqeWVTb09UNGdi?=
 =?utf-8?B?c0o3VlBRK01Pbjh0RkhtdjVjbW95ME1jM1dpZUhrOCs3T3EyOFIrdlExdGtL?=
 =?utf-8?B?dGhmUWlrZTdiQ3pOVmRLUitKMGcxcjBXSEk5b3RoeHkzUTVPYm1ydnd2QjlK?=
 =?utf-8?B?bEQ0YlhqTjR3WjgvcnoybnhmeXBRY3dkNVZYZXFGUjVNNDBvc2lwZjJoNjR1?=
 =?utf-8?B?Mm8wUy9VR1EzdmZNZXJYeHFMVWdJTDgxcDhEUWR6QWViN1draGl1K0Z2aVM2?=
 =?utf-8?B?Q05hSkFleW9zVzR4K3VOdTM2bGdYWEVPZ2F6bm4vL3g5R0UvTURPMnZNSTBV?=
 =?utf-8?B?cWpqL21udmZEeHIveVFLS2M4alNlMFg1OEdITmpNTTZEOUhkeGgxTElYZnlz?=
 =?utf-8?B?YnU4d1lzQ3hUT2R3WWo1QUxWRWtnQ3dCZHlQMXpLK29xWFpFcy9TMHNOdXNr?=
 =?utf-8?B?WkxLS1Awb0dZRGtnMUp0cEQ4UDVlZC83aGRHS0x4RnhlSzRoVWpvRTUvYWtP?=
 =?utf-8?B?OVdWZWVaVU9ZdFMzSGtQTUowaENoOVhXUmN5em9teHVpRzVvVis4bjhTYTBF?=
 =?utf-8?B?WHJabWVGYUlVU0ExSjJPOGNsQ3dCQ1p1V1pkSGZtR1ZkRjZ5MGN4RjExdzlJ?=
 =?utf-8?B?aUJMdk9BN3dLbW9XRXJ0aldWeHdHdVdFZlFnV3hiNGp4SUZQYVVSTzhuMksv?=
 =?utf-8?B?THhKZnZTZGRncDVwZ2h2K0tHeHV2K3JnNzg5NytlbVEyUnNOSWFaY0hzemlW?=
 =?utf-8?B?OFNzb09adnIwdXRZQXIveXo3Z2p6L1k1TituNW9OL0Qxd1RNR1NGN3FYSFlv?=
 =?utf-8?B?dUgvRmlpM2ZwampyR0g4RjhERFp3ODBrY0FaWlVZZEhMUjJ6aEJjcHlCK0Fy?=
 =?utf-8?B?UzUrYXpJREo0cXY5WVZaUUdORzh4a1h5RzVXaitmTFF0eGhMSUxDdVhvVGFT?=
 =?utf-8?B?aldxclg0cGFGZFdtV1VzZ1RGazdjbktHTVBKbkFScXRKSFRHN2xWd1hZZXlr?=
 =?utf-8?B?eEJpVjAyYm8xL2c1akIxdmtFNHVaZHhORDFDd0ZBR1JjZDRnS0ZucTZmaHhw?=
 =?utf-8?B?MW92ejExdFkwaWc0MlhMOTMwMlJoVGNmN2gzRGN6UXdNRWJyamtPc3ljY3BK?=
 =?utf-8?B?Wm5XU1JJVTFkSzFZOHlmVlloV0d2a2tOWUlpajF5a2xpcnZiODd5ZWR6dWR2?=
 =?utf-8?B?bVkrdVBsMGg3ZzB6THNiSkVDWS9MeGJTYTVhTTdFcy9vSmVvVzJoZUZwQTRL?=
 =?utf-8?B?SU9TV3B6SkZLUFplQzJkOE1sZGluc2M5aTZBZHM5aHhoWlZGRGtmQXorbzlk?=
 =?utf-8?B?bUZRRExxZG5XTno0RmhTa00wN080MjZzaC9PZUQvUHdoTm54eHNwbzhyYktO?=
 =?utf-8?B?OGNBUXJNR04ycjVmTTlRUDBMZUZES3IrZEl5Y3BaclpHTE1VNEVMbFhNcWpi?=
 =?utf-8?B?RnVITlJHODR3clVaWExHTUloVHAvMHVoeHYrZm5DRklzODEyeWV6N0NCQkkv?=
 =?utf-8?B?bUVHOVFTVyt5R0J1YlQ5aEY1aVlyMVVGZ2FsbWlEUmw2OUdVak13M083eGZo?=
 =?utf-8?B?RHhZWG9vd0pEUCs0ZlRHN04xSi9UMU1WSnN3aFFmV1JhMXlUcERxc0RzUTBE?=
 =?utf-8?B?MVhHbG1XV2c0amZHVThWNzVZZHFpRVhGVUVxc1J0WFp1Tk90NlNPb2MzNnRS?=
 =?utf-8?B?Z2FhRXpRZUtIMGdGaytkVEgvN3F6ZnVTWEgvNzdNYTh0UHVWWUdYMVZDZUtL?=
 =?utf-8?B?dURuTUhQeXA5OUU4Z1ZZMi9sMDZ2QzJ2emd5RXh0RGEyS05PaldNOERjc25r?=
 =?utf-8?B?Q2hORkJ5WWhZNC9FUWtoeGtaaU1FckJEOTRhc3ZyN2lpQ1paNFBpNDJoaVln?=
 =?utf-8?B?cVc4dHo1VTNGWm50OWVSVk5tZzhhZjRIbE44K0xMcmZEQWJoUmxsUW1mVGdh?=
 =?utf-8?B?Skh0L0xJU0Z0ejhqOXJiamttS2dJQis1MllHTGpaY2VHWDYzZUt4RG9rS2o2?=
 =?utf-8?B?OFl0YmMwL28rcG1tblM4RE1QN0tJVDJnNGt2K3MzNm81ZWk1Wi9peTJNUzA3?=
 =?utf-8?Q?LEXX8MGDVuYbEnHnxyCrCb0Xj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6090f13c-1968-4837-4794-08dc73184568
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 06:45:26.4457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fXJSIGT9g+yYSkSntEVn6m7V3xTYnrPY1t5Qrps1EKzLlLR7mgBzhNvYKQpeoDSyxMVdAPvn0ys7/nP90EuXtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7238


On 5/9/2024 7:42 AM, Kun(llfl) wrote:
> During the iommu initialization, iommu_init_pci() adds sysfs nodes.
> However, these nodes aren't remove in free_iommu_resources() subsequently.
> 
> Fixes: 39ab9555c241 ("iommu: Add sysfs bindings for struct iommu_device")
> Signed-off-by: Kun(llfl) <llfl@linux.alibaba.com>

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>