Received-SPF: pass (google.com: domain of linux-kernel+bounces-177225-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Mon, 13 May 2024 08:50:21 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Kan Liang <kan.liang@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: Makefile.perf:1149: *** Missing bpftool input for generating
 vmlinux.h. Stop.
Message-ID: <ZkG4LWr7w11wQ/PR@gmail.com>
References: <ZjssGrj+abyC6mYP@gmail.com>
 <CAP-5=fUvLiCDVDFFfJ78ng4T1FZ8j2N9Yt1sGTeGsupkbFEEug@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAP-5=fUvLiCDVDFFfJ78ng4T1FZ8j2N9Yt1sGTeGsupkbFEEug@mail.gmail.com>


* Ian Rogers <irogers@google.com> wrote:

> On Wed, May 8, 2024 at 12:39 AM Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
> > So I've been getting this perf build failure for some time:
> >
> >   kepler:~/tip/tools/perf> make clean
> >   Makefile.perf:1149: *** Missing bpftool input for generating vmlinux.h.  Stop.
> >   make: *** [Makefile:90: clean] Error 2
> >
> > ... but if I clone a new repository, it works fine, until a point.
> >
> > 'make clean' doesn't work - and 'make mrproper' in the main kernel
> > directory doesn't clean up properly.
> >
> > Only if I do a brute-force:
> >
> >         rm -rf tools/
> >         git checkout HEAD -f
> >
> > does it get resolved.
> >
> > The failure condition triggers if I Ctrl-C the following build a couple of
> > times, without it being finished:
> >
> >
> >    cd tools/perf; make clean install
> >    ...
> >
> >    LD      util/perf-in.o
> >    LD      perf-in.o
> >    CC      pmu-events/pmu-events.o
> >  ^Cmake[3]: *** [pmu-events/Build:43: pmu-events/pmu-events.o] Interrupt
> >  make[2]: *** [Makefile.perf:709: pmu-events/pmu-events-in.o] Interrupt
> >  make[1]: *** [Makefile.perf:264: sub-make] Interrupt
> >  make: *** [Makefile:113: install] Interrupt
> >  kepler:~/tip> perfi
> >  Makefile.perf:1149: *** Missing bpftool input for generating vmlinux.h.  Stop.
> >  make: *** [Makefile:90: clean] Error 2
> 
> We have a checked-in vmlinux.h:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/bpf_skel/vmlinux/vmlinux.h?h=perf-tools-next
> so this shouldn't have been a problem for a while. bpftool is no
> longer on that line:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/Makefile.perf?h=perf-tools-next#n1149
> so I suspect if you use a newer tree then things will work.

Was this regression fix propagated to v6.9 in time?

Thanks,

	Ingo