Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp1862887lqo; Sun, 12 May 2024 23:55:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUbxRma8FsEd3oyHWxXIK4ylUIzFcPVEmoOMsjbVBDnHSfd0by/pLTI8fb6pM7QfQx84fD3rSYzcQDbNiVjczKuYQ8ArbF2yJZhIma9BA== X-Google-Smtp-Source: AGHT+IEjNTpO+krfzK9ZHYr/zRUKJcNt+AltJn8XNIP4ZMfBdIgJBNGzf6tbihD3zMRc9M+3VLrF X-Received: by 2002:a05:6808:17aa:b0:3c9:6bf6:f2b6 with SMTP id 5614622812f47-3c9970b961emr10622849b6e.37.1715583328304; Sun, 12 May 2024 23:55:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715583328; cv=pass; d=google.com; s=arc-20160816; b=FWT2LXtaudEZXbslG4xViaLTm1Rv/vxM+Soz9zB9zzbMtW1BXRy/dhsYe9U0QdqJPw ysvWZn6zOxJPVt2x5phN9tyY7hDoS5RLkkFEug8duuQZqMlaRaVy5l1Si+lWfrfTTbVX 4Bmxztuf7qRcOi0VP5IH9jvb/jFW/SeuKSWdPltqDo8E5nScRbDPlWW7VvOx6NB0QVek k4p8TaIe+ow/k8ZnACJvMhmX2MuIAJ8IE8E8anJh6iOyZpAREMA7S2Bw1YF3j7/jZcr7 zXOyZhebhW61Xe3pn41xlQCAcjGnBmsbW6vtvr1CM7B7LcGzbB+FBnzHallLMRDJ0et+ 7kww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=pw8NSTdE0r3GNFTlNlIy6wLAmOCAwncteJXz8ELe+YY=; fh=N0iIUXq+nMrFTb7JA9seDP80INXzkecJvILxuRuKF7Y=; b=ss2IR3wp1f3XaHDX/w9AUivWiCMGu2e6ByafEmZUsXArk/vNeTjHOmjIykQmODImA2 c+ervbUcw+a3yGpvrzhzeWxgg+kAw5LQnW8d187eJHZLpph0Tyek2nxHiuxJ2qf64QP0 bRum3lrkmC0xAWRSDmAfitKlGnwHK327BG4RP3t/5pn0g6waoONW4i99rfimhMNvyPuS WRK49jq677iZ5LvFJfFx6CAnuJjAcINvqR0iXwDvPgEHv3hRlusFePgOs4UDzIscG0rn uHibARIaft7w+4wi/2v3VEqNf5j3LTG4YBJZ7j/2bx3vS0NCnk3igIeB8oWQz5j4o750 f2Lg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uk4tmBt7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177222-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177222-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-63413d7119bsi8629387a12.841.2024.05.12.23.55.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 May 2024 23:55:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177222-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uk4tmBt7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177222-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177222-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4E1A6281B93 for ; Mon, 13 May 2024 06:48:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8AAEC1465BD; Mon, 13 May 2024 06:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uk4tmBt7" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 919E250291; Mon, 13 May 2024 06:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715582905; cv=none; b=uqaR/a/jqpSk+t/yohynXh+6oCLuxLZFD9euXSRoFUe9JLY5RTuXCDdYTsXOqU4L76Pcmf6hfGjPCxRdwyvixPCS/gjbjMQIGGGwIhp0CyBl4B2DjiN+hYPYxM9LiOvlnCc5uV1+7f6OZO3GWrHWz3cR6h4PoVz+rSpBxkMnEHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715582905; c=relaxed/simple; bh=YMe5rjfi2aJHY/Jb4QOx03hySKCxFSlYAqn1DwApzYY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=qjEDyOjE1HCNfcil2/ENybQ3uxmGMCAuyUf/vT9Fyali+blN2buxSs80+BXOtcC7YpYskRD8smg76TyXy49B3B9sW3o12sQiCnuvsrlLG6hJDf3Bxje+AOWQRhBUOaSqSCmYdrlW73ZWtnquox1+qFWPnsK6ahu/OCO5jvtMBUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Uk4tmBt7; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52F0CC32783; Mon, 13 May 2024 06:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715582905; bh=YMe5rjfi2aJHY/Jb4QOx03hySKCxFSlYAqn1DwApzYY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Uk4tmBt71qel/8b6gDlcsnQobU3M93/uEqsvejmx/B4ZfRCrC2viGzJNvn00A/Xcw X3DWVbBwabZa18PaPN82gLqyIC+Ya4WNHszI3DtaJ+ICxO3ASO78xfVHZRHxWVRW3a Ck2Kn2djxDlcY+b9hr82/48ZBrqhpXOzrfJfYSEjqAA9B/MkA01zhuMXKNGXDfMrfM Y4YGRYOFQghPG1Pm6zDjj+MmX2cQhCkvrVdrMO4Lwke+MOIO0tl6pQowAYfAvVKB8U +rBbGOcfG3rBrTOlBToTEiLR0V/iKofG8EXaApXrIISXDLfG/hXRQQeQkfMoUi1HA1 5s0f4orUUAoXQ== Message-ID: Date: Mon, 13 May 2024 08:48:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 3/6] dt-bindings: PCI: qcom: Document the IPQ9574 PCIe controller. To: devi priya , bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20240512082858.1806694-1-quic_devipriy@quicinc.com> <20240512082858.1806694-4-quic_devipriy@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240512082858.1806694-4-quic_devipriy@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/05/2024 10:28, devi priya wrote: > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-ipq9574 > + then: > + properties: > + clocks: > + minItems: 6 > + maxItems: 6 > + clock-names: > + items: > + - const: ahb # AHB clock > + - const: aux # Auxiliary clock > + - const: axi_m # AXI Master clock > + - const: axi_s # AXI Slave clock > + - const: axi_bridge # AXI bridge clock > + - const: rchng That's introducing one more order of clocks... Please keep it consistent. The only existing case with ahb has it at after axi_m and others. Why making things everytime differently? I also to propose to finally drop the obvious comments, like "AHB clock". It cannot be anything else. AXI Master / slave are descriptive, so should stay. Best regards, Krzysztof