Received-SPF: pass (google.com: domain of linux-kernel+bounces-177255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ce1e1097-2e7d-475b-ac17-3b84aec473e2@linux.intel.com>
Date: Mon, 13 May 2024 09:25:45 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/i915: Correct error handler
To: Jiasheng Jiang <jiashengjiangcool@outlook.com>,
 jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
 rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com,
 daniel@ffwll.ch, chris@chris-wilson.co.uk
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <BYAPR03MB41680146FAD88A8F26C3827BADE02@BYAPR03MB4168.namprd03.prod.outlook.com>
Content-Language: en-US
From: Nirmoy Das <nirmoy.das@linux.intel.com>
In-Reply-To: <BYAPR03MB41680146FAD88A8F26C3827BADE02@BYAPR03MB4168.namprd03.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 5/11/2024 5:48 PM, Jiasheng Jiang wrote:
> Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak.

Nice catch. I would make the subject more like:

drm/i915: Fix memory leak by correcting cache object name in error handler

>
> Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")

Also need Cc: <stable@vger.kernel.org> # v5.2+

With those:

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>


Nirmoy

> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@outlook.com>
> ---
>   drivers/gpu/drm/i915/i915_scheduler.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
> index 762127dd56c5..70a854557e6e 100644
> --- a/drivers/gpu/drm/i915/i915_scheduler.c
> +++ b/drivers/gpu/drm/i915/i915_scheduler.c
> @@ -506,6 +506,6 @@ int __init i915_scheduler_module_init(void)
>   	return 0;
>   
>   err_priorities:
> -	kmem_cache_destroy(slab_priorities);
> +	kmem_cache_destroy(slab_dependencies);
>   	return -ENOMEM;
>   }