Received-SPF: pass (google.com: domain of linux-kernel+bounces-177310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Liu Ying <victor.liu@nxp.com>
To: dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: andrzej.hajda@intel.com,
	neil.armstrong@linaro.org,
	rfoss@kernel.org,
	Laurent.pinchart@ideasonboard.com,
	jonas@kwiboo.se,
	jernej.skrabec@gmail.com,
	maarten.lankhorst@linux.intel.com,
	mripard@kernel.org,
	tzimmermann@suse.de,
	airlied@gmail.com,
	daniel@ffwll.ch,
	dmitry.baryshkov@linaro.org,
	biju.das.jz@bp.renesas.com,
	aford173@gmail.com,
	bli@bang-olufsen.dk,
	robh@kernel.org,
	jani.nikula@intel.com
Subject: [PATCH] drm/bridge: adv7511: Attach next bridge without creating connector
Date: Mon, 13 May 2024 16:02:43 +0800
Message-Id: <20240513080243.3952292-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?us-ascii?Q?9vbjX+KB1y8vdH9wCtz0PQZVF5mTGEoLMx8SQs8QTtCVNTy8ynyFXqeAVVMF?=
 =?us-ascii?Q?tW8uhNV2jHc/pGKXQBAiH7jZ065/5jlr5DQmM02j+oHKOafhoAj7s8CUfvVG?=
 =?us-ascii?Q?qlyLPupcbFk4HqSh3hdXPNH3LpzMBkfm1bkHwqdzDmMHlEmUJ5UDQAAa9BvT?=
 =?us-ascii?Q?AG0Mh0E0g/63G1hr4mfz/ppPO8wTHTn8EfI64DNczCXb0McK0OOa4CwG9sLy?=
 =?us-ascii?Q?MFmF5FyAOq6ccQWDnHdvNd/G3q54W3+AOXWIKrwsTjv1aNWWKDXE2PnC+j5K?=
 =?us-ascii?Q?yvKaRfNU2Wp4ilil0ymp8nqcm0tDJAZGhgeRdXLdCBAiye8WaEvj6OCUyAiP?=
 =?us-ascii?Q?iT/KYH9gc37mmyIcd4RulO0qklWNgJhMnX6UYBx9QFmsadAhI2gxfl3A8iMK?=
 =?us-ascii?Q?Gd05kijgdwmNZvsvv7n3Y4ymnG54UpCRgRBgJn4qqQABMLZvIVuz7MQgUuDe?=
 =?us-ascii?Q?9xplJDMyMGkD+73BVErM6QCp6PKsZB9Mdhje9aqBCF94UDZ7VpsAHTw38J99?=
 =?us-ascii?Q?m8S6EqqkZz5H49zyx8w1qVrFxcNg2gLFv4FVXIEylgoIWvzX1fL5+Ha8JeJr?=
 =?us-ascii?Q?qSiDwG+n9HDRVld7/EFGlqSj3fSw9cxqZthlbpH2Cu+gx1S6NXypxl4FRNwX?=
 =?us-ascii?Q?8cP4IxCZCxAxf9SFsxkI/KWChf41RPqk5UN8Bzi/5R9v5s6ajPMP44Fr4sWs?=
 =?us-ascii?Q?VW6zW8vSFri2IuDr6hfIH1bZPcsWLyOG5w54H27lJbkKWU0bQcyo7MLIehPH?=
 =?us-ascii?Q?se7+xCsTZEuZem2BqQHJbZtsQw8yoNwyVO44v2zOwxiiv6eTxUrrByDpA1o9?=
 =?us-ascii?Q?RpAgcrdJ5XdcZHrLYbid2rDS85cXZZ4hjM1n15hnMHdhQvWTkn3/nKGDohee?=
 =?us-ascii?Q?QTdBKc5TFj8rJeEdIUxAYxahyYse/KFAccfne2EXqLGMHo3J7pRElqQBfZCt?=
 =?us-ascii?Q?16sepomYz9dYMOalJQ4GjJMT0yhlsW3qkyQmRoe8EnEp0EHTSWtMZvjhoI83?=
 =?us-ascii?Q?f0doDvEP6j/Nxblm+Gl3X9uQw16oAQHHHUknAbFYmT4qS6bBnigbrnMHc3zB?=
 =?us-ascii?Q?b/iuTg4FKnQQf2lJ7DFH5Bl43I+/AERk4g479jLkooH8Dk6NSvvf82NGMXeM?=
 =?us-ascii?Q?A6tLHWyYxNXXewQDxPvWV0YqEZS56L+Q8L14CsB2j7ITBBHhlC1UGKhxTIMq?=
 =?us-ascii?Q?2lD/r70lNUPRi0WZJBDjGeJ33YRdDAqzjMEHnzPZtylcwdv0JWmJq1jZeVO2?=
 =?us-ascii?Q?MTCHIIt8/kLcr9WAIEYEBCuZKNYKJOmdVbbQRRdY3iQq8ml5xjHCupcSWyha?=
 =?us-ascii?Q?4NpcaEZBmA2jRSbawOqHiWAwmWch9or240spTFg4JGdG40Ivz8igat3eR2bp?=
 =?us-ascii?Q?1HShEMHOHwa9lHMwgmnRGe27pO5KZVIV+h40axvW4OKqpq6C6gthwMaHrU4q?=
 =?us-ascii?Q?hrfFPkv/OoUqcT7NzYKFgoKpNKTJoyZRnGJ+4F5tarhXrdn8gjJr1IGk+Oxa?=
 =?us-ascii?Q?crgk4IxVQU4iUdLcwQfwWr//oKKyYfNyaCEYMNsLGFCJHVWDeShOg3Xb26fA?=
 =?us-ascii?Q?yE1fmfDDNlfftZuP1sDuOVRXH/WICzD6V0YN5ZWL?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 714afeda-1190-4b58-4581-08dc7322030c
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 07:55:09.9051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nKW4QlNd1iG1D/V5NyD0ACcZjvqokHsNGhD67HB8bkBDRmM1NaizEUu0hQ04v1KZaX1n8TgnGKk7tYzhHipphg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7149

The connector is created by either this ADV7511 bridge driver or
any DRM device driver/previous bridge driver, so this ADV7511
bridge driver should not let the next bridge driver create connector.

If the next bridge is a HDMI connector, the next bridge driver
would fail to attach bridge from display_connector_attach() without
the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag.

Add that flag to drm_bridge_attach() function call in
adv7511_bridge_attach() to fix the issue.

This fixes the issue where the HDMI connector bridge fails to attach
to the previous ADV7535 bridge on i.MX8MP EVK platform:

[    2.216442] [drm:drm_bridge_attach] *ERROR* failed to attach bridge /hdmi-connector to encoder None-37: -22
[    2.220675] mmc1: SDHCI controller on 30b50000.mmc [30b50000.mmc] using ADMA
[    2.226262] [drm:drm_bridge_attach] *ERROR* failed to attach bridge /soc@0/bus@30800000/i2c@30a30000/hdmi@3d to encoder None-37: -22
[    2.245204] [drm:drm_bridge_attach] *ERROR* failed to attach bridge /soc@0/bus@32c00000/dsi@32e60000 to encoder None-37: -22
[    2.256445] imx-lcdif 32e80000.display-controller: error -EINVAL: Failed to attach bridge for endpoint0
[    2.265850] imx-lcdif 32e80000.display-controller: error -EINVAL: Cannot connect bridge
[    2.274009] imx-lcdif 32e80000.display-controller: probe with driver imx-lcdif failed with error -22

Fixes: 14b3cdbd0e5b ("drm/bridge: adv7511: make it honour next bridge in DT")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index dd21b81bd28f..66ccb61e2a66 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -953,7 +953,8 @@ static int adv7511_bridge_attach(struct drm_bridge *bridge,
 	int ret = 0;
 
 	if (adv->next_bridge) {
-		ret = drm_bridge_attach(bridge->encoder, adv->next_bridge, bridge, flags);
+		ret = drm_bridge_attach(bridge->encoder, adv->next_bridge, bridge,
+					flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
 		if (ret)
 			return ret;
 	}
-- 
2.34.1