Received-SPF: pass (google.com: domain of linux-kernel+bounces-177333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8f599fc9-99f4-462b-838d-6da2fb19fa10@intel.com>
Date: Mon, 13 May 2024 10:14:44 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dpll: fix return value check for kmemdup
Content-Language: en-US
To: Chen Ni <nichen@iscas.ac.cn>, <vadim.fedorenko@linux.dev>,
	<arkadiusz.kubalewski@intel.com>, <jiri@resnulli.us>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<davem@davemloft.net>, <jan.glaza@intel.com>
References: <20240513032824.2410459-1-nichen@iscas.ac.cn>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240513032824.2410459-1-nichen@iscas.ac.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1VYRXhrOWgyWHB1WXFqaFpoNjJXVGlWZVhVdnZvMlVCbzljcUJ3WnZFRW9O?=
 =?utf-8?B?OU9nc1RDbFBWZ3ZtaFVWZEwrekVHbGpRVmo5ZUhhWFB1dUtRdTU0RzFXanJC?=
 =?utf-8?B?aUM4UlpjVHcrdHp3WkJQUmU5eWtDYzhtS3lhMVhYTURIQTRwb00wcVM1L1pw?=
 =?utf-8?B?REhBeXdRNEhvcTd3WERVSzRMT0RLMFNJeVBBcUNzMm5xQi9ObTkvWldkYWk4?=
 =?utf-8?B?N2tWWUFWS0pzTmFQMDgyMDlzRHJYYXBpNVczRkxyOS9yZk9pdXJ6MG5XSEpj?=
 =?utf-8?B?SWVPVXkyOXFKUFNJR2swNjBBQzJVaHNyRWFqenJ6enZhOGhLN2t2QjRuT2pK?=
 =?utf-8?B?YUpYOUN4MlRRTW1PRmRyM2VudWc2cC9SUjMvcmFHZ05tT0JoY3NyUUJCZE9O?=
 =?utf-8?B?a0FhakdOZlVESkxKbXdGTm1IcVg1d2xrK1JDbTFqRDNEQjhnODNRTklEKzFy?=
 =?utf-8?B?OStmRGp2TXlOaFhyRWszeXBiSHFPN1dCaWFNM3dDYjFQcmZYZ3hwSTdnR00r?=
 =?utf-8?B?WmZrTEFTU1hhK1hZaVhPbjF4ZXM0NHdRdUdyY1BLb3VGMmFJd1NQcjZyMTk0?=
 =?utf-8?B?c3BDK3QwenhOb0kweElZMzBUdER0ZDIrRjBReENlR3MrVS9jL24rY0hYRDF3?=
 =?utf-8?B?ZlZJUGdwTmJ6WW15ZGk1dDZBNUx2L2pEazh6MGJBbUMycDRpM3hKV0lCRG42?=
 =?utf-8?B?VmlIRmFjVWxoVlgzeXcydXdqNldIQXY2MDRBVmltVXZ1QTNDSkx5b0phZStC?=
 =?utf-8?B?MktPWW9KY3VVU1RRRXRpQndEcDA3SHU3NTU0MmtJdFZpZnR1dHVWQVhjZ1JU?=
 =?utf-8?B?VXViOXhPVE9XYStJakk2OXVZM255MnBaTUoyL205SnZwVGY4cFZkRXR3dmM3?=
 =?utf-8?B?SjNTOFdoNHRXc0VyblIzUzcvbzg1Q1FFK2RHZ0RKTHVhNUV5YlZJeTVYZnRH?=
 =?utf-8?B?Q2R4ZllwWk9LOEFEUzlOKzBoaXluOGo4UVdoVWYzaXkxYlNqVVA2UXRxKzRt?=
 =?utf-8?B?NFZoYWRhcVVHNEhmcFN3bWh0dW1OWUpVZjMxZ2JlM2pKVDgvcWZmaEd4SU1H?=
 =?utf-8?B?eW9wNEYzOENDb1pNU3dYUXMzcXVaQkJKbWFPQllwRjN6UHBLV0ZuNHRldnow?=
 =?utf-8?B?M051S1N5eUU2RXlxcUpvMkE2Tkg5VUkxR3lpajhOUzNOYkNpaC8zMnFkeGlG?=
 =?utf-8?B?TFgxcHVsUzJ4WklZTnlQZklyMFk2WUEwYnprWVNockgzL0x0eWJnc0ZyUkFS?=
 =?utf-8?B?RTVpcXJsc3hjRUIvWTRLN1BNZnE4Zk1yZUlTeVhlcXgzQjZDS01uSGpsTm16?=
 =?utf-8?B?d0dJVXhqREVPeUhMMlBLdURuZUxXWDdZODVqSUxCOUtHSU41UFZqUUNXWWln?=
 =?utf-8?B?UzM0NFVXR0pjcnlYQWRubC95SmhIWlQ4dHBsTlFDcy9hSWNUcjdnbmxRaUNZ?=
 =?utf-8?B?SHVDRnBWV3MyUy9hMXE1aFljaUlMVENOTGQ4aXEzeDZIb2ZVVUF6WWZzM0xV?=
 =?utf-8?B?R0dYL0ZSL0dMTUpkT0hIamJYcW1JTWlNcm1QS21jeVcydGpYTzhlT0xsU1Ir?=
 =?utf-8?B?QmkyVU4rMGNrSEZjbmlRcjJxTHlZOEJSQ29CSEZsV25uakNSeWxHWXZML202?=
 =?utf-8?B?TWJwQkVRVDhkZldXdUNra1dpZlBlM1JFOWVIaExqeDhtVXhWT3pRSkRXdTVp?=
 =?utf-8?B?STI4cXJFM2NXZWpyK2NjQ211K0FHK1lsM1RucGJtOEpPNXJyamtBRjJQTkE2?=
 =?utf-8?B?OTQ1R2EzN2pSdWFXM1Q5VmdFY29MYXVMMHNmYWNkcTZqdE83ZDNGVGw5OWc2?=
 =?utf-8?B?MndkLzNaaDlackY3L2ZJMTVwZWlERlMwRU4yU2hqc2Q0MFVlZWZvMmtNV2V0?=
 =?utf-8?B?VE04ckp3U1lyUStLQm5xcUZzemdHRjhqdFlzUmdid3ZKT05KUktXT21QSStX?=
 =?utf-8?B?c2dMd3FTRE5MeElDQnkxbXFJbFFaRlduVnJ1a0hMQTU2bWt6VTVGR1greVFE?=
 =?utf-8?B?R0EvNzdqNDFtMlNIckRMYzdDOUdPOCtYWi8vUnBNQjhkdStZLzhUQ250bWUw?=
 =?utf-8?B?ZVBYU082Ri84cWNyZmh4R1pLbHJnVlNOZVJCV2NPZGRCM0hFTlhkZlphRWVi?=
 =?utf-8?B?eW05VUtKcmFrc3Z6WURGUytLQmRIUEtDOW5wamJWY1FnUlpSTDhMU0V4TXkr?=
 =?utf-8?B?L1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 53f89f17-a84d-4346-84c5-08dc7324c293
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 08:14:50.2326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dWSrXlzLjPvThiQrEffVsju9N4YMR865yFWin1D2uMsCeuUHOay8NuPZvZxxo+GYTDNK14b7yV6/0JJ/RVBXTFRtRt8hVOEEE7CqumhYo4k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4811
X-OriginatorOrg: intel.com

On 5/13/24 05:28, Chen Ni wrote:
> The return value of kmemdup() is dst->freq_supported, not
> src->freq_supported. Update the check accordingly.
> 
> Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   drivers/dpll/dpll_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
> index d0f6693ca142..32019dc33cca 100644
> --- a/drivers/dpll/dpll_core.c
> +++ b/drivers/dpll/dpll_core.c
> @@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src,
>   				   sizeof(*src->freq_supported);
>   		dst->freq_supported = kmemdup(src->freq_supported,
>   					      freq_size, GFP_KERNEL);
> -		if (!src->freq_supported)
> +		if (!dst->freq_supported)
>   			return -ENOMEM;
>   	}
>   	if (src->board_label) {

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>