Received-SPF: pass (google.com: domain of linux-kernel+bounces-177335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
To: Chen Ni <nichen@iscas.ac.cn>, "vadim.fedorenko@linux.dev"
	<vadim.fedorenko@linux.dev>, "jiri@resnulli.us" <jiri@resnulli.us>,
	"davem@davemloft.net" <davem@davemloft.net>, "Glaza, Jan"
	<jan.glaza@intel.com>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dpll: fix return value check for kmemdup
Thread-Topic: [PATCH] dpll: fix return value check for kmemdup
Thread-Index: AQHapOWsatwUWu0/UE+e+JAtWgclcLGU0SgQ
Date: Mon, 13 May 2024 08:16:18 +0000
Message-ID: <DM6PR11MB46575EB151D97B15ED9AC92B9BE22@DM6PR11MB4657.namprd11.prod.outlook.com>
References: <20240513032824.2410459-1-nichen@iscas.ac.cn>
In-Reply-To: <20240513032824.2410459-1-nichen@iscas.ac.cn>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g+DJRphO5SsyHzAkHQ7o+Jscx3LcCsujiyCIG4lhUErZxW/u9iK1JEZ8NxwF?=
 =?us-ascii?Q?etPfbY0FUqmocIeyxTDzT6TuNHBR+Brtl29uQIweDLDaOKOrnDw42OaULuOV?=
 =?us-ascii?Q?H86zmMCbXTybik4uMUIaicAGOzdWNjRTPniDvO9hSFmO0V8BL50YvyEYDIzb?=
 =?us-ascii?Q?qCkCZDtAmwKdwY6fP5TEN28KxJO8RJHpbHgVoQ4tEGi2SDhTcjO5uqhTHhr9?=
 =?us-ascii?Q?/3KHLsYgh18U1MJO+qraazHs/Qi5OCy+SDASAqPpXx8dAt/QLt5K6/Ne3uoV?=
 =?us-ascii?Q?caLCsuCqqo5dMD3bbTTJE8gBLGTUy87sDqQvMWeHOGwUgawqNIqFYKq22SgB?=
 =?us-ascii?Q?O+NL5+7IY+ZByHkL1SrEz55lKBuPY84PzcJMS4lmyQZr56xitHb3Sz2rQih3?=
 =?us-ascii?Q?cZ9l7tNBlDw3rZycSJ5gAyLXecUlhqudtBjodFM2+HWl/gYti0iKXe5DPFy3?=
 =?us-ascii?Q?BfoAt30l+KOqhmG+lk6x/27Z0mkX1hFx/T2+Fuzqpra6ArJ36I4CggotGNAF?=
 =?us-ascii?Q?Xmxd1UGha5barqSjpUZq/FkusMGiIU3NUe51ESrO2puwrO1bE6JupUJf2CGQ?=
 =?us-ascii?Q?ZMRTYCXqrVKcxtOxes840BY6jlT3ZvTbehc8DFYxNLdUZYg0DGx6AgzzE6O3?=
 =?us-ascii?Q?jLbc5cOzvX82fm4QJf1fQAqPoUpSrpQXrBmMRVP9QRNxsUZGS13reH8hbRnv?=
 =?us-ascii?Q?WrqKXuErZ22xDpHhc2vVtFCo6l1VYmpppR4+6mDTHGiIpe/JSheX1z0+r0OU?=
 =?us-ascii?Q?HMhhTTZXYfKdLW3DFt6QFL6L11FcYCxRYQr3fhJMkT4SYx5/2Vm0gGyYZ+ij?=
 =?us-ascii?Q?364ezPOt5VNBOQvbHAzBOYNWixpLd2bvihipHAxxEDH6ohq1NwUafYgv2HJu?=
 =?us-ascii?Q?K9dCXvSrENurRhlbf8ICOG+j7PWnfgYWRy4I4p8vb6I9CZfSugOcpxZ1zsp4?=
 =?us-ascii?Q?B3atHM/sf0gO/rRKdOIOpsBwVtf7+Y3+zweRVBXZoxbJc1P47yD5G5IfjUmd?=
 =?us-ascii?Q?rEXSYc7DfMbADw56xNd4ArvqwM8oVsGAa0nG2u6aOOC0A259GWvgyQyoxeFd?=
 =?us-ascii?Q?MmIaK8Hf2yOwtswBdBrBv6iIrt8h046q/On2GTT3fn9FrN2IWjVQnM2b5kq6?=
 =?us-ascii?Q?YEnRgNoVeK0sigxmEj/TQfMOXletoAWEI9CKSnKY3ZrtFa3iLLmf0ftpxY9D?=
 =?us-ascii?Q?g6+e/rMhblB6D9+v31bixpnls71U1wd60M4+otfaKr/G1euvL8qXbyR4Luez?=
 =?us-ascii?Q?25rKmUXfkqqrheBkKThbV0GxDOWV3HvLZ/4Ztfhlmliagqk/GMhXmwkXJXfJ?=
 =?us-ascii?Q?2UbFodSaL31NYbI3bA445/Bmq38sMi0R+bLXE1d2h7LeKz4jtmdMzyNoSSxg?=
 =?us-ascii?Q?uRapSxrTtSgCiW5uq0R287wSifR/K/sIjH/Hw9Fs6Wr0RWFANue3QaT6p/qx?=
 =?us-ascii?Q?B1uy24oo3rMpnV0B/bE5fymi7Q7TxahqlDuIEVOFhbwpLqoT5Y+QaBuxoY5Y?=
 =?us-ascii?Q?lzkskK78RncLhxUjQp/xnAQcPMiM//0JgkdARdL+26hw7zMM961YbvjnDLkK?=
 =?us-ascii?Q?c0T+aY7E306DVdFSEApzMyTwKYuYFvYw1O/LocjcWvxLzpLQXEdp5miYcGZw?=
 =?us-ascii?Q?pg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b740de38-8760-437a-dfbb-08dc7324f77c
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 08:16:18.7702
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tIohtdZeRlTOm0w2Nfbrx7xX9gpbNxhxGlyQvFgAd/P7akca5vbATHOb1KIoeQqGUqlQYiMFweNIQ46ZCU/Dd2LDDAQ+nVqFdTyK9RSYx2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8029
X-OriginatorOrg: intel.com

>From: Chen Ni <nichen@iscas.ac.cn>
>Sent: Monday, May 13, 2024 5:28 AM
>
>The return value of kmemdup() is dst->freq_supported, not
>src->freq_supported. Update the check accordingly.
>
>Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
>Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>---
> drivers/dpll/dpll_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
>index d0f6693ca142..32019dc33cca 100644
>--- a/drivers/dpll/dpll_core.c
>+++ b/drivers/dpll/dpll_core.c
>@@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct
>dpll_pin_properties *src,
> 				   sizeof(*src->freq_supported);
> 		dst->freq_supported =3D kmemdup(src->freq_supported,
> 					      freq_size, GFP_KERNEL);
>-		if (!src->freq_supported)
>+		if (!dst->freq_supported)
> 			return -ENOMEM;
> 	}
> 	if (src->board_label) {
>--
>2.25.1

LGTM, Thanks!

Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>