Received-SPF: pass (google.com: domain of linux-kernel+bounces-177338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 13 May 2024 10:19:33 +0200
From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Mark Brown <broonie@kernel.org>, lgirdwood@gmail.com
Subject: Re: [PATCH AUTOSEL 6.1 02/25] regulator: irq_helpers: duplicate IRQ
 name
Message-ID: <ZkHNFQwvzjNJbYt4@duo.ucw.cz>
References: <20240507231231.394219-1-sashal@kernel.org>
 <20240507231231.394219-2-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Pngi36OMD6etkkKN"
Content-Disposition: inline
In-Reply-To: <20240507231231.394219-2-sashal@kernel.org>


--Pngi36OMD6etkkKN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> The regulator IRQ helper requires caller to provide pointer to IRQ name
> which is kept in memory by caller. All other data passed to the helper
> in the regulator_irq_desc structure is copied. This can cause some
> confusion and unnecessary complexity.
>=20
> Make the regulator_irq_helper() to copy also the provided IRQ name
> information so caller can discard the name after the call to
> regulator_irq_helper() completes.

Does this fix a bug in 6.1? It looks like preparation...

Best regards,
							Pavel

> +++ b/drivers/regulator/irq_helpers.c
> @@ -352,6 +352,9 @@ void *regulator_irq_helper(struct device *dev,
> =20
>  	h->irq =3D irq;
>  	h->desc =3D *d;
> +	h->desc.name =3D devm_kstrdup(dev, d->name, GFP_KERNEL);
> +	if (!h->desc.name)
> +		return ERR_PTR(-ENOMEM);
> =20
>  	ret =3D init_rdev_state(dev, h, rdev, common_errs, per_rdev_errs,
>  			      rdev_amount);

--=20
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--Pngi36OMD6etkkKN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZkHNFQAKCRAw5/Bqldv6
8o5JAKCCJNW14FaI7QbNsLT2VGfLpxAXFwCgk3a2Dpxc5/rJXJSnY66H3P0wCfk=
=UwWD
-----END PGP SIGNATURE-----

--Pngi36OMD6etkkKN--