Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp1907904lqo; Mon, 13 May 2024 01:56:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVznLp2AAMze+KfT8XHgj9iUedPu066x8yxzfCwOi44C/1C4sa2Ozqe4Qy4fkJLa1LUPx6i6zfrLVs+zH6GuE0DHFvBppDrcI5m9BXK/Q== X-Google-Smtp-Source: AGHT+IElCYU0moHMb7dOngRq2oPSwHxO+nIHiTYqN+w2JeW3YwPy1PTW0q6oHHGM98340UiapaK4 X-Received: by 2002:a17:906:370f:b0:a59:a83b:d438 with SMTP id a640c23a62f3a-a5a2d5c89a3mr555456766b.23.1715590583938; Mon, 13 May 2024 01:56:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715590582; cv=pass; d=google.com; s=arc-20160816; b=h5yGv+vFMLh88xEWRKuIyo0rZ5wuKx2gmbnqD3h7I1Etp9exAoL0TSJmlGfURBzfYy rkcxTj0mFCPluFwdNR0gDzya00sf4pB80Zwqj0HMbQWIxZI2zq0d1YPZT9n0DQVfcOve WivvQS12e+bdtTufJh+CI2qL5RQ1rT5e8DUwWMvmNVw8nWZrRN26fP+SPosCJUOGcjdg FjeK5h3Vh74UK9YI8Qs9pfA56wt9iSfuMLfucbyzKdWU42ZZJRtm4XRQG9hXtvVTTl0W /6D55vt1xUG+CBdALhApE4JBxDOI4QHHOwcbeytprDdKN1L5eKdH7ktTXaMfrAjeq0mC yTgg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ZVgnAhf7mtm8J9Z9AUD+3eXKHZVcTgNyUjiO04JfAEo=; fh=ThwnSWr+2Xe5rgDSCxOl5kDREGFTMQytp3CzS0ikxQc=; b=ZwiKCwmdrUWzyDZVMJwqenI5kzfjrI/4X3b6sVh5jwKSYM2COgAgc6SCokXCy7+YR1 HGl2rm3WcgUP0iLagAU/AQNLKLBwtDmn6joZR8+7e844qTtRF+D6xzL1wlHvvOH9VP4Q Z0iesqnAnbG9jN/OeOyNDN1eiM1Tt2mZP60mY4E+AEVk2YUP1yJwvZRNBpRr5f1ibFJj 0JZY53AF6+ZrPYKP3jeLlc8OYQCFjaAuDqrMN9r21IJ7wL5tx0G+7s01wYqfNu31lY3v eArL+j1s1mE5EaLsLnoCFoMO9/X8xTKaa8cxE15DQ400Bm01onS3H5U+1lFelpVcecjX 3iqw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=For2Uvzn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177369-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177369-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17ba2e59si503587666b.513.2024.05.13.01.56.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 01:56:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177369-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=For2Uvzn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177369-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177369-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A40AB1F20F91 for ; Mon, 13 May 2024 08:56:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 93A451487CC; Mon, 13 May 2024 08:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="For2Uvzn" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACC2B14830E; Mon, 13 May 2024 08:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715590575; cv=none; b=pFjc/zMDzjevTUUsp07U7Hha8gTsAyhfZzeslQeHky0vuEWsnG90wOy0yB8arY6B38XAwOqugKKL4rjiFI6YTuwMcuTpxMrI+RFjPRCIchYxxaJ0KomCUFGU3fvNKYY2lWzT4u5gpARw0j2FDiusNYb+aRjoat9z+pLuuLn3Aoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715590575; c=relaxed/simple; bh=ZVgnAhf7mtm8J9Z9AUD+3eXKHZVcTgNyUjiO04JfAEo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=euuayUtT0UJiZNepNAMcPIvjXY5EeOh+eAI/U8kJJd3T/V29+1JIFCjka/dXHSKQZgLgjZShvf4PlOXJT29uWkK+TCQGZG34rRv4coa1ZvLBAECKclgU0wbFdP3HGicniJR+n8cevoCBORRqLzwexhhw8hrGC0siyE0Gks8IMqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=For2Uvzn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34E14C2BD11; Mon, 13 May 2024 08:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715590575; bh=ZVgnAhf7mtm8J9Z9AUD+3eXKHZVcTgNyUjiO04JfAEo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=For2Uvzn6W7HsSZv10gOcoBy0Tc73BVSONx+icRWHSOE0kgv7VuUVVcoMgYUbudPh URxT07SFNNbZiix9gdxmrcmdc87o/0fGs1Kg3tRNhbnNx28kXqXB2TNSSwT7l4tIwM gwWNX1ftv/aEqT6W9+7JdHce0FJuQaK0AxlMkv9gdvCQkDrqjOePEZZbpW/5wRB118 knUCfg9d37+0QEN3ckh9q4DRRZ8kv65JG5zwGrtYv7O6oSOE/LKlSMXzi9aEPhemYI fYz4aREtW3aLQk6YdCXMOZnu8TMgnYmEMlEjTFbkQ8D7NKwpkZ0v0DGyWEmei6X/sK jeURUhYL9VUYg== Message-ID: <829162d0-2fef-4bbc-9417-13e8ca96150c@kernel.org> Date: Mon, 13 May 2024 10:56:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Move some common usb node settings to SoC dtsi To: Tengfei Fan , andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20240513084701.1658826-1-quic_tengfan@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240513084701.1658826-1-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/05/2024 10:47, Tengfei Fan wrote: > All the board dts which base on SM8550 SoC dtsi refer to usb_1_dwc3_ss, > usb_dp_qmpphy_usb_ss_in, orientation-switch and usb-role-switch, so move > them to SoC dtsi from board dts. That's not really a good argument. Argument is that it is a SoC property (vs being a property of a board). Provide rationale for that. You are moving things just because they look common, so to me it looks really unjustified. > OTG is default for dr_mode, so it can be dropped from board dts. Separate patch, see submitting patches. Best regards, Krzysztof