Received-SPF: pass (google.com: domain of linux-kernel+bounces-177412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c3275383-9b3c-41b2-a65f-2df50fefafb5@amd.com>
Date: Mon, 13 May 2024 15:06:58 +0530
User-Agent: Mozilla Thunderbird
From: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Subject: Re: [PATCH v2 10/10] cpufreq: amd-pstate: automatically load pstate
 driver by default
To: Perry Yuan <perry.yuan@amd.com>, Mario.Limonciello@amd.com,
 gautham.shenoy@amd.com, Ray.Huang@amd.com, Borislav.Petkov@amd.com
Cc: rafael.j.wysocki@intel.com, Alexander.Deucher@amd.com,
 Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
 linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1715356532.git.perry.yuan@amd.com>
 <9b31fbcdfd4e4f00c3302f45e655aa43589b224c.1715356532.git.perry.yuan@amd.com>
Content-Language: en-US
In-Reply-To: <9b31fbcdfd4e4f00c3302f45e655aa43589b224c.1715356532.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Rm94YmlDNEhRbXJOTXptNkVrQWgwZzIybjNrN1dtZkdMZjNpc2lPcERNTjYx?=
 =?utf-8?B?OUQ3NEtqenhUQVdRdTJaWVFGVnBLQTN4VDRBYmU5R1E1Qkg2VXZsWWFTZVpD?=
 =?utf-8?B?QjlRWEV0SEVhclNPS1N4RkhTbnI5bTI5M04vUDVjeGlDVUdSSDlLeUlBS0Ux?=
 =?utf-8?B?R2QvcHJsME1nSVB1UCtFZEFib0dFYjVpMHE3VGJSaXF1R3FHdDczY0NXQTV6?=
 =?utf-8?B?QU56TmkwVTk1Y1pPUWNUaHQwQWVOcEl5YVExcUI2RXpzdUhvMFhWUDM0UTNB?=
 =?utf-8?B?V0ZjSmZIRys1TGdSZis4WDhQanlySGtCU0RqV20vbjBHckNaaXBxaGhIb2M2?=
 =?utf-8?B?SzJ4UjZ5UjRvTk40NHozZjdVd0l4aGRDbWxFaUkvVk9JQlUxdDJQSjMyeDNa?=
 =?utf-8?B?VXA4Uk9TM2V4eXIwMVhHWmVYYUw0TWlLRmtYUXk2VDFhSGJvYjQ2NjNKRGc5?=
 =?utf-8?B?bi9STW5NSXhESklqRkhybTVGbnVsWmZDY0o1ZEJiSHVBbW53dzNjRTA0TGhv?=
 =?utf-8?B?SGNYQms5SXBQbnIvdHJWd1JMdmFZTXI5ck10eXpSbUV2a3lQQUJXM2J4MXVI?=
 =?utf-8?B?ODNZRGgvK1N3dDQ2T0hBdWVvZUZsVC9GUnl2MXNHQVV6VG45NlRBZlJMR1Ir?=
 =?utf-8?B?VWE3UUZzVWo2SzdKdHRLZ2pwU0FWQ3o4M3FJNUZxMXp2Z0Rrb3ptWlRpV1Nv?=
 =?utf-8?B?UHEvQWFKTGV1SVVRY0ZFR0lDdVlINUZRTmcwVGJ4RW9nY2diejh4NFZqaUZB?=
 =?utf-8?B?QjNXd29uNU5DbUEvZ1oxMzBLclQ0SWN6eExQWEdHZ21BTHZiQU5qSEJjc2ND?=
 =?utf-8?B?S2JMNVZRdkhoeWdJN05mOFkxS1ZHZHdVQ2pOUGw2dG12eW56RS80R0RiOTNT?=
 =?utf-8?B?UmZob09uRTRJekcvbkxSb0JLaDgyakZidFZHdHJSUjg2b09YRUhPeGI1WDcv?=
 =?utf-8?B?VlRFWG9WTTA2UzhrV2hlVzArclYrV2ZNT2l5QXlWOEhadnA3Yml1eXVjNk9B?=
 =?utf-8?B?RmQ4anl0QUNhQk1HUkFyRHQ3YkZMN0hOTUZtaTcrbzFFbDN3STluMGZjSGVh?=
 =?utf-8?B?ZTg3S0RYcXkwOEdhS3EvUjQ2VlYvQjRPYmtuZkEyejFPdmxhalB4dGpGU2kw?=
 =?utf-8?B?S3pGOTJlV3FQT3RqQS9wWjA1cVQ4Qk9nTjVzMXFZTjNTVm9FemMwNFNFdk5X?=
 =?utf-8?B?ZUdUaDBoRGlJT0hoZDFobVYxcHpoYytjVmVMNWxZUjROOFVtaHZ0YzVaOUJM?=
 =?utf-8?B?MnB4TFhidW1NSWNBaWFuRVcyTGdqd2UxSnZuTWo0YTNKUGgzZHhKTG0vOTJk?=
 =?utf-8?B?ckt5WllMR1R4clhJSWdKVWwxKzFLclFldTNvN3Y1Qmt1ZmM2cmdtUEJqTUEv?=
 =?utf-8?B?RzBIZDVLTHBISGtDbnZ6SnVRRjM2SURmYWM0M1ZJWFR0OGJZbGlhUFFYVXdT?=
 =?utf-8?B?cXcxdzUvWGFwVUdKUzdXY3NaeXlUUGRkcE9JZkpOUHFQRHNCbHZLYW5rQ2ZP?=
 =?utf-8?B?QkhqRkpFRFNJVWpJeDJYTWRlMyt3dDVkR2FoWFNmLy8vUkF2NEZQeThxbEYv?=
 =?utf-8?B?eGhCU2JzRWdIZDdhQldOQUkwaUJ4VHNFNlZCTWpwbEdpNjNobGkvZkh1OHQv?=
 =?utf-8?B?eStOYjNEVnkxWGordkM0NkNaTktUUVlreU4wY3JTWlNURGtac1lHR0pVcElW?=
 =?utf-8?B?SElJNEFyQkNQNVFSN2h4V3lEaWxRYTRQcXZHUHgvK3haUndHNnNLTW93R2pB?=
 =?utf-8?B?cVVCVUwxdWJkc2p5cjNJaXVFRmxzZWxybitESmQ5dFluSEdRODZJdHVDUjhZ?=
 =?utf-8?B?eWdZa1Y0aS9UU1Y4cFhERUYzYmcyMGVocGlTQ3d2TnZDTUNyZXdhcE1ncEVy?=
 =?utf-8?B?bkFGTFpwN3NaU3F4WjFKdU5UYTAwNVZMTlErekptWU5MdzhWeVJEd0RiN0Ji?=
 =?utf-8?B?Y0pyc1BveWR1SnJyNk1HMWxNcisvbk5rK0dzTGFhMlk4WUZjUWl3S0VIOENh?=
 =?utf-8?B?QzkvOTR0Z0FnbEh6VkU2S20xeUtQWmdtRmdPMDFXMk5YaytSWm1TMlJQSlBI?=
 =?utf-8?B?WVZ5MkkyRnhMSzJ5RDJFRXUva24xbno0VmgrUUJZY3hUL1dwSXNldktJeVNl?=
 =?utf-8?Q?WqO1+kCDgtyxnqxROKKHsy5kl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50fae4c1-3125-4529-a2ea-08dc73304185
X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9207.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 09:37:07.9402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8rAG4bxgs1fVKgwGhaBrH5w1MxEvUk80iT0PEAwrP5HvGmC2z+HDfoVfzgfSLyxVrikWKK0OYmamPb5Yz6juew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6388

Hello Perry,

On 5/13/2024 7:37 AM, Perry Yuan wrote:
> If the `amd-pstate` driver is not loaded automatically by default,
> it is because the kernel command line parameter has not been added.
> To resolve this issue, it is necessary to call the `amd_pstate_set_driver()`
> function to enable the desired mode (passive/active/guided) before registering
> the driver instance.
> This ensures that the driver is loaded correctly without relying on the kernel
> command line parameter.
> 
> [    0.917789] usb usb6: Manufacturer: Linux 6.9.0-rc6-amd-pstate-new-fix-v1 xhci-hcd
> [    0.982579] amd_pstate: failed to register with return -22
> 
> Reported-by: Andrei Amuraritei <andamu@posteo.net>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218705
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 36 +++++++++++++++++++-----------------
>  1 file changed, 19 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index dce901a403c9..03342fef7d94 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1785,28 +1785,30 @@ static int __init amd_pstate_init(void)
>  	/* check if this machine need CPPC quirks */
>  	dmi_check_system(amd_pstate_quirks_table);
>  
> +	/* get default driver mode for loading */
> +	if (cppc_state == AMD_PSTATE_UNDEFINED)
> +		cppc_state = CONFIG_X86_AMD_PSTATE_DEFAULT_MODE;
> +
> +	/* Disable on the following configs by default:
> +	 * 1. Undefined platforms
> +	 * 2. Server platforms
> +	 */
> +	if (amd_pstate_acpi_pm_profile_undefined() ||
> +		amd_pstate_acpi_pm_profile_server()) {
> +		pr_info("driver load is disabled for server or undefined platform\n");
> +		return -ENODEV;
> +	}
> +

Wont this change make it impossible to use amd-pstate on server platforms? It wont work
even if we pass "amd-pstate=active" in cmdline, because this check is before the switch
case.

Thanks,
Dhananjay

>  	switch (cppc_state) {
> -	case AMD_PSTATE_UNDEFINED:
> -		/* Disable on the following configs by default:
> -		 * 1. Undefined platforms
> -		 * 2. Server platforms
> -		 * 3. Shared memory designs
> -		 */
> -		if (amd_pstate_acpi_pm_profile_undefined() ||
> -		    amd_pstate_acpi_pm_profile_server() ||
> -		    !cpu_feature_enabled(X86_FEATURE_CPPC)) {
> -			pr_info("driver load is disabled, boot with specific mode to enable this\n");
> -			return -ENODEV;
> -		}
> -		ret = amd_pstate_set_driver(CONFIG_X86_AMD_PSTATE_DEFAULT_MODE);
> -		if (ret)
> -			return ret;
> -		break;
>  	case AMD_PSTATE_DISABLE:
> +		pr_info("driver load is disabled, boot with specific mode to enable this\n");
>  		return -ENODEV;
>  	case AMD_PSTATE_PASSIVE:
>  	case AMD_PSTATE_ACTIVE:
>  	case AMD_PSTATE_GUIDED:
> +		ret = amd_pstate_set_driver(cppc_state);
> +		if (ret)
> +			return ret;
>  		break;
>  	default:
>  		return -EINVAL;
> @@ -1827,7 +1829,7 @@ static int __init amd_pstate_init(void)
>  	/* enable amd pstate feature */
>  	ret = amd_pstate_enable(true);
>  	if (ret) {
> -		pr_err("failed to enable with return %d\n", ret);
> +		pr_err("failed to enable driver mode(%d)\n", cppc_state);
>  		return ret;
>  	}
>