Received-SPF: pass (google.com: domain of linux-kernel+bounces-177450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Geethasowjanya Akula <gakula@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com"
	<pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil
 Kovvuri Goutham <sgoutham@marvell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v4 02/10] octeontx2-pf: RVU
 representor driver
Thread-Topic: [EXTERNAL] Re: [net-next PATCH v4 02/10] octeontx2-pf: RVU
 representor driver
Thread-Index: AQHaoJ0p8kX/ixOuL0m51COcvSl7QrGP1NgAgAUp/vA=
Date: Mon, 13 May 2024 10:28:39 +0000
Message-ID: 
 <CH0PR18MB433924F5DCB7AF630F3EF770CDE22@CH0PR18MB4339.namprd18.prod.outlook.com>
References: <20240507163921.29683-1-gakula@marvell.com>
	<20240507163921.29683-3-gakula@marvell.com>
 <20240509203500.706e446e@kernel.org>
In-Reply-To: <20240509203500.706e446e@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?2EJwxBcxteBnj17ByP1s8HYdkDveC3ctcJk8KokwqqH8hoga80dO8MbZ7m2Z?=
 =?us-ascii?Q?607GH7tMltlYvdzsvokuUKMjvQc9FjYXPBLNEyWM8pJGCN3K4R5h+xR8+kih?=
 =?us-ascii?Q?rOQ4ZnfmRJdTxEzK5nGyjI36/HcVwFO+ZYDeIvDsYPiDrhkPJ7hre8t4XWVr?=
 =?us-ascii?Q?61Jt3BaHCamYVNNceZrM0CMj/sEmIVQqQ+TrHJYLu7hzlE9qKk33nMnYmW9n?=
 =?us-ascii?Q?yYv0quE4OvxTKccQpgiZ36C7xp4eoNEDWKBWW3XMZr5/ybakGdiyUQMBkNDd?=
 =?us-ascii?Q?Vwe84Fs8e25UY2ZDusCUXVc5ubYURlfbJO5ZadKMcLMtTh8Acf4J3xcuZ9rr?=
 =?us-ascii?Q?122yAo/J5eZ8h4rktYMTT0vdlwT5UxnBoSL7tThJNUOxKiBpn6UeK6R+GsLk?=
 =?us-ascii?Q?3i63Kn2WKQhrgXxlJSqazqeFvDD9/+Q4VdQ5fkmgKTDimr6syPr02bmlml3O?=
 =?us-ascii?Q?j0Slqr/0c1zeUsIAvYaKJCjhA1m03/bvHrZYXIDvnArLSM7OMfjhjvLosbbM?=
 =?us-ascii?Q?N72EHpAfObBrGFV5uJS78s+ejuCmCAjNRqPpKSoz72GTwkKwqxgrb8fnSfPb?=
 =?us-ascii?Q?idANMIpXR5mr0tSd5sWlY1Q6sp+oanmDPQaJ4csdPUL3ppGxVP7DluAHFCnm?=
 =?us-ascii?Q?b9rUXXLaLXhpQbGAch+bSNWluGAuzZFhrB5wAML7G8rZAwLhLwSIvJKT2kY3?=
 =?us-ascii?Q?xrkQLyAID/PBcj8Sxv/60aWNi/xAtL9HIiM4DzHP+I7WZLWdmwmbwiHMfY9Q?=
 =?us-ascii?Q?L9PcOjyIJahAqyHe7XTtlB0TaZyJtHSpksLz5SPttu2CDhVIh5HFKV0s/d1s?=
 =?us-ascii?Q?bvWWcAyPMfdU85xOcux2PTAge/4IwF+s+qRonqv/XvGXZzifolmqkfP7PS+w?=
 =?us-ascii?Q?ki+j4SJlE3XZ0NgY7Hms+rfH/C6J1yuSP0fq0RGCdqnIOy8NiBAPIPPYGbez?=
 =?us-ascii?Q?FRUHWJAy8KcJSSYiFFpSgvgOmj+1s61z5jjlobwRFvfzib/g3R2J8U0a6TTW?=
 =?us-ascii?Q?/QJwhQIeLwFiEq2TM2kB9ZFU85F0xV39ZPDJmh5NkeSQ0rJJs5fW8FYwuLt1?=
 =?us-ascii?Q?dO7mNWgUug3k9nLwdx5X8eQB3dmOp5XQNzByvLSjUWLUM537zwiKe9DXmcNz?=
 =?us-ascii?Q?aLf6yh+J+1qFto2VL3uYqsXaStKMmYwE0IZbh6MauIbi5GgekHrnFVG0fP0H?=
 =?us-ascii?Q?m7KljhrsvrFhlHXBWxDGBFWW22f5I1b7lQiFUIy+KuXIj06JwS6yksw6gARU?=
 =?us-ascii?Q?ASEoR5s80JMN5assPJjSrqFpZlFqY7RU8GbqlVSBiN7NiTb1lbwuN8/Oikep?=
 =?us-ascii?Q?ZPLRPToHu5ToVYQJxBpKS9TD6W6cX+v3mPSClwCL1N6ucDGk6hGTPskxQSGW?=
 =?us-ascii?Q?e7MXdBrvpf4rrsr9tqhuBty0Zm8S0klQFUZ8GArNV5rv/VJ6YVXJVlS3gBWc?=
 =?us-ascii?Q?aU/tNDsrayEKRHXHyeUvF2t3Ji7wpJorU/FQfON5YQMudHHhzQvxWIxuqGyK?=
 =?us-ascii?Q?nEGPU+BDsDKueZWp2fT7spYyfJPooLd+ZOUM8wI5nIs1TPg4xre6lffJ37JS?=
 =?us-ascii?Q?LzW8LMIUhNKzSz86Q8w=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR18MB4339.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f461e81a-0843-4c9e-a313-08dc73377480
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 10:28:39.4479
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Bwrhqb6qzmVd4sNKqWbdpVLO+73yewToGpIX4nlE88hfg78UgJFk/Q+M1Xa/yaOy1lMdasNOkOwCgXDltktlvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR18MB5082
X-Proofpoint-ORIG-GUID: AC4pneFGjCJYCHXr2oiFDU6eOAeW8tVu
X-Proofpoint-GUID: AC4pneFGjCJYCHXr2oiFDU6eOAeW8tVu
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-13_07,2024-05-10_02,2023-05-22_02


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Friday, May 10, 2024 9:05 AM
> To: Geethasowjanya Akula <gakula@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>
> Subject: [EXTERNAL] Re: [net-next PATCH v4 02/10] octeontx2-pf: RVU
> representor driver
> ----------------------------------------------------------------------
> On Tue, 7 May 2024 22:09:13 +0530 Geetha sowjanya wrote:
> > This patch adds basic driver for the RVU representor.
> > Driver on probe does pci specific initialization and does hw resources
> > configuration.
> > Introduces RVU_ESWITCH kernel config to enable/disable this driver.
> > Representor and NIC shares the code but representors netdev support
> > subset of NIC functionality. Hence "otx2_rep_dev"
> > api helps to skip the features initialization that are not supported
> > by the representors.
>=20
> It's quite unusual to have a separate PCI device for representors.
> Why not extend the existing PF driver?
> This driver spawns no netdevs by default?

Sorry.. strangely this email went into spam folder, and I didn't check till=
 now.

Our's is a multi-PF device and each of the PF has it's own VFs.
And in HW, packet parser identifies pkts sent or received by each of these =
PF/VFs by a unique PF_FUNC (15-11bits PF & 10-0bits PFs' VF).
If representor netdev is registered from a separate PF (ie a separate PF_FU=
NC) then at packet parser it's easy to install pkt forwarding rules.
eg: representee <=3D> representor