Received-SPF: pass (google.com: domain of linux-kernel+bounces-177455-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Geethasowjanya Akula <gakula@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com"
	<pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil
 Kovvuri Goutham <sgoutham@marvell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v4 03/10] octeontx2-pf: Create
 representor netdev
Thread-Topic: [EXTERNAL] Re: [net-next PATCH v4 03/10] octeontx2-pf: Create
 representor netdev
Thread-Index: AQHaoJ0n31dqKn1PqEi4BSrztzCWvrGP0u0AgAUtwVA=
Date: Mon, 13 May 2024 10:35:53 +0000
Message-ID: 
 <CH0PR18MB4339EF84925BFC6ABEEB69DDCDE22@CH0PR18MB4339.namprd18.prod.outlook.com>
References: <20240507163921.29683-1-gakula@marvell.com>
	<20240507163921.29683-4-gakula@marvell.com>
 <20240509202808.26e960a7@kernel.org>
In-Reply-To: <20240509202808.26e960a7@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?WqxfyNWLvrwS0aSxOnUc5zHIjlz3JKONR9KbPjWBlELdPHs4X+XMdMzq11AA?=
 =?us-ascii?Q?bnmQwUmFzBkRtWRHxaSaXZUPlqskcbkHn1JaSy+jwnLL/5aD5sqhrhP1r5ex?=
 =?us-ascii?Q?+8K+8rXz4gHKSgzsSsZbwcL0j+dwVQutba57PSqSu3Nl2OSt+PB+oGOn61hp?=
 =?us-ascii?Q?aAGf9JGJbl1CexCbwKxwjCZ+ptB7lXrpwfTsKxkiLlvgWT48vOaZPmPj5Bqu?=
 =?us-ascii?Q?AsZFhqjiTEaMTheyi0O/ps+3WSpas5M5ChPjTB8ZnttP/48c3uOMecZSt2ZY?=
 =?us-ascii?Q?hvQwk+ux/Q3l/yibn/407xIu+vbpFZoZ9F99GcUoHMYld6j3ez94BVcUkLKg?=
 =?us-ascii?Q?d2ELDRw0aodLRySIGlsegSQpjvBZrkZ+GT2icVG5IE35H98QtRyqcsM1Drqq?=
 =?us-ascii?Q?PiRzasIxXWZpmbU11DoRInBJ50uZXHP0tLpECHvRoeqx7ylMbFiyc/jCPEhL?=
 =?us-ascii?Q?SS3Q24tKwYNunhHUilYXod4WCIiry+JAMk3qJpD8Mxns3grOT/u2Tx91Y2Wk?=
 =?us-ascii?Q?EIoTOht4pjLxDfw1cUKMAHs2SssprtHeSoM9rz1s2BPNyg5bnewqQW0vh4zU?=
 =?us-ascii?Q?ai8sdZ3VN2gN6OIPrU8YD6T6uzWrfT/WtfUO5G4GTs6dPUDEiSo+4vzB1gvX?=
 =?us-ascii?Q?m2IFT7eEoaQm+sEap7syOAMxh5gJPnGFPSZ1KvtEQpqQsYco8n7tJ1aq7HZf?=
 =?us-ascii?Q?E0PG357fvnPSW49SgVCJjm7649q58jKzmKJCMmE8DM0giWOQYywWhFryU8qz?=
 =?us-ascii?Q?O+cowOWxJccpSsH9qSg/K5W7YgoN7j+gGVmxl6NYt1waBIvF5usOZA/xTCaK?=
 =?us-ascii?Q?fMzbaKEO4y6xC6bTqj2EiuF3N3cB/FFy9+5AQe8KuwYZQleRWKCIHpeijg7i?=
 =?us-ascii?Q?UsQITlJUegYyhWmchYJysaa4sYqyf21mTSHu8FUqoAN2S52Qut71EXIx64UM?=
 =?us-ascii?Q?eXN/kgANT/g6vlbDuh7ePMY7IOppsluMTFrwBEvdveGmKCFF4tPA7R4PefPi?=
 =?us-ascii?Q?Y09psjeZd9mThkoOIJNuYdb+5f6ETtxjNxzhK3UNtwhHIFGt1DjCdjkqJUJS?=
 =?us-ascii?Q?3gCZgvq/8yD/EapP9oC1FwpeYpP0Kid39yTF1IS4G1ntTCg7BGpPYmcewwC2?=
 =?us-ascii?Q?9k1hq6xKMiwocJUnKJE1uM2F6DLVaRogJHBkGoS9a8PdDqMMZPObvVf2ZNPW?=
 =?us-ascii?Q?w84v9KxWElH8dcHrCjqS3S+yfQRB6xl66UNAS4btXQrMt7aXO+D/CBTTwco1?=
 =?us-ascii?Q?TddQivjTWhkyFJAIp16g1w/+UqjDD8Nl+Kf3EA1b/pi56cy37TYaP70t0ZVD?=
 =?us-ascii?Q?cd8iviH2Gu2xIxUSX92GMjjQJerKeOm3G66V5t0GLq9pDJ3Urx2SJH5BgrKW?=
 =?us-ascii?Q?vzHSnmua05QgNT1gYa4FnDVIvZ2BC8RieHPJ1DPx/4z//ajbfaJ1OWxWCW1A?=
 =?us-ascii?Q?+nOqR08JIz4uaFJbnmt+DtPPpTs+/jM1pfT6KV8SHU6R2G8fKK0rs68xmO32?=
 =?us-ascii?Q?dWwo8lEhLKxj1NFvvES+tpcF978gKjLQS1lw+ppszUqzdyIrDEefvvodp0A3?=
 =?us-ascii?Q?wXKr+562RNgBtHXoN1o=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR18MB4339.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5897df9-7125-4911-cb9d-08dc73387713
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 10:35:53.2773
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gAgsjuv/X6W1ZpvCo3y0XUz/M6yH5BIbS5Z2Zqp+yA1PhgknqQ2u5paeD+b5Mo/MifRVJF1qDERT751+aSG+5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR18MB5082
X-Proofpoint-GUID: xvtyoyAspJYekUIYkSE9-n0AMxme-EVj
X-Proofpoint-ORIG-GUID: xvtyoyAspJYekUIYkSE9-n0AMxme-EVj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-13_07,2024-05-10_02,2023-05-22_02


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Friday, May 10, 2024 8:58 AM
> To: Geethasowjanya Akula <gakula@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>
> Subject: [EXTERNAL] Re: [net-next PATCH v4 03/10] octeontx2-pf: Create
> representor netdev>=20
> ----------------------------------------------------------------------
> On Tue, 7 May 2024 22:09:14 +0530 Geetha sowjanya wrote:
> > +	priv->reps =3D devm_kcalloc(priv->dev, rep_cnt, sizeof(struct rep_dev=
 *),
> > +				  GFP_KERNEL);
> > +	if (!priv->reps)
> > +		return -ENOMEM;
>=20
> using devm_ here is pointless, the objects are not tied to the lifetime o=
f the
> device (there can be created multiple times) and you have to unregister t=
he
> netdevs manually, anyway.
Will fix it next version.