Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp1952830lqo; Mon, 13 May 2024 03:44:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWpOaTCvtU3z8T/JjPtD5/7tQOdADCfsQttO3VeAWJN+NEJWnFqMcr9aX6ZcYn7xpxDx0sCaQmMc7wvmSV6p/THbX1Vlk0pg0D+arH7Hg== X-Google-Smtp-Source: AGHT+IGIUuDMhdclZJsaURwoHYfjyzojU06sEr1mJc1DMuitgU2lULCfRpabw7SsQzXwTusxe4dl X-Received: by 2002:a05:6a20:394b:b0:1a7:8dd9:5fd3 with SMTP id adf61e73a8af0-1afd144bf6cmr20564624637.18.1715597052349; Mon, 13 May 2024 03:44:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715597052; cv=pass; d=google.com; s=arc-20160816; b=Z34H3UZtAHrhEoTPI0g/aslE5nlNjVIvqmDwyvIkkLOg0f7bW1ykckjjEGqzkGPzia 8liUeU5m4XYnUWNWqBpjxnZ56WBEWQMyF/1q6Aq/4rgxYYHq7w8peV/FL5bQiW3X4XUY eFxeE+oyC7JlerIhDmQaUziLGenrC/iZBtq5n91ImorGmXktbpeIK8uLPIqRu7JIzx3q M2C+PitPrYFkW/REHBQZJZBiMzMHO1CsA4cQtZhzdy4RIE3qAP36vChY7lP2YS8gYM6E HrPzK2f/NhA4DyvO2VTVqW+AAHYh/C3W9ncO3ZQAbl1nUxjYcK2PGfzYvk1KIUEJJ6hC c1CQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=kgfeP1jsxGHRa71MsV3zu+aSPMEIzGKDnJov89ARRPE=; fh=bZP16W1hRR84S+JXlu4Nlf+YwpjYeHUqJhqaokG19CU=; b=0u/4s4E3OPYCf0MM7uDZnWJVmMRpcdIdYAfc+B1XAs/zs95qWUkDCHGGRdknVs0Ipi CFq4Mookt2Ik9DwT1T4s/xiUCk0OxtgWP8/N9uxqi7OwPFgBkR7gobJ2DfxS+9fxoaIQ 85dA2ieR11pOVblAqLUnWFE61ebBnRWKiVO2YAl+HMXs0g4Y7Rj+x2DQJoZPvRfez+jw WuqDfnysvxpd2/+gEi1C5dFuNiHR+nPJ9YyZj0Feayca1wew+OKzZFX/JHRBzb04kLzT PeFMmce5UHx9DVRS+6nUhjQC9gILya1d6iRowwe/t9d+rfsZTwRAUX3FRo5GMSIrdUWu UqDw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-kernel+bounces-177456-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177456-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-63412c36a04si9012230a12.763.2024.05.13.03.44.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 03:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177456-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-kernel+bounces-177456-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177456-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 72D3FB21F48 for ; Mon, 13 May 2024 10:38:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B894B1465BC; Mon, 13 May 2024 10:37:54 +0000 (UTC) Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2203E31A67 for ; Mon, 13 May 2024 10:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715596674; cv=none; b=EOKY7oQsUNeYT06LxElJlzduQSFBd43d57/957UidKqlGELHaxerpjRlKmKukwJWDvcSZ+WNORoyVKX8qw0ShE4tkM1ACVRgOEA6Z+cGV19lowwAEzlsXjKN2UiVFfRSczA2NSD9/xu8OOXq9s1d9qgNv5HWIL9UFYbYNNnSvHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715596674; c=relaxed/simple; bh=bDn8OyW4sG4kceNzTwND2nLqSNDXzbk6gIp12v3wzt0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DuuoHDNlr5WW6yTEUkU/G/jk+zdiBCvJnFCzv1chDLhFJ4O7WLndtGvnaeek2iYzu9KV+SbApvx6JsR3HGDJhTYKRk2GVCehaSnnl2f9sGAFojXvYodiRfA49QNzexg/E7jkvkNYsM+a8/X5DTcAp3RKFy+2efXQdehhfl+PxqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from abreu.molgen.mpg.de (g34.guest.molgen.mpg.de [141.14.220.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 7B18161E5FE01; Mon, 13 May 2024 12:36:59 +0200 (CEST) From: Paul Menzel To: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Daniel Vetter Cc: Paul Menzel , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915/fbc: Add sizes to info message about reducing fb size Date: Mon, 13 May 2024 12:36:51 +0200 Message-ID: <20240513103652.371721-1-pmenzel@molgen.mpg.de> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The info message currently does not contain any information, how much the stolen memory size should be increased. [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS. To be more useful to the user, add the sizes to the message. Signed-off-by: Paul Menzel --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index b453fcbd67da..e4a5d251013f 100644 --- a/drivers/gpu/drm/i915/display/intel_fbc.c +++ b/drivers/gpu/drm/i915/display/intel_fbc.c @@ -801,7 +801,8 @@ static int intel_fbc_alloc_cfb(struct intel_fbc *fbc, goto err_llb; else if (ret > min_limit) drm_info_once(&i915->drm, - "Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n"); + "Reducing the compressed framebuffer size from %d bytes to %d bytes. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n", + min_limit, ret); fbc->limit = ret; -- 2.43.0