Received-SPF: pass (google.com: domain of linux-kernel+bounces-177464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Geethasowjanya Akula <gakula@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham
	<sgoutham@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v4 03/10] octeontx2-pf: Create
 representor netdev
Thread-Topic: [EXTERNAL] Re: [net-next PATCH v4 03/10] octeontx2-pf: Create
 representor netdev
Thread-Index: AQHaoJ0n31dqKn1PqEi4BSrztzCWvrGSGMIAgALpFRA=
Date: Mon, 13 May 2024 10:38:46 +0000
Message-ID: 
 <CH0PR18MB433916E129849A20259D4568CDE22@CH0PR18MB4339.namprd18.prod.outlook.com>
References: <20240507163921.29683-1-gakula@marvell.com>
 <20240507163921.29683-4-gakula@marvell.com>
 <20240511141036.GG2347895@kernel.org>
In-Reply-To: <20240511141036.GG2347895@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?ifodmtVBwL7UlG3vYlOIpFbucMIqHuIL+ys2kQ5oj7o9sKxbRY32PO4b3Nx9?=
 =?us-ascii?Q?+68y3kPYfSNQ2XvlnJQYoPHyFIt2VnPOyhIm2w/AeIra8YxjEtEiD6Z1AsIP?=
 =?us-ascii?Q?w/imlZpjuW7T37H6v096LgLqw8w7COl7cp+55zCO2EfyvjArybFtl45l2VJu?=
 =?us-ascii?Q?s21IeP4rqr4bGUky+Yeaxt4djIEyrq97Xj1NnB98MSl7+6HbvnFANKmMXcDz?=
 =?us-ascii?Q?8fMpClABo7kR0LTvAUQVC055OpZGNP/+WJCRjhii3D7k7H6iVkVf9w5oPUIA?=
 =?us-ascii?Q?HlTeOybcDtRCfxuLyIplUDUJ9Z6r+SnkAlIJwmMjtqbrZzmy3AqN23wTAkEc?=
 =?us-ascii?Q?3k2ulXyWQsiJA3Ki2up+++3ZWNPXsJFg3U5TEkz7R5nxbRUutNyfe8DwnsZJ?=
 =?us-ascii?Q?RHk/OcuB9gxM8aVxQbgnKCE5KIwKlcdHfo/oQC1+nHMijhSVH7mBN/hkr1pZ?=
 =?us-ascii?Q?a6XveJNiOvyFJ1Labgri28RNgbv8iSubZxWj4uuhTkXo/PrmhIzI5sulLHj1?=
 =?us-ascii?Q?ofh2i/DlTJ6VKlIdymVvxiiVMGdkw2SO84GZ8NK+luRbKgUEzK8dTDA5LcHO?=
 =?us-ascii?Q?jWOJorv7X7ntZA3nVvsZnLRQgaedu26jM8N4q0dmGvX/9DCvX3sTw9c647GL?=
 =?us-ascii?Q?fczKvE8erlQNXt32kZY/n+WtVsJQJ8LQ1/ViXm8EUdTniXPgAOHzYgnPLuov?=
 =?us-ascii?Q?gBnXpeI/51ZWKdCl/SdPF8FovYNvQVlgFgxIt97PLlxf1RF5ygrQwl+WA4D+?=
 =?us-ascii?Q?4vFVUU+1ymj4uysBO2QRUI240U3eXSb/Rmt4qweo4gpsYkeWy8gEcVrr2MFc?=
 =?us-ascii?Q?CnLvwbqJDjW7ocb/dSROYYFoYrqkPVM4VjLJ1FPqH9gFI3DlCCantIfJ0gih?=
 =?us-ascii?Q?oLsb2tmBUPfMcIF7yqcrbRkieSbbKokLY1EiZd9+xNlEAOUVJD/fHoFeU1nK?=
 =?us-ascii?Q?pD1DKNY1f8aqoERq3jSex7XQy/eim4fCVmdpfpaV9MF/WKcPcS8lC5Qeqscp?=
 =?us-ascii?Q?iY2+oYek7qEhcTmYsGtyKRpgYLPSPW89BVrBEY6QbseNk0MJhMeaxWCT73Ph?=
 =?us-ascii?Q?y3zgef54dlWMcNWjszEU88QUI6175PlVuW0CysM27bTx9gmXZKED9dNbtUnw?=
 =?us-ascii?Q?aI7nFDL2aiMwPJCIEc5K7IFXIgPoa3PLn7c3BcCRIKyf+QMASEB2anhCVq+7?=
 =?us-ascii?Q?cX+uBUDEKS5KgRV71pBQHQ2ZL/qksY+ucFi720GI4W/Hf6Mohtl6zxmv2P7M?=
 =?us-ascii?Q?xkbvqCyKUJvgX0lXGoRxFFfWPYNylEL3MvIVeMoSpWTlsvYIVDNAgSU1bye1?=
 =?us-ascii?Q?N6My03WEYPDR0hzGeHI0aAcdWZbLSsPNHucYn4HeqnKObl09AwrDeZJIYBH8?=
 =?us-ascii?Q?P/Qe6slNvquTDddI882HNAR6Y7oVaWEAClB1hp5ARcEfKw2mAWuNCGbs6LK/?=
 =?us-ascii?Q?Qb6Y50eKICqfWzyH6tb3mqpUvS/MomIMOXfHB3sFukoiy7eH7wWaUkDNkWxM?=
 =?us-ascii?Q?Q08IHjtJIqa1kOf3t557WH6khS7S++MC7a4kct8gPPnevidYOHZQ4fdgsU8h?=
 =?us-ascii?Q?9qMnustVblX2dfvrrjM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR18MB4339.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05e9431b-4bc6-46fa-a74d-08dc7338de47
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 10:38:46.4236
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ByULsSLKrKYbVYmMluXhU8rghES0op7XygV9oAChvbKseohAn8x7mPynp8zlVU7Fzk+LiKQ48UtaGtFAt8/CqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4381
X-Proofpoint-ORIG-GUID: Z_N5ufNoJKy7V2w3F91nN3kPD5mu9mqG
X-Proofpoint-GUID: Z_N5ufNoJKy7V2w3F91nN3kPD5mu9mqG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-13_07,2024-05-10_02,2023-05-22_02


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Saturday, May 11, 2024 7:41 PM
> To: Geethasowjanya Akula <gakula@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org=
;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>
> Subject: [EXTERNAL] Re: [net-next PATCH v4 03/10] octeontx2-pf: Create
> representor netdev
>=20
> ----------------------------------------------------------------------
> On Tue, May 07, 2024 at 10:09:14PM +0530, Geetha sowjanya wrote:
> > Adds initial devlink support to set/get the switchdev mode.
> > Representor netdevs are created for each rvu devices when the switch
> > mode is set to 'switchdev'. These netdevs are be used to control and
> > configure VFs.
> >
> > Signed-off-by: Geetha sowjanya <gakula@marvell.com>
>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> > index 33ebbcb223e1..ff4318f414f8 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> > @@ -28,6 +28,157 @@ MODULE_DESCRIPTION(DRV_STRING);
> > MODULE_LICENSE("GPL");  MODULE_DEVICE_TABLE(pci, rvu_rep_id_table);
> >
> > +static int rvu_rep_napi_init(struct otx2_nic *priv, struct
> > +netlink_ext_ack *extack) {
> > +	struct otx2_cq_poll *cq_poll =3D NULL;
> > +	struct otx2_qset *qset =3D &priv->qset;
> > +	struct otx2_hw *hw =3D &priv->hw;
> > +	int err =3D 0, qidx, vec;
> > +	char *irq_name;
>=20
> Please consider using reverse xmas tree - longest line to shortest - for =
local
> variable declarations in new Networking code.
Will fix it in next version.
>=20
> This tool can be helpful: https://urldefense.proofpoint.com/v2/url?u=3Dht=
tps-
> 3A__github.com_ecree-
> 2Dsolarflare_xmastree&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DUiEt_nU
> eYFctu7JVLXVlXDhTmq_EAfooaZEYInfGuEQ&m=3DMq4aRWpUpar1zTktQDlrt8Jl6
> 8BXQjkee8RpXExMCFcKMalirC_mVOYEGA0fcuSf&s=3DKg1fSyZvUeZAO0TSWVB5
> A1GPqngBfG82Tx1Dz46ZH8c&e=3D
>=20
> ...
>=20
> > +int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack
> > +*extack) {
> > +	int rep_cnt =3D priv->rep_cnt;
> > +	struct net_device *ndev;
> > +	struct rep_dev *rep;
> > +	int rep_id, err;
> > +	u16 pcifunc;
> > +
> > +	priv->reps =3D devm_kcalloc(priv->dev, rep_cnt, sizeof(struct rep_dev=
 *),
> > +				  GFP_KERNEL);
> > +	if (!priv->reps)
> > +		return -ENOMEM;
> > +
> > +	for (rep_id =3D 0; rep_id < rep_cnt; rep_id++) {
> > +		ndev =3D alloc_etherdev(sizeof(*rep));
> > +		if (!ndev) {
> > +			NL_SET_ERR_MSG_FMT_MOD(extack, "PFVF
> representor:%d
> > +					       creation failed", rep_id);
>=20
> gcc-13 seems unhappy with a string spanning multiple lines.
> I suggest living with a line longer than 80 columns in this case.
> Maybe:
>=20
> 			NL_SET_ERR_MSG_FMT_MOD(extack,
> 					       "PFVF representor:%d creation
> failed",
> 					       rep_id);
>=20
> > +			err =3D -ENOMEM;
> > +			goto exit;
> > +		}
>=20
Thanks for the feedback. Will submit next version with the suggested change=
s.
> ...