Received-SPF: pass (google.com: domain of linux-kernel+bounces-177543-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240509133304.8883-1-johan+linaro@kernel.org>
In-Reply-To: <20240509133304.8883-1-johan+linaro@kernel.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 13 May 2024 14:17:37 +0200
Message-ID: <CAMuHMdXrJkYYyCM72pYjFwCDbfO3W6HjSTEiMu_M8yH4Wsf9mQ@mail.gmail.com>
Subject: Re: [PATCH] regulator: core: fix debugfs creation regression
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, 
	linux-kernel@vger.kernel.org, stable@vger.kernel.org, 
	Geert Uytterhoeven <geert+renesas@glider.be>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 9, 2024 at 3:34=E2=80=AFPM Johan Hovold <johan+linaro@kernel.or=
g> wrote:
> regulator_get() may sometimes be called more than once for the same
> consumer device, something which before commit dbe954d8f163 ("regulator:
> core: Avoid debugfs: Directory ...  already present! error") resulted in
> errors being logged.
>
> A couple of recent commits broke the handling of such cases so that
> attributes are now erroneously created in the debugfs root directory the
> second time a regulator is requested and the log is filled with errors
> like:
>
>         debugfs: File 'uA_load' in directory '/' already present!
>         debugfs: File 'min_uV' in directory '/' already present!
>         debugfs: File 'max_uV' in directory '/' already present!
>         debugfs: File 'constraint_flags' in directory '/' already present=
!
>
> on any further calls.
>
> Fixes: 2715bb11cfff ("regulator: core: Fix more error checking for debugf=
s_create_dir()")
> Fixes: 08880713ceec ("regulator: core: Streamline debugfs operations")
> Cc: stable@vger.kernel.org
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

FTR,
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds