Received-SPF: pass (google.com: domain of linux-kernel+bounces-177544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <aacaa02c-0e58-4a0c-b180-f201f483b70b@amd.com>
Date: Mon, 13 May 2024 19:17:49 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 9/9] iommu/amd: Set default domain to IDENTITY_DOMAIN when
 running in SEV guest
Content-Language: en-US
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev, joro@8bytes.org,
 thomas.lendacky@amd.com, vasant.hegde@amd.com, michael.roth@amd.com,
 jon.grimm@amd.com, rientjes@google.com
References: <20240430152430.4245-1-suravee.suthikulpanit@amd.com>
 <20240430152430.4245-10-suravee.suthikulpanit@amd.com>
 <20240501141737.GB1723318@ziepe.ca>
From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20240501141737.GB1723318@ziepe.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzZJTjAxZ3FrRlFQUWNkeThBWnhweE1WZXZFVHd1WmtsMmFORDVOMHhSWmNC?=
 =?utf-8?B?VlBSMUVxZHJtZjVQUWhYdkNhUEZXcStacmFKRGxqVTkyZDJxaEJxSlNnSWxn?=
 =?utf-8?B?QkgyNFFnK0ZyaWE3ZDVnZTRhNEZ5K0VMNUcyU1VVMTFGb2VMSWQrKzlMRkZD?=
 =?utf-8?B?ZVVSM2t3a2xhWC8vRHBubXQ1TnoxL0hNUitzc0NXNWRXNjcvMVRRZG5ybEc5?=
 =?utf-8?B?OGduZG1pcHhsN0YzSEc1M3BIa2FNdjlUOStCWjdLTFVwNEc0am00UW44YzVN?=
 =?utf-8?B?d3Y5eks3QkVsVy9DWWVTVDBTM2o2Ym01M2VDb0xRMm1vV01DNGszK2VGVjlH?=
 =?utf-8?B?eld0OEpVd1BOQmJJQWU0Z2pHRElBZUV3UmlwRmlIS3BXOUEyeWZPOE5ob0tN?=
 =?utf-8?B?K09RZWlzbFFYTjVBcnkyQnhXNVZtazc2bVFpRkRBTktvOUxaNnY0S3Eya0Rq?=
 =?utf-8?B?d29pNVZCSzdqRE1XN3NxQzBrZ0FTMDFOeXl0VGlad1pmaDJXOVc3OXR5RFZ5?=
 =?utf-8?B?ZjRsNkhnb3owUG5Tc3E1SFM3ZnFrYVJxM3lJbHMvdVQraG53NVJwMURBR0tU?=
 =?utf-8?B?cERZenVGNlRNKzQyYTA1SGl4WXVhVjZDUlpXWGFPcWxYR1BwSExzV3lGZjJN?=
 =?utf-8?B?T0lOM1BPa2M2NjNuS2hDeTZxek8xSm9DODJ4VXVHVnJyeHp6RkhYQmtIVjg3?=
 =?utf-8?B?eElQcmZtbEZualhxWHBpSzdHSks0WnhGNUxsWkpvbFduck8vd0ZWSFJCaHl1?=
 =?utf-8?B?K0IxVlcxQXBLaktaaUhxSkgrcjc1WXFnbGViQzFvR0I3cURSZzQxcUJFUkE2?=
 =?utf-8?B?c2R2aVhQUTQxQzdHQzBLODcrVDlnUDJSMmc1Y1N1S0kyZGVqR1A1ZHN2Wm1W?=
 =?utf-8?B?b1lVQXk2RmZzaXBHMyswSTFoK3Rab3NjUGllUHkxRUVhYnVURkpMUnRUSzZ5?=
 =?utf-8?B?blhJbnZxZmNJaGl3YnR0RVNZUWoyaHRCUEkvVVJURmtJa3I0Y3J5RiswRDAy?=
 =?utf-8?B?RWdhdk9BaTN2VnhhYmdpSk96REI4YzBGOEJxTUFRSlUwVG04U1ZqOEtsWGJY?=
 =?utf-8?B?QnRlZThiNngraW9DRlpJV0haYzNMaTUyV3ZRYkdTampqYnExSEcyeFlveEpW?=
 =?utf-8?B?cTFmRmpSQzNiaUxwaU0yeW5CdjFzZk9rNjFDekM1bUo4azNFeXBKQUFiQ0po?=
 =?utf-8?B?SUpLb1VHa2haUnVEb1BXSmJUMVl3N1pOS3AzZGFSZzI5UHk2UEUzbTdWZVNS?=
 =?utf-8?B?M3lDVWJJTDY1YmZkNU8vNGsyczN3cmNlMGdTUjNZUldIb1djK2dydmROeXNq?=
 =?utf-8?B?Q0VrMEFMVnlpRmx4SEd1VXZCcDFpM2oxTGtVSmVNeGJRQituNzZISERmcEpE?=
 =?utf-8?B?YzJWQWJwU29qN1VHR0lwR3lCdzhkbzlVWWRoRHBQVGE3QmRKSHNYU0tqSVdk?=
 =?utf-8?B?NXBTQ3ZFVXJBZC9XU2Vwb1FvYTBIYmpQYmxRQUJSdy9TNENvcjRpRHZjVXJH?=
 =?utf-8?B?TnZrUlFBU1NSSXZVbkZtM1AvemJDdm8rWjZvdmc2TVlZWFdsNmhHTFRoR1FZ?=
 =?utf-8?B?eU9zdTJLTWxHQW8vMk4ra1lMK09TZG9HenpiK1FlTkZhS2tFQkpzQ2JlUzFq?=
 =?utf-8?B?TDN3NVlLWllHeVFtYmpjNWM2OVg0Zk9QZFRuL2FDd1lKNXlWZ1NFZW03MjFC?=
 =?utf-8?B?VEIrZUpXRGNDWllyc2xGcVdibzJSdURBTHZYeHFnaFpLdXREajJqTkprcHVG?=
 =?utf-8?B?NWphYVZkQTVxekVEVG5Wc2t2U2JHN05IM3lzeWtrWjcySXZWd0dLcGFrTG0x?=
 =?utf-8?B?cXhKTFhVRjBDMEtvZ01yNnQ1Y2xaRkdITnpYQzZacDVGM24rU1RPR1p1SG8w?=
 =?utf-8?B?Rjh4aWVYMWh1TVE4ZllkNWcvNkRiaHNzNzAyYnliMU9rYm56M0F4Q2o1d0th?=
 =?utf-8?B?YTg0ZjJCcnpSRGJ1aVJtSHNyOXpzWHlmdVVkTXdZRjQxaFFqVHFqd3F0OEtk?=
 =?utf-8?B?V3pKYXZaM2I4cXVGb1FlWlJ2RVVsbWxjRk4xK2VodXg5T1ExMUVrSk54QWpS?=
 =?utf-8?B?TE1tTW8zU2VxMlpSMkNkMlNqSWUvVG8xUDJFM2wwRHpDdFlMUVkvT084WU5r?=
 =?utf-8?Q?QW0Y8PtbG8M4aZ6lqArNP8BtE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57f9b6d8-0932-4332-4f57-08dc7346b8af
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 12:17:58.6882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rjUEgmHHJTO3wWS8EK1St0Yp2c/fMf3n7xBL29fX6Bv8OoTqmRxZ0wOSDJPZ07165PLcKkxQ//XIp38cZ7kmQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4145

Jason,

On 5/1/2024 9:17 PM, Jason Gunthorpe wrote:
> On Tue, Apr 30, 2024 at 03:24:30PM +0000, Suravee Suthikulpanit wrote:
>> Since SEV guest depends on the unencrypted swiotlb bounce buffer
>> to support DMA, the guest AMD IOMMU driver must be force to setup to
>> pass-through mode.
> 
> You should block the creation of paging domains as well if the HW
> can't support them.

Sure, I'll add a logic to check and block domain creation.

> But, is there actually a functional problem here? Doesn't swiotlb work
> OK with iommu even with the encrypted memory cases? What is missing if
> not?

Currently, SEV guest is default to use SWIOTLB. This does not have any 
issues.

However, in order to support vcpus w/ x2APIC ID (> 255) in a guest, it 
requires guest interrupt remapping support. This is achieved by adding 
QEMU-emulated AMD or Intel vIOMMU models.

In case of AMD IOMMU, depending on the CONFIG_IOMMU_DEFAULT_PASSTHROUGH 
kernel config, it would default to setup the v1 table for DMA remapping, 
which is not supported in the SEV guest (since it requires to use SWIOTLB).

This patch is needed to avoid the need to have 
CONFIG_IOMMU_DEFAULT_PASSTHROUGH=y, or specifying kernel command-line 
option iommu=pt in the guest.

Thanks,
Suravee

> Jason