Received-SPF: pass (google.com: domain of linux-kernel+bounces-177560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 13 May 2024 08:31:20 -0400
From: Brian Foster <bfoster@redhat.com>
To: Youling Tang <youling.tang@linux.dev>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
	linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Youling Tang <tangyouling@kylinos.cn>
Subject: Re: [PATCH] bcachefs: set FMODE_CAN_ODIRECT instead of a dummy
 direct_IO method
Message-ID: <ZkIIGMlbg4s3GJFb@bfoster>
References: <20240510061058.316819-1-youling.tang@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240510061058.316819-1-youling.tang@linux.dev>

On Fri, May 10, 2024 at 02:10:58PM +0800, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
> 
> Since commit a2ad63daa88b ("VFS: add FMODE_CAN_ODIRECT file flag") file
> systems can just set the FMODE_CAN_ODIRECT flag at open time instead of
> wiring up a dummy direct_IO method to indicate support for direct I/O.
> Do that for bcachefs so that noop_direct_IO can eventually be removed.
> 
> Similar to commit b29434999371 ("xfs: set FMODE_CAN_ODIRECT instead of
> a dummy direct_IO method").
> 
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
> ---

Seems straightforward:

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/bcachefs/fs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
> index a8d71cec1c17..7ef41ce2d8c6 100644
> --- a/fs/bcachefs/fs.c
> +++ b/fs/bcachefs/fs.c
> @@ -1142,6 +1142,8 @@ static int bch2_open(struct inode *vinode, struct file *file)
>  			return ret;
>  	}
>  
> +	file->f_mode |= FMODE_CAN_ODIRECT;
> +
>  	return generic_file_open(vinode, file);
>  }
>  
> @@ -1234,7 +1236,6 @@ static const struct address_space_operations bch_address_space_operations = {
>  	.write_end	= bch2_write_end,
>  	.invalidate_folio = bch2_invalidate_folio,
>  	.release_folio	= bch2_release_folio,
> -	.direct_IO	= noop_direct_IO,
>  #ifdef CONFIG_MIGRATION
>  	.migrate_folio	= filemap_migrate_folio,
>  #endif
> -- 
> 2.34.1
> 
>