Received-SPF: pass (google.com: domain of linux-kernel+bounces-177594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <CAEkJfYPO8OK=JCFphuZvqzqCWpUjPiTVoHma3CY0gLo+rdLKNw@mail.gmail.com>
 <20240513105413.2951-1-hdanton@sina.com>
In-Reply-To: <20240513105413.2951-1-hdanton@sina.com>
From: Sam Sun <samsun1006219@gmail.com>
Date: Mon, 13 May 2024 20:57:44 +0800
Message-ID: <CAEkJfYPxWBfEnuKeCGEsscVTYy8MrNxCJwdbxS=c2-B0H+HfTA@mail.gmail.com>
Subject: Re: [Linux kernel bug] INFO: task hung in blk_mq_get_tag
To: Hillf Danton <hdanton@sina.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, 
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, syzkaller-bugs@googlegroups.com, 
	xrivendell7@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 13, 2024 at 6:54=E2=80=AFPM Hillf Danton <hdanton@sina.com> wro=
te:
>
> On Mon, 13 May 2024 10:38:34 +0800 Sam Sun <samsun1006219@gmail.com>
> > Dear developers and maintainers,
> >
> > We encountered a task hung in function blk_mq_get_tag. It was tested
> > against the latest upstream kernel which was compiled by clang 14.
>
> BTW make it clear if repro is available and if you could test patches
> in reply.
>

Thanks for pointing this out! I am happy to help testing patches. As
for repro, I have a C repro available, but it is too long so that I
attached it to the first email. Should I just paste repro with bug
report?

> Thanks for your report. See if the below low-hang pear is sweet, I
> mean see if it could survive your repro.
>
> --- x/block/blk-mq-tag.c
> +++ y/block/blk-mq-tag.c
> @@ -180,8 +180,10 @@ unsigned int blk_mq_get_tag(struct blk_m
>                 sbitmap_prepare_to_wait(bt, ws, &wait, TASK_UNINTERRUPTIB=
LE);
>
>                 tag =3D __blk_mq_get_tag(data, bt);
> -               if (tag !=3D BLK_MQ_NO_TAG)
> +               if (tag !=3D BLK_MQ_NO_TAG) {
> +                       sbitmap_finish_wait(bt, ws, &wait);
>                         break;
> +               }
>
>                 bt_prev =3D bt;
>                 io_schedule();
> @@ -208,8 +210,6 @@ unsigned int blk_mq_get_tag(struct blk_m
>                 ws =3D bt_wait_ptr(bt, data->hctx);
>         } while (1);
>
> -       sbitmap_finish_wait(bt, ws, &wait);
> -
>  found_tag:
>         /*
>          * Give up this allocation if the hctx is inactive.  The caller w=
ill
> --

I applied this patch and tried using the C repro, but it still crashed
with the same task hang kernel dump log.

Best Regards,
Yue