Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2023962lqo; Mon, 13 May 2024 06:01:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWMeg2a0i8HB7BQiqAfXsX4J85qmf5MASdy052xXkaXPFwpPC6rcdpbs15gtOmiM8h5Gbqj84LT+6J5cT5MpXYRi90ZNAwPO7QAKDAfDA== X-Google-Smtp-Source: AGHT+IFM2JS3mAeWTLkzIe7sUyZqRLOnunDOff8dsTC6osaWQf8cpo4kZ+IF/ziaOh8g4hXxtrc+ X-Received: by 2002:a17:906:f18d:b0:a59:ad6d:26e2 with SMTP id a640c23a62f3a-a5a2d55ef30mr692754466b.22.1715605289091; Mon, 13 May 2024 06:01:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715605289; cv=pass; d=google.com; s=arc-20160816; b=p330mJbylUFhYYGFQ2ZMHkW356G6OjqOoR0iXpO118SjNq2tHVaMScz1nuL7BaXMBR lM6PRa0HgeR0RMv/gJ8qw6OdM37ECm6sOwU+uCclnaAfE+q7dNAiwQ7vZLmxtGgvWGQz BXQNbUGEAj77GkUaNXLWsF7drdm/VaoPcdYnzCjEuzDfqOsxCEv5nkKLzL30PhqaTMHS SoTXFZ83XvDBUTipU/8bn6b4xtQ1oG8qS0JQqipQcDCmKGeqVXyrfB33REgthHPu7GrQ AMiAtWpdmNSPKsa+9yWGiDqe2CpLAUq7YWrtGbTjE95M/YaeskyBvh2sgyzsALeoUqhH oefg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2Rs58EEQW/8Tv4QiXxXctVbqfNgBxWv+iDW5TsZtSKY=; fh=JV79l0OQ9dwSKSdUejy8etNZ099FF5FdHxNJr5BGEus=; b=TuzhItZ6aSIGDjm3kbsOTlRzknNcWXf/lCVoU8h7wNtfxYpB+XYuSRvFBTFR50lm/S DySkf2vUhvLJjVEjWs5E6ukcM3PkyJNngtGAuNkExz4M7FQ40TzdJus/K36xI4tTC+QI KmLk1j4Etb8WFJJj6TWHZlQmzxcPA8G60YOOdaQY43SufdDUfFWRZ/6lGJYTyK1s+xxm VjNSr7mRoSnym3o0AOVlapujB2y6XjEGllv97Ezyh4vsa2zmMhP3FTr/88P+3aW7GGIX EYVyqEsqImLqSFvFapxcyAOSkOfcSyE12Q0Pe48sq00JTIPTToX9ttt0rYTaOQzAqsNk qmDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="m6/kUc+n"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-177601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a1797cac5si481265366b.244.2024.05.13.06.01.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 06:01:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="m6/kUc+n"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-177601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CCB661F244D5 for ; Mon, 13 May 2024 13:01:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0CE301514C7; Mon, 13 May 2024 13:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="m6/kUc+n" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68D2E14C5A3; Mon, 13 May 2024 13:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715605278; cv=none; b=uGrFMLo6RQIWtzaNBN0+6cjPdBC8E8TfkNYIPNs1/zyQdvdP9y4JJggK1O66W1Xa1tsouZcSBvta5rj+zIuL+kl0eKMpwzCFXKfA4hAdh8Lku/WIGLumrjdqmlI39+0fT0NAcIYkJSnXRHymEzS/F61ye0OLEDqCS2S1PvW7SYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715605278; c=relaxed/simple; bh=zFf4IL0Y1mUxcwPfjq2+ak1Dh56hOP+unCJYEQ6Wfnk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mnQjRMJbcT+2YAcysCV654icDcQI2kx6BEimIX6Tr71OlECRTX0Sm2rdrNEyR7XlW53ZXDp8OWpDDmc+F3LYsYXuGtqc5TmISSNsQW8pCHXjuogze1d0g8Sx1e0/HIXwlUA6GqZ5cY3+xlRkP5DFHTC85Ztj09raVS1gKurW05c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=m6/kUc+n; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=2Rs58EEQW/8Tv4QiXxXctVbqfNgBxWv+iDW5TsZtSKY=; b=m6/kUc+n3CYBToleHdtj6whAVJ QzD0OtILsFNOXN9SO2gBV0Sm1Px8ekjYWefiA4JMLxnJ82kMksMw/AuNZOUM6T5eCV3N3+ubuZyQz aAJ1sTlavsRTJZCOnGeGrFWq03Hqc7K/o6CtvcfghEZgK7R880u+kYmdWgQOZy+10XjE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s6VIO-00FIzh-As; Mon, 13 May 2024 15:00:48 +0200 Date: Mon, 13 May 2024 15:00:48 +0200 From: Andrew Lunn To: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez Cc: Piergiorgio Beruto , "Parthiban.Veerasooran@microchip.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "saeedm@nvidia.com" , "anthony.l.nguyen@intel.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "corbet@lwn.net" , "linux-doc@vger.kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "devicetree@vger.kernel.org" , "Horatiu.Vultur@microchip.com" , "ruanjinjie@huawei.com" , "Steen.Hegelund@microchip.com" , "vladimir.oltean@nxp.com" , "UNGLinuxDriver@microchip.com" , "Thorsten.Kummermehr@microchip.com" , Selvamani Rajagopal , "Nicolas.Ferre@microchip.com" , "benjamin.bigler@bernformulastudent.ch" Subject: Re: [PATCH net-next v4 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking Message-ID: <708d29de-b54a-40a4-8879-67f6e246f851@lunn.ch> References: <77d7d190-0847-4dc9-8fc5-4e33308ce7c8@lunn.ch> <874654d4-3c52-4b0e-944a-dc5822f54a5d@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > I've enabled some debugging options but so far nothing seems to hit. > What I've been able to conclude is that there still is SPI > communication, the macphy interrupt is still pulled low, and the cpu > does the ack so that it's reset to inactive. Is it doing this in an endless cycle? Probably the debug tools are not showing anything because it is not looping in just one location. It is a complex loop, interrupts triggering a thread which runs to completion etc. So it looks like normal behaviour. If it is an endless cycle, it sounds like an interrupt storm. Some interrupt bit is not getting cleared, so it immediately fires again as soon as interrupts are enabled. Is this your dual device board? Do you have both devices on the same SPI bus? Do they share interrupt lines? Andrew