Received-SPF: pass (google.com: domain of linux-kernel+bounces-177630-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <abc8fb59ceb102895320850609c7d6e29aedcf1a.camel@physik.fu-berlin.de>
Subject: Re: [PATCH 0/3] sh: Fix missing prototypes (part three)
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>, Yoshinori Sato
	 <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Arnd Bergmann
	 <arnd@arndb.de>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 13 May 2024 15:30:02 +0200
In-Reply-To: <cover.1715606232.git.geert+renesas@glider.be>
References: <cover.1715606232.git.geert+renesas@glider.be>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 
Precedence: bulk
MIME-Version: 1.0

Hi Geert,

On Mon, 2024-05-13 at 15:20 +0200, Geert Uytterhoeven wrote:
> 	Hi all,
>=20
> This patch series fixes more "no previous prototype for <foo>" warnings
> when building a kernel for SuperH, namely when building j2_defconfig.
>=20
> Thanks for your comments!
>=20
> Geert Uytterhoeven (3):
>   sh: of-generic: Add missing #include <asm/clock.h>
>   sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING
>   sh: setup: Add missing forward declaration for sh_fdt_init()
>=20
>  arch/sh/boards/of-generic.c | 2 ++
>  arch/sh/include/asm/setup.h | 1 +
>  arch/sh/kernel/smp.c        | 2 ++
>  3 files changed, 5 insertions(+)

Thanks a lot for fixing these. I have run into these as well and except
for patch #2 where you found the proper fix, my proposed fixes looked
exactly the same.

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Adrian

--=20
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913