Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2084706lqo; Mon, 13 May 2024 07:30:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXSr6gtEv58GEN1bGSc/od6srzBSBrdEKfiKFkMc7pMzJqfbVA4Afo/OCdgXmymfdzGL/C9sEaOyTdNbnI0u4talL47/cCJ69Eo/Kawmw== X-Google-Smtp-Source: AGHT+IE1WzZDCkauk51fk64Q1F40uxctnjBxn9XmnUTgxnJRcPlRDnIqfytO23Pzp5oMzdqY+Qqu X-Received: by 2002:a05:620a:1095:b0:792:c5f7:e199 with SMTP id af79cd13be357-792c75986c1mr1055973585a.19.1715610656212; Mon, 13 May 2024 07:30:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715610656; cv=pass; d=google.com; s=arc-20160816; b=M2hEN6QaVvHTD6InLztq0Pd+Xz052Y297Y8y1CO//CstpKCJvfvVa1RsiOnnR0pvug Cf2HIMGlbdjGsdi8N6BXX+CxgQoZjtxgvRS9reFmlDl0AlREOxnjj5vmkK17I7e7yHF0 fOoLN/RaIQD0ybX9G9hMDuj4lJkBpjb2zQK5Y+Q2IbzVKnRbNVsHzYVzJFOnUULariJg f/3dLLA8D5h+ewVsQ0G8qCy3hPz4wdImnajE6lLqWgKr69fLnFKh/ZfwtubSJWFNBn/j 2JrJABKw9iwAKSKs/VTAvTrHaMJ7G6sqS5J/ImIU9tJPQYNrEBmmWWr78K6ox5SL2zfA N1AA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :sender:dkim-signature; bh=R8x3p9ghcL2ZAFQw5pRrhkcFv/xwcGjp5sS2oM9BZCc=; fh=xNWOlshYuXx91QH1Y4RRCRGCCcKYK0KLTqXKU0A7Cew=; b=p7sRTIIjYoWYO0RSf/js3mxSLhlXb+O6n7A3j9Nfi/IAYaaxKEzrFE7XSPKeyb8oxy jdDn6atZji+FvlsMgUR/bG65QB7nosW+JlxrQbP9k9Nz0GZkRb/MUckwRnIUQCwlGvnC uNFUDuMiaoYk7xHAPNr7e4tZPtB8D7+9+ZGTFBOnAgFUD5Poy2cT5PWO5dZethfX6Ta6 t1aTvd6Ey3vNKgqbg6VNaTUgGEl2pExpaQ/q5slftg6/a6ZKY7vvJa/azxcmr/rc1JEc leAl1l6+R0t5E431pwOxqE9ZRz+ZiScVlV0Zu8sXgW5N0Jv2b2fumF81FzVVziWoTAGT q1sQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lmS4n1CR; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-177699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177699-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-792bf33b58dsi1031688285a.510.2024.05.13.07.30.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 07:30:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lmS4n1CR; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-177699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177699-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C84CC1C214D8 for ; Mon, 13 May 2024 14:30:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B873185E; Mon, 13 May 2024 14:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lmS4n1CR" Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C9F629; Mon, 13 May 2024 14:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715610649; cv=none; b=PRmYtZDElFkEfVNH5xni/VM3RTFUa2ik5IzfElHbwIfSX8MxAkMcRGW/gG54yMFfcT57W/ilNqk/gzj4u7CwZyjBARWb7J/2OfAz1R6RmYs7UKY+NGHbGz64QCJCxJPj8kedNBCAMPhtbJ0j+1QgSh+9aRJZjoBmZxT7xXnAh24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715610649; c=relaxed/simple; bh=YiCEVq9OKDOVSyQTIuMfnt+QYIgv/V1nyYSpr91wlVQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ux6OZlJeFCHcEvRA8WTuChzs1JrS8+9nI/Yjek3KI0FoLXe3c6Knc9vjiyboFLbntS4MdJ9GhZTWfuKcMiToomEGFn4TUJMaTaQLqftcXu5bVh0Ia8vsiIjFjwBJHdAquurqJsRgLBZt+nQONbHnWT/brOYNskKcjhG3O9olQvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lmS4n1CR; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6f453d2c5a1so3632726b3a.2; Mon, 13 May 2024 07:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715610647; x=1716215447; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=R8x3p9ghcL2ZAFQw5pRrhkcFv/xwcGjp5sS2oM9BZCc=; b=lmS4n1CRSS1EDcVXGCRrMXQcX63TLpKDhzo2iqwQBn7dpq0e2Uz5foZmbkfFcIYtu9 bHEp1JX+hChMpwUOcTvZvhRgyF4eO3XMlMqw5pF5OYmmvAZYIPQn6W0F4LAp8J99ptrQ IFWU1DIy30/RFPY3zgyaJjk+oCE6jhbBisrOnr8SOLTrirMWsiUsCmazDsaBKLEnacY5 b+n0haf9CaY2aMf8VQMfxkNImqdbTMTXkY8OTAK9L21a/N5K9hkd3IXiln04N639swwj of1cgAXrJfMs6EM7aKx5x9YLyTzmFG39eBtqzDU4oXUEmcjZ8lqomLr1vSYBEK7eePVc MSXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715610647; x=1716215447; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R8x3p9ghcL2ZAFQw5pRrhkcFv/xwcGjp5sS2oM9BZCc=; b=Fyz9YhkpOHhA9ISu8MFOmOwr0/vloSJns1dJn2hBuH/uTT6j3OlbTSQ1meFh5WKX4T KoPWTsVDUcJ+x4mjoInPZO2zKsAW4BNKzYZkDzBa+HBDg6pdgKnlIXsZy2ma9tvTQe5R VYu/fS55DoGq5SsS3oDtwLgM3aZPSqCnl24e9/9KkOk2ruvWLYeZtqXJY7RQhWXupJiW js249l/cZWPUOITb856ycjCK3tmBPsdqk5uv03U8buNazBY7MMXIf2ZPbkTrgdz0ysIg Dk6gqbbMjDtn6+GeR74irEajEVA4bc3GIJF+YSwrzHeKrt1bc9ucfiCHCtypEzhLaaeO 1YtA== X-Forwarded-Encrypted: i=1; AJvYcCWPBlQDLCcAiQB7W0h4/Hats0LN5KZXrzNGVWg17ZjRUh5UqRz06a4Qpk9bOsP/3VC87ADI8vOXhKnmz0Xr2sYUHgPfrUKlloMo2Mk2 X-Gm-Message-State: AOJu0Yxxs6deaKPVdzZ93rEXJmiMggVtcpdI8PjNPcSMScYZbKbwkST7 3xvT5bQgYcaNtV7zcPZCl+XiCijOv9PsgpNYrJnMQbh0rI7ZD/Tp6yrJGQ== X-Received: by 2002:a05:6a00:4f86:b0:6ec:f0e7:d942 with SMTP id d2e1a72fcca58-6f4e032358amr12956582b3a.28.1715610647147; Mon, 13 May 2024 07:30:47 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2b02329sm7408204b3a.181.2024.05.13.07.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 07:30:46 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Mon, 13 May 2024 07:30:45 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hwmon: add MP2891 driver To: Noah Wang , jdelvare@suse.com Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/12/24 22:52, Noah Wang wrote: > This driver is designed for MPS VR controller mp2891. The input > voltage, output voltage, input current, output current, input > power, output power and temperature of per rail can be obtained > from hwmon sysfs that the driver provided. > > Signed-off-by: Noah Wang The chip name looked vaguely familiar, and indeed I found: https://patchwork.kernel.org/project/linux-hwmon/patch/TYZPR03MB7130A7F41D61BFB611DDF0C7FA479@TYZPR03MB7130.apcprd03.prod.outlook.com/ So this is really v2 of your patch without saying so, it pretty much ignores all feedback I sent as response to v1, and it does drop support for limit and status attributes for no reason. Please don't do that. Guenter