Received-SPF: pass (google.com: domain of linux-kernel+bounces-177701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jiasheng Jiang <jiashengjiangcool@outlook.com>
To: nirmoy.das@linux.intel.com,
	jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com,
	tursulin@ursulin.net,
	airlied@gmail.com,
	daniel@ffwll.ch,
	chris@chris-wilson.co.uk
Cc: intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@outlook.com>
Subject: [PATCH v2] drm/i915: Fix memory leak by correcting cache object name in error handler
Date: Mon, 13 May 2024 14:35:48 +0000
Message-ID:
 <BYAPR03MB4168C6D020B750EAF8021731ADE22@BYAPR03MB4168.namprd03.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BYAPR03MB4168:EE_|SJ0PR03MB6730:EE_
X-MS-Office365-Filtering-Correlation-Id: 991093dc-59c7-459d-264d-08dc7359fff8
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|440099019|3412199016|3430499023|3420499023|1710799017;
X-Microsoft-Antispam-Message-Info:
	iHJaGdwxz6+ApXs0JqNOTpOL/vDcBTcavGHqrVxqYqAoFjr4XavK0InF37wo33fnKl2NAQfDJyBpq2adD4QcnOnMbD94VeNCX9K/uxON9HKp9jW4VQJGMbs7EIFRZPWowhuGgyJqxksnoMumYUchqjCiTIRoQG6vJg0c6dEWx3i2QLM/+8Rux4hSfhUX0F5TVt0Za69V93qCv+BECDjBgpsz6vd8EgTRbgiawZ3B4JOFxue0vwGz+17Jx3GrXEM5dhIl7ZqLNzUlpig/RMdjyb5l6ugEQw3h23C0VhDRi7tGOacjhXb9oL9TxGVa8NvNt9i24/ScHgGUQnWf/DTB1WI4h4sG/qzTKq7rYJLcUOGHH/cNTPieZz54KsKR8JXA4OsRrCuPBEh5hJ67L+0MGD0DRH+cfchiYB8Z4gjXcuYfIUQJ4LQq8E7RZIbcs+8ELS3iYO5A5CMlhuaYmUqpfzH5CkaqT48dP/GixtjZGAQDz3K2cd6PkwUqdzpOHnz0vjAuDaM2iWnvTA6Q3rTZm8pPTKB8Ags5+1prg9pfd+9G8jcWmfhE8bXv7g1mtSQZSPTJpHqZS7pBRTKsM15aj6+GCDyj63NNiFyxEv7ELMCNtldOzDbW6WI8ELsGTsbQ
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?iT2kMiF4xiUPXOrovIiDX3pRnwcrN9ThKtzc5GMMnrKxSXmWLEgbNTKrweJ4?=
 =?us-ascii?Q?MM6CP+gBa4My7SiBKouReeN9x8hJJuXefjL3QabyTKHEfwBSo2SrIcKdwKR2?=
 =?us-ascii?Q?z67S18TEzXWb7qujPYpHu3OPpjnQrvAzxE5iHkk61nrLPglpEOxRDUaUi9LP?=
 =?us-ascii?Q?zai3bac3d1G6IYhkBjwHWkkDJwLaHd5WfL0Gj5COdZT6p5br+Ysz+48hG8sr?=
 =?us-ascii?Q?jIUil28+5udzDFFmyyYfANT7mERF+txNyxSM6+8Ee+qHpCZMPwF+w+dqfPEA?=
 =?us-ascii?Q?n/LqhVJQ2wbUokpfTDWdyMq6oXLn51kt+KPPmZr0sAH1l320WlfMoWL46qba?=
 =?us-ascii?Q?q7+vvpwWwoBuNy4LLukaWHRSJJjpaFCQu5UFAKQeHBZGnK/XqR3nFymOVc0x?=
 =?us-ascii?Q?UJKv1isnrlx/p3+kCb4EcIQbNtiy9MGVixZrG/oHtNz8bKStv1KQUpCaGCK7?=
 =?us-ascii?Q?/E7QhNr6HsSvo0RM3uujOAb1H7Ri4fC7PlUdKKIuSbQ2vwMSc46TP6OQ9365?=
 =?us-ascii?Q?S61szPbons49PLWwqWGkSGht9UcHYQpk9xT8sTPj+L8+npwUCRwWCHjWLWUJ?=
 =?us-ascii?Q?KoxogVwvBTanzcM9x13BFybt9KQ5emA4xcPnZCUMdhATPKvXritgt3xkO3cJ?=
 =?us-ascii?Q?JNKS6htl+1TyBz9d4MjrhMz4iFG0bYvx3AI1kWLlapf0nMZ1rys8Nz2nwrCs?=
 =?us-ascii?Q?4Xv9nEYAKaQIL5OeOXIamI0YHmgYXSJc9F0js93Objlb4gqmePQ+5NCbEagJ?=
 =?us-ascii?Q?UwX1NE9DeycNg+4C/SkWSJmIF3uKWz5uQsj+xaDciypWlVWb9MRx/8HU4LQg?=
 =?us-ascii?Q?CcuvY8i00hSyJL+NEjKy1TMc0aYU8iuStbV/0K8JtdxtteJ910vilog45a/P?=
 =?us-ascii?Q?2kwMUDKqfEA+JKQvo0JZCjrLIamz99eNxvwvmu4C6T1tUrWZe6GeS8/uUl3k?=
 =?us-ascii?Q?5uMqelS3Fq4TcYAxgl1ETiGbRu+Bq0+HJgvNiC3+iW2bgfSLstz5Z/ZkdC7f?=
 =?us-ascii?Q?IHO+C0qcoH5eqPvjKSucURmfomJe2G8tIL5z2dv+oi8kPbnRIYJ8CMg71L32?=
 =?us-ascii?Q?ajOcC5Gpa0WuXwbGCBeu+SjCKj4g0AuJhkA7yKhgUjlyXcyHJIAUiRsADTpF?=
 =?us-ascii?Q?4bZc2gH5Q0tLypQsakR2hAM4svPy/Uq15Hw3ZeQkhy7JFRCsDMDTg++HWfBA?=
 =?us-ascii?Q?QwL6S4/KUJVP94zunQ0frfHopufr3Nwmmo98hLqPMtVNvA1Dld1TpczvlcYE?=
 =?us-ascii?Q?E5LF1ZRaxpGMe5DQBhYG?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 991093dc-59c7-459d-264d-08dc7359fff8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB4168.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 14:35:56.5840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6730

Replace "slab_priorities" with "slab_dependencies" in the error handler
to avoid memory leak.

Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@outlook.com>
---
Changelog:

v1 -> v2:

1. Alter the subject.
---
 drivers/gpu/drm/i915/i915_scheduler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
index 762127dd56c5..70a854557e6e 100644
--- a/drivers/gpu/drm/i915/i915_scheduler.c
+++ b/drivers/gpu/drm/i915/i915_scheduler.c
@@ -506,6 +506,6 @@ int __init i915_scheduler_module_init(void)
 	return 0;
 
 err_priorities:
-	kmem_cache_destroy(slab_priorities);
+	kmem_cache_destroy(slab_dependencies);
 	return -ENOMEM;
 }
-- 
2.25.1