Received-SPF: pass (google.com: domain of linux-kernel+bounces-177702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Jiasheng Jiang <jiashengjiangcool@outlook.com>
To: nirmoy.das@linux.intel.com,
	jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com,
	tursulin@ursulin.net,
	airlied@gmail.com,
	daniel@ffwll.ch,
	chris@chris-wilson.co.uk
Cc: intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@outlook.com>,
	stable@vger.kernel.org,
	Nirmoy Das <nirmoy.das@intel.com>
Subject: [PATCH v2] drm/i915: Fix memory leak by correcting cache object name in error handler
Date: Mon, 13 May 2024 14:39:52 +0000
Message-ID:
 <BYAPR03MB41688E0CA5B01A0017EFD33DADE22@BYAPR03MB4168.namprd03.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BYAPR03MB4168:EE_|DS7PR03MB5464:EE_
X-MS-Office365-Filtering-Correlation-Id: 18790f6b-f555-47c9-b37a-08dc735a91a1
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|440099019|3412199016|3420499023|3430499023|1710799017;
X-Microsoft-Antispam-Message-Info:
	KZBjxWvI7IapnUpF9KyEYplQ69EZ8ULju/pTcijD8dnWJbV7lBjz7zcR2FdAp4aY5ZQJYKwklwCXekYeI+eUy7CSpayiWDke4eMadpBAnKfkucykz9rtPKkle1cNpUBK0sLKw2XMUTeP4tbqxw0sAe5X2GHCenKY0A+5ffu3Bb5djhFy/L5/kn2R2qb864RXN9uFR58RzMAFqc6zHmwj7F0hxOIQWXwHjnqIDCdVB6kBZ/5MjpWYfSPjuetMe1ZtKau/N7pJFM8nBvZ336n2PAN4CKV/yb/TWHuUaJGJMIrejbAP+R96A8yxp6HxLoGTmB7OigxgvAO5NvEMiuDYiPpdU6GzbdgJkOWTTOwDlXyUbOxyPXtsk+eUDHTeiTIb20DijNe+d0qkR38z7euGBoLVfofyhg2AODvD3hEgRcv4yFQoKccckIx7jqtRll+hUxynSDJ9tRfezlND9nXYbBfCASVaqI4GWgnXYf+Y2Y8DvQHreqw4mRqeBO6AumO7l7OHGwC3taSFJhGvfFcVmbJdNPzuPxmrgSqdphK5cX2PNVxQzaS6XF0Xzz0VSoih24c/sLRQHbonFgYI8a6yunatjg0NC7LSHlHLNFO5TAXkwOVtqtArwmWKI8UaAqS+
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?AFZA6nTJq/gNXLHUft3z1j9rADPDiVAEApf80d1742s4DpJq4qSuKR5XZT/V?=
 =?us-ascii?Q?jwaC9feCyiXJ9g46VSyKi6/lBEbp+Jl94yLTyT5AhlRef9jse7zVFveLJZHR?=
 =?us-ascii?Q?eFPxxq60/eFq3YJvYd8y3ZjiuGghoF7PHHaMVDIIq87Gnuc+5Y5KIXf0zneJ?=
 =?us-ascii?Q?rcqJjqpnr9jaFEgYIonZTixFqAcqGQcslkS5+1L39MJsWULIWmzbBiJus5+D?=
 =?us-ascii?Q?3S+nHOOxdR4k+vboCViR7SzTEZL7q9KBWlVfHb2WJlL/2xktnCEL0lkpF/qw?=
 =?us-ascii?Q?YQMAhZnkzZ+tP+NhFcNaKxWDhpGqZKfNJVBJJBGpZtHD2hKH+VzVbGv+YcIz?=
 =?us-ascii?Q?P/nXMy1fKQHLkYBWnEUKom4MpYNj7fPTZNOo3/8HIG036FEpfXMaMG7vt5Ep?=
 =?us-ascii?Q?kFBAc3bl3MaO1f5i3Jb6pLNHIqrQx3zfr5JjZcGKnhU9IpWyHDKnxKVdnDMi?=
 =?us-ascii?Q?q0nVL6Ec4WeSC74mOH6oLYYRhQkW5xeDMyjfSvwJBDOgpF5L7h7C2UWrxOzW?=
 =?us-ascii?Q?QbTQOOQq0znT8YS7x5BVbPjUiGZs6GURmyoK3EWQ+q0+plE4EmYh7Y4ZzIJM?=
 =?us-ascii?Q?AyCTU7BpmMuVNB/y/xHU725wbCZEUM8CT+yfdTg3y2zon6RpJkWoiH92e35v?=
 =?us-ascii?Q?FULbkLRdtHRGRuvSDVXBDUgJDAYcSKx2YRXDAeCHKc2TCu2MrT+Re2NlvsE0?=
 =?us-ascii?Q?2TNdcmm/MpxyQTUxekl9imPeXxWe11qmnLXKH25NqL0yBCwpzGXeDGL4yZtL?=
 =?us-ascii?Q?AYrkqgj9+9RhLWkkudDkmd2zEdRePyM2t650Pkz5xcpaBSjAparkSXkYZzrc?=
 =?us-ascii?Q?7/Hn+oQfA0zkWeIfDNsOsDdc0fRLoyeLYctF8MvMgnOeDuiBJ+Qsy8QuXYz0?=
 =?us-ascii?Q?TdaQo4QIcaS4B7mr5u795rijKIpW9DW94ASNJ9NKoW1mYPuCsdUbPE3ZuB5C?=
 =?us-ascii?Q?UaQBUdfhQb75DuzLmkhuEwDbubifT/ytbUKX039qNzHRNk/Jwt7P9masiKhG?=
 =?us-ascii?Q?NY2w788zpF+THUIUKF8tGo8Z44lYpI5K9PCsXCUAKKgDMRBquoSCUXDFlXEC?=
 =?us-ascii?Q?2CPenVtjPENAsRCpOS8pMub++oHI4rgtgitanaLlzgjLuCanVwKnkaFJwFpq?=
 =?us-ascii?Q?oWXRJPePTydqW0eZ1+JEHiYCshjIGe2CL15BJ/OhdkrjggK3LLGeYpjEjoMC?=
 =?us-ascii?Q?GVXEkEg6yNmh7AbMFyewg6QAqJhhpA8wGwX2CxPmZWSkCLVF1DD/3cG5qbhC?=
 =?us-ascii?Q?jVzvVjiL6T0eIyCNCdIE?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18790f6b-f555-47c9-b37a-08dc735a91a1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB4168.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 14:40:00.9407
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5464

Replace "slab_priorities" with "slab_dependencies" in the error handler
to avoid memory leak.

Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")
Cc: <stable@vger.kernel.org> # v5.2+
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@outlook.com>
---
Changelog:

v1 -> v2:

1. Alter the subject.
---
 drivers/gpu/drm/i915/i915_scheduler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
index 762127dd56c5..70a854557e6e 100644
--- a/drivers/gpu/drm/i915/i915_scheduler.c
+++ b/drivers/gpu/drm/i915/i915_scheduler.c
@@ -506,6 +506,6 @@ int __init i915_scheduler_module_init(void)
 	return 0;
 
 err_priorities:
-	kmem_cache_destroy(slab_priorities);
+	kmem_cache_destroy(slab_dependencies);
 	return -ENOMEM;
 }
-- 
2.25.1