Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2098734lqo; Mon, 13 May 2024 07:54:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVowl8epDxf1pB2dWU5wxZqGRKYPmAJSHckncmSG596JqyLp7ATkvuJh/BBgsaT7lIk8ZbL0QUDVgDgMmoYucxhWpcttgCa7zEdopYEnA== X-Google-Smtp-Source: AGHT+IHy9RgavBXqVyAFFQBkn9N+aiXsZeRCzLjWXIrMFTD8VECN82OmJAZb6AaLp7GlGBEyIjvl X-Received: by 2002:a05:6358:3116:b0:186:9d05:5f0 with SMTP id e5c5f4694b2df-193bcfc6ae9mr1004989855d.22.1715612053824; Mon, 13 May 2024 07:54:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715612053; cv=pass; d=google.com; s=arc-20160816; b=RJN3tSwze/HHbkc0lPBl/o7XrKy7xoq2ibjGzQEqD+/k11fxPuZ4DDmQHU1HEcHU4/ +yYzZJ4Xtpm7qAELM3lQDevDGv9p045ugtl2csm6N2bo33nYNtUvu9yBAvN3i3j2hZ04 7eJF1iRug6FA4SWOEvZ8ksL5MKL1UYWPcQg91fBNB8AFARiHca8oanhm3gEodlAVg9H2 7P1ucpd0+A6jiIyns/uN/GZgoejKFNK5AvEpjgc/YZVH+2li0ZPmTHQcetnPZD6qSlul 5H6XujS1bokcxFVkT58S4oh8g7RmHqqCmD95ul9mVPSvRiJWaebfa1S3a7rgFZIb0zHX h9kg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=l4ySMYpqjkpOitgHTVWoc/UA50JDtpOjtuBPepFY0f8=; fh=t0KylaWfu2xM6QmG1LfwWButxScPBGSxc4TIC3M1Xwc=; b=JyU4mKeeXwkmDesUatEOI6vwf5+IRoCekl06FG/CvJW0iyQKN2v0RJOHiZMPKy+DKR 3fujBMjHMaxUyv60mFL4jL3P3gYwhkr/oM3EfdluROcXIx6A8Z68dG9a/aH7tCkGT4CS UFkkbDM4oDDxKJZbC4izIwBO+os7Cmw5ooPn9unHJIinKUAgFMEyzn2I09QCUGXpqTOS tQoWAssr97YrHDWHfAQSMr5m+7/3GZNpANboMwSAcTol/vr3G/cm9v3ZifCmW60dSVrh sm3/YR0+a7XIt2gtuMFcmpj+oZdevNkrkL/k/8OuLV9HMqkZKHUvxq/148fvXkxm0i3N x81w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XiGMMNwS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-634133dec6esi9622085a12.788.2024.05.13.07.54.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 07:54:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XiGMMNwS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A7385B229D0 for ; Mon, 13 May 2024 14:54:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A05B75240; Mon, 13 May 2024 14:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XiGMMNwS" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4601C01; Mon, 13 May 2024 14:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715612039; cv=none; b=N21o0euDsU2eomTAe7NJa9cNFJKsVoEMjgCyRdHchBsbouwJuRYS/LMODax6PxK2xZ2D63zyIpsY5kkdp6zHkaauQQzDgd0Wa3mO51Mxkwje0A3Jf4dDZnvJQ9iSdKg3QKhEABlovrXgyzFutoOV3vxvagwIF2QsSIQI7uTTDEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715612039; c=relaxed/simple; bh=dLfguYFlEZM8pXj+gnfRKXow5bLqSaYtXraAJ28Xh+s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V3AWRf9pwM3PZQdGvjqs4/WUcYV/MfCb6+Vlv70DsxNXsZ8r26PBe7AdtfVKzBeSxgA7XYS57x3G2IjTlA8GIyG3Vyxll77ZdDDhdFoo1nK7+cSPRci4M6ZL4JQGnJgegRwU28HxWw4+5rp4YdZryeXkzce4g6QYgaq2fD4oidU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XiGMMNwS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0372DC113CC; Mon, 13 May 2024 14:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715612039; bh=dLfguYFlEZM8pXj+gnfRKXow5bLqSaYtXraAJ28Xh+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XiGMMNwS0pqUaXc/XjsL9E0Ll3T4d4WZIAw1c8zOCWDCHCbkesjjdnlLtfqWR1f0N 2NxNyqSTtyGAfD7QyxJlJ17wJF9rBsn4aWaUxr2CxUyfIx1OScZG6/okfkOnwUdbFN ZbryLIj8PRNzMSpzBTr4DqhdFnBgg9eEC35YCON7w403zoetxm21pUe1Yz+4NAY+Kr nzLZZAefzR9nluD7nQ+sUDQa/ubpKr17a+7pRv/G3XGdNoTFpFeTcd1nhLJLo4oOCg mkiZyqKU4dQZO1yagMaCcqgq+YnAI+iNOk9Ck7xs7NofaMpNhJ60h6JjM/t4oJO98H 7bcI9oMtxAKYQ== Date: Mon, 13 May 2024 09:53:58 -0500 From: Rob Herring To: Herve Codina Cc: Thomas Gleixner , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 09/17] dt-bindings: interrupt-controller: Add support for Microchip LAN966x OIC Message-ID: <20240513145358.GA2574205-robh@kernel.org> References: <20240430083730.134918-1-herve.codina@bootlin.com> <20240430083730.134918-10-herve.codina@bootlin.com> <20240507152806.GA505222-robh@kernel.org> <20240513143720.1174306a@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240513143720.1174306a@bootlin.com> On Mon, May 13, 2024 at 02:37:20PM +0200, Herve Codina wrote: > Hi Rob, > > On Tue, 7 May 2024 10:28:06 -0500 > Rob Herring wrote: > > ... > > > +examples: > > > + - | > > > + interrupt-controller@e00c0120 { > > > + compatible = "microchip,lan966x-oic"; > > > + reg = <0xe00c0120 0x190>; > > > > Looks like this is part of some larger block? > > > > According to the registers information document: > https://microchip-ung.github.io/lan9662_reginfo/reginfo_LAN9662.html?select=cpu,intr > > The interrupt controller is mapped at offset 0x48 (offset in number of > 32bit words). > -> Address offset: 0x48 * 4 = 0x120 > -> size: (0x63 + 1) * 4 = 0x190 > > IMHO, the reg property value looks correct. What I mean is h/w blocks don't just start at some address with small alignment. That wouldn't work from a physical design standpoint. The larger block here is "CPU System Regs". The block as a whole should be documented, but maybe that ship already sailed. Also, here you call it the OIC, but the link above calls it the VCore interrupt controller. Rob