Received-SPF: pass (google.com: domain of linux-kernel+bounces-177713-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9a3b5af5-7370-4bc4-9529-48f9fb4b1c5a@phytec.de>
Date: Mon, 13 May 2024 16:55:30 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] arm64: dts: ti: k3-am6xx-phycore-som: Add overlay to
 disable eth phy
To: Nathan Morrisson <nmorrisson@phytec.com>, <nm@ti.com>, <vigneshr@ti.com>,
	<kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <upstream@lists.phytec.de>
References: <20240502230829.1983678-1-nmorrisson@phytec.com>
 <20240502230829.1983678-3-nmorrisson@phytec.com>
Content-Language: en-US
From: Wadim Egorov <w.egorov@phytec.de>
In-Reply-To: <20240502230829.1983678-3-nmorrisson@phytec.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Nathan,

Am 03.05.24 um 01:08 schrieb Nathan Morrisson:
> Add an overlay to disable the eth phy for all am6xx-phycore-som
> boards.
> 
> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
> ---
>   arch/arm64/boot/dts/ti/Makefile               |  3 +++
>   .../ti/k3-am6xx-phycore-disable-eth-phy.dtso  | 19 +++++++++++++++++++
>   2 files changed, 22 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/ti/k3-am6xx-phycore-disable-eth-phy.dtso
> 
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index 9a722c2473fb..030c47b2d7de 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -53,6 +53,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-am642-tqma64xxl-mbax4xxl.dtb
>   dtb-$(CONFIG_ARCH_K3) += k3-am64-tqma64xxl-mbax4xxl-sdcard.dtbo
>   dtb-$(CONFIG_ARCH_K3) += k3-am64-tqma64xxl-mbax4xxl-wlan.dtbo
>   
> +# Common overlays for the phyCORE-AM6* family of boards
> +dtb-$(CONFIG_ARCH_K3) += k3-am6xx-phycore-disable-eth-phy.dtbo
> +

Don't you want to add the entries for build time tests/CONFIG_OF_ALL_DTBS?

Regards,
Wadim

>   # Boards with AM65x SoC
>   k3-am654-gp-evm-dtbs := k3-am654-base-board.dtb \
>   	k3-am654-base-board-rocktech-rk101-panel.dtbo \
> diff --git a/arch/arm64/boot/dts/ti/k3-am6xx-phycore-disable-eth-phy.dtso b/arch/arm64/boot/dts/ti/k3-am6xx-phycore-disable-eth-phy.dtso
> new file mode 100644
> index 000000000000..356c82bbe143
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am6xx-phycore-disable-eth-phy.dtso
> @@ -0,0 +1,19 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +/*
> + * Copyright (C) 2023 PHYTEC America, LLC
> + * Author: Garrett Giordano <ggiordano@phytec.com>
> + *
> + * Copyright (C) 2024 PHYTEC America, LLC
> + * Author: Nathan Morrisson <nmorrisson@phytec.com>
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&cpsw3g_phy1 {
> +	status = "disabled";
> +};
> +
> +&cpsw_port1 {
> +	status = "disabled";
> +};