Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2101513lqo; Mon, 13 May 2024 07:59:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUhFg4AnjRR06iGUW1N4dfuDLQiOT4yHQxq2ynwF1wFY6zN+U90tR2hAWDYrOcxP6dx/vWvru/a4yipWUvZyLqReRIwnt+xhhWijknKag== X-Google-Smtp-Source: AGHT+IGC5X3MlgyjX63pauzSJ34FimediX/ptl+8VqojF2nmcX2Y6L2wCGaVe9iT2VIDg3DDqT/q X-Received: by 2002:a05:6a00:1144:b0:6e6:970f:a809 with SMTP id d2e1a72fcca58-6f4e02d3405mr10121244b3a.20.1715612347157; Mon, 13 May 2024 07:59:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715612347; cv=pass; d=google.com; s=arc-20160816; b=0fztSb0imIZM83iO09+WkZXBzThPFoaVobZRh+MpHijF9aa9Jjz9xEU6e3BdYwN0VW RM3YjNWONpfuSJKkcd0XzHYts3VJ9/hGTrEIrxw4dnD9MiO2fKfnZYHqUCsXAWHjhiiG Kg5vdH3vR7/CbiPNsscm1897ZVIAWVb3HAEou+ScQjd7TTpK1ii25vbchN+1yInnJ1Zl XhaZLeshqGD7KA56UYx/447XoOJfVUsvu7/xwl9hTeVeg/fzxU+PU1H3zBaPUzEYO/ob TrAWijrat+h+75YoEtQugFSbn0XHxZ7QP2qulClBpiEI41iCfNzmiBw9tuNN4BOVkmSA qU+w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=h70GGnF4+u3qU7wDfun4hFF8m/W4+qhl2AHjDhrvPAc=; fh=fJlCqHZsBVL1nxPBLRer0nWm72VyHnVBHm1r72KFII4=; b=cslw10ci1eg81swZMEEUCk7hcM+TPaw9yGSg9eTC/f9xWrD9khGBJBhH63lZZ2ujAt 4eZn6UloLugk6NQCLlWYJuLtiUF0q0W8RjknXMrX1yW1USgONOiD8V6uK7gZUnW+uDQI WLTpyB0A6qgnoS0vSStcwr2wj8AyHMuzSehGtu2XmDeaxlit78VcTpBwrmWytaIfDb0R Esm5e2+Z472z8vfKpUkuLv4WiNt0SW94LUsj7n+O2/I5UyxPqSYxtlVX6odJK86woLUA iwtDiIl5wB8MYnnHJBN2CiEkjmWn7w/tGjrZ73BTjiJ5BlueYv5qIZeES6u6p1tQOZc4 +BXg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z9UAtgI9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177720-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f4f39a58a7si4638508b3a.259.2024.05.13.07.59.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 07:59:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z9UAtgI9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-177720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177720-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C4CD02866EE for ; Mon, 13 May 2024 14:59:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E4874F206; Mon, 13 May 2024 14:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z9UAtgI9" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABCF74C79; Mon, 13 May 2024 14:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715612309; cv=none; b=Atoutrj4ClPVa5ts2pLSqpvbxdFmfzWxspPJ6FFPozZGYVAFLtygL0w9ed7wfz+CuXScJr1V6MDFft7lJwSSX78jQfYgpPZ6Mi7GGhKyiGUXb+hgu0wZMYA2Ildx3cvgBmGGjcyFdxoqCKMP9RCuYgG/XNbrVuKYeT6yKGGvTyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715612309; c=relaxed/simple; bh=V/P5iT8isuf0xGi5C2QCfFIakRJ0d6VOy5DAlXaa1sY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PYVyoIncHsDA32KL7szBGFG6DwxZqq2nOldAFGq22yUN7PlLzuXOO1qQy/vHJlFY5YHEwiWv0DvYruo5fXnSXOB3ryvgRcpX/zB8EHr+6c0Shql7WVqY/1/FMyxgnyXS3DC/rhVEpZV8vjKUgCm4av82du8rR0/+maNjqO8Mj/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z9UAtgI9; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4E31C32781; Mon, 13 May 2024 14:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715612309; bh=V/P5iT8isuf0xGi5C2QCfFIakRJ0d6VOy5DAlXaa1sY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z9UAtgI9+HkAomVzZPyNk+oLAfVVOefour6250hJVttD9mzKmEGaW5b35KOZAhUV+ BElvXm6xcRzcOBGdla1CQIpqzGv+S/t6F/DlT1C8TJzW5WFyfjDqX63vxkAYnCGKFB ghri6LVFiE7jZfrCjzNlieg+ky0EfRN+XxUcCnHPM6Jh6mSZOLKg+4otAWS/8LdUnC mFsMGuDzhraYefcTGInIdk7uaPOPxSEILeG6YWp1V1JxYhC0PmhSwsqcDjH9bf0Tum bq/YOtSih0xYjZGfEHlMRC7s73O/dd1nxljc6U5BcLGheNoGaW+a0sRWDLt7mgOAaW XQlaglOPLjqAg== Date: Mon, 13 May 2024 07:58:27 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: Joe Damato , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, zyjzyj2000@gmail.com, nalramli@fastly.com, Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , linux-rdma@vger.kernel.org (open list:MELLANOX MLX5 core VPI driver) Subject: Re: [PATCH net-next v2 1/1] net/mlx5e: Add per queue netdev-genl stats Message-ID: <20240513075827.66d42cc1@kernel.org> In-Reply-To: <20240510041705.96453-2-jdamato@fastly.com> References: <20240510041705.96453-1-jdamato@fastly.com> <20240510041705.96453-2-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 May 2024 04:17:04 +0000 Joe Damato wrote: > Add functions to support the netdev-genl per queue stats API. > > ./cli.py --spec netlink/specs/netdev.yaml \ > --dump qstats-get --json '{"scope": "queue"}' > > ...snip > > {'ifindex': 7, > 'queue-id': 62, > 'queue-type': 'rx', > 'rx-alloc-fail': 0, > 'rx-bytes': 105965251, > 'rx-packets': 179790}, > {'ifindex': 7, > 'queue-id': 0, > 'queue-type': 'tx', > 'tx-bytes': 9402665, > 'tx-packets': 17551}, > > ...snip > > Also tested with the script tools/testing/selftests/drivers/net/stats.py > in several scenarios to ensure stats tallying was correct: > > - on boot (default queue counts) > - adjusting queue count up or down (ethtool -L eth0 combined ...) > - adding mqprio TCs > > Signed-off-by: Joe Damato Tariq, could you take a look? Is it good enough to make 6.10? Would be great to have it..