Received-SPF: pass (google.com: domain of linux-kernel+bounces-177785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 13 May 2024 10:51:54 -0500
From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, tali.perry1@gmail.com,
	joel@jms.id.au, venture@google.com, yuenn@google.com,
	benjaminfair@google.com, openbmc@lists.ozlabs.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v24 1/4] dt-bindings: reset: npcm: add clock properties
Message-ID: <20240513155154.GA2595523-robh@kernel.org>
References: <20240509192411.2432066-1-tmaimon77@gmail.com>
 <20240509192411.2432066-2-tmaimon77@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240509192411.2432066-2-tmaimon77@gmail.com>

On Thu, May 09, 2024 at 10:24:08PM +0300, Tomer Maimon wrote:
> Adding 25MHz reference clock and clock-cell properties to NPCM reset
> document due to the registration of the npcm8xx clock auxiliary bus device
> in the NPCM reset driver
> 
> The NPCM8xx clock auxiliary bus device has been registered in the NPCM
> reset driver because the reset and the clock share the same register
> region.

auxiliary bus is a Linux concept. The reasoning for this should be the 
reset block also provides clocks.


> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
>  .../bindings/reset/nuvoton,npcm750-reset.yaml  | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> index d82e65e37cc0..18db4de13098 100644
> --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> @@ -21,6 +21,13 @@ properties:
>    '#reset-cells':
>      const: 2
>  
> +  '#clock-cells':
> +    const: 1
> +
> +  clocks:
> +    items:
> +      - description: specify external 25MHz referance clock.

s/referance/reference/

> +
>    nuvoton,sysgcr:
>      $ref: /schemas/types.yaml#/definitions/phandle
>      description: a phandle to access GCR registers.
> @@ -39,6 +46,17 @@ required:
>    - '#reset-cells'
>    - nuvoton,sysgcr
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - nuvoton,npcm845-reset
> +then:
> +  required:
> +    - '#clock-cells'
> +    - clocks

New required properties are an ABI break. Please justify why that's okay 
for this platform in the commit message (assuming that it is).

Rob